Page MenuHomePhabricator
Differential D14715

Replace workboard task creation with EditEngine
ClosedPublic
Actions

Authored by epriestley on Dec 9 2015, 12:48 AM.
Tags
None
Referenced Files
F15390659: D14715.id35588.diff
Sat, Mar 15, 6:24 AM
F15354243: D14715.diff
Tue, Mar 11, 2:52 AM
F15340510: D14715.id35592.diff
Sun, Mar 9, 3:24 PM
F15333548: D14715.id35588.diff
Sat, Mar 8, 2:58 AM
F15328535: D14715.diff
Fri, Mar 7, 5:45 AM
Unknown Object (File)
Feb 19 2025, 5:41 PM
Unknown Object (File)
Feb 19 2025, 7:57 AM
Unknown Object (File)
Feb 19 2025, 7:57 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter
Commits
Restricted Diffusion Commit
rPeef257250887: Replace workboard task creation with EditEngine
Summary

Ref T9908. This is the last of the things that need to swap over.

Test Plan
  • Created tasks from a workboard.
  • Created tasks in different columns.
  • Edited tasks.
  • Used ?parent=...
  • Verified that default edit form config now affects comment actions.
  • No more weird comment thing on forms, at least for now.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35588.Dec 9 2015, 12:48 AM
epriestley retitled this revision from to Replace workboard task creation with EditEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
chad accepted this revision.Dec 9 2015, 1:50 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 9 2015, 1:50 AM
Closed by commit rPeef257250887: Replace workboard task creation with EditEngine (authored by epriestley, committed by epriestley). · Explain WhyDec 9 2015, 1:56 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
2 lines
maniphest/
editor/
19 lines
97 lines
storage/
2 lines
project/
controller/
22 lines
search/
engine/
2 lines
transactions/
editengine/
29 lines
editengineextension/
3 lines
editfield/
37 lines
view/
2 lines
view/
form/
control/
39 lines

Diff 35592

View Options

src/applications/config/controller/PhabricatorConfigWelcomeController.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/search/engine/PhabricatorJumpNavHandler.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editengineextension/PhabricatorCommentEditEngineExtension.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorHandlesEditField.php

Loading...
View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Loading...
View Options

src/view/form/control/AphrontFormHandlesControl.php

Loading...
Phabricator · Built by Phacility