Page MenuHomePhabricator
Feed Advanced Search

Apr 7 2017

epriestley closed T11930: Users don't realise that they must link their account as Invalid.

(Just closing this since we haven't seen an update in ~4 months and it isn't actionable.)

Apr 7 2017, 1:19 PM · NUX, Auth
epriestley closed T12002: Set header for CURL query for the Notification server status to HTTP:Upgrade = websocket as Invalid.

This isn't a bug; the cURL request is not a websocket request.

Apr 7 2017, 1:18 PM · Bug Report
epriestley removed a project from T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): Contributor Onboarding.

Per the latest update in D17502, this remains involved.

Apr 7 2017, 1:10 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley moved T11360: Detect MySQL `read_only` and degrade masters to replicas from Backlog to Ready on the Contributor Onboarding board.
Apr 7 2017, 1:07 PM · Contributor Onboarding, Restricted Project, Clusters
epriestley moved T11632: Display invisible characters on erroneous user input from Ready to Backlog on the Contributor Onboarding board.
Apr 7 2017, 1:05 PM · Restricted Project, Contributor Onboarding
epriestley placed T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting up for grabs.
Apr 7 2017, 1:04 PM · Contributor Onboarding, Modernization
epriestley placed T9690: Remove calls to methods deprecated by newPage() up for grabs.
Apr 7 2017, 1:04 PM · Contributor Onboarding, Modernization, Infrastructure
epriestley placed T8236: `arc weld` should do something up for grabs.
Apr 7 2017, 1:04 PM · Contributor Onboarding, Arcanist
epriestley placed T4190: Rebuild remarkup image proxying up for grabs.
Apr 7 2017, 1:03 PM · Contributor Onboarding, Remarkup
epriestley placed T11217: Make Tokens modular / real application up for grabs.
Apr 7 2017, 1:03 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley closed T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts, a subtask of T12101: Phabricator PHP 7 Compatibility, as Resolved.
Apr 7 2017, 12:55 PM · Infrastructure, Guides
epriestley closed T12196: PHP7, particularly before 7.1.2, segfaults a whole lot while running CLI scripts as Resolved.

The segfaults appear to have subsided for me so I'm just going to close this as "upgrade to PHP 7.1.2".

Apr 7 2017, 12:55 PM · Bug Report
epriestley closed T12232: Phortune "add payment method" erroring out on submission as Resolved.

While we haven't been showered in free money, I also haven't seen more reports of this so I'm going to presume it's resolved.

Apr 7 2017, 12:54 PM · Phortune, Bug Report
epriestley closed T12272: Allow users to accept on behalf of packages they control a containing package for as Resolved.

I may still do a bit of a UI touchup pass here but this can follow up in T10967, since there's still some other work to be done there (like purging the old double writes).

Apr 7 2017, 12:52 PM · Owners, Audit, Restricted Project, Differential
epriestley closed T12272: Allow users to accept on behalf of packages they control a containing package for, a subtask of T12271: When users accept a revision, allow them to accept for a subset of package/project reviewers they could accept for, as Resolved.
Apr 7 2017, 12:52 PM · Audit, Restricted Project, Differential
epriestley closed T12280: mov and m4v videos don't play as Resolved.

This appears to now be resolved for me, presumably by the fixes for T12079 and T12219.

Apr 7 2017, 12:49 PM · Bug Report
epriestley closed T12287: Crumb width on profile pages is extremely conservative in Safari (always chops off the last couple letters?) as Resolved.

I think this got fixed by D17483.

Apr 7 2017, 12:49 PM · Internet Explorer, Design
epriestley merged T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...' into T8033: Inform editor when panels have more restrictive policy than dashboard.
Apr 7 2017, 12:47 PM · Dashboards
epriestley merged task T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...' into T8033: Inform editor when panels have more restrictive policy than dashboard.
Apr 7 2017, 12:47 PM · Dashboards, Bug Report
epriestley added a comment to T12324: Dashboards that contain a restricted panel have all query panels stuck in 'Loading...'.

I'm just going to merge this into T8033 since I our intent there is to prevent this situation entirely.

Apr 7 2017, 12:47 PM · Dashboards, Bug Report
epriestley closed T12335: Ability to lock a task to prevent further edits as Resolved.

T12335#214054 discusses some future/followup work, but that can be filed separately as it becomes relevant.

Apr 7 2017, 12:46 PM · Maniphest, Feature Request
epriestley closed T12337: Provide conduit access to related tasks and in particular 'mentions' as Resolved.

From elsewhere, it sounds like this is working.

Apr 7 2017, 12:45 PM · Feature Request
epriestley closed T12364: Ways to bring arc land --delete-remote for git back as Invalid.

See "git push = save changes" discussion in T5000.

Apr 7 2017, 12:43 PM · Feature Request
epriestley closed T12365: Daemon never recovers with Git commit parsing task, but manually reparsing succeeds as Invalid.

We don't know how to reproduce this, so we can't move forward.

Apr 7 2017, 12:42 PM · Daemons, Bug Report
epriestley closed T12390: `differential.querydiffs` is timing out for a revision with 20 diffs as Invalid.

We don't have any way to move forward here.

Apr 7 2017, 12:41 PM · Conduit, Differential, Bug Report
epriestley closed T12452: Can't edit task description after upgrading to the latest version as Invalid.

We don't know how to reproduce this and can't move forward.

Apr 7 2017, 12:39 PM · Bug Report (Needs Information)
epriestley closed T12454: db schema error as Invalid.

We don't know how to reproduce this.

Apr 7 2017, 12:39 PM · Bug Report (Needs Information)
epriestley added a subtask for T1562: Build "Facts", an ETL pipeline and charting application: T12459: Provide evidence-based forecasting of projects.
Apr 7 2017, 12:37 PM · Restricted Project, Wikimedia, Facts
epriestley added a parent task for T12459: Provide evidence-based forecasting of projects: T1562: Build "Facts", an ETL pipeline and charting application.
Apr 7 2017, 12:37 PM · Feature Request
epriestley added a revision to T12517: Some strings are not outputted by pht() method: Unknown Object (Differential Revision).
Apr 7 2017, 12:35 PM · Contributor Onboarding, Localization, Bug Report
epriestley closed T12519: TEST as Invalid.
Apr 7 2017, 12:33 PM · Bug Report
epriestley closed T12516: 4 typos in code as Resolved by committing Restricted Diffusion Commit.
Apr 7 2017, 11:10 AM · Contributor Onboarding, Bug Report
epriestley closed T12510: Requesting changes as Reviewer and member of blocking Group Reviewer, makes Group Reviewer no longer blocking as Resolved.

That's expected, and not a bug. "Blocking" is currently a top-level status. When a reviewer becomes "Rejecting", they are no longer "Blocking". This doesn't matter in terms of the workflow, because both "Rejecting" and "Blocking" prevent a revision from transitioning to "Accepted".

Apr 7 2017, 11:09 AM · Bug Report (Needs Information)

Apr 6 2017

epriestley closed T12470: Store integrity hashes for file blobs in Files as Resolved.

See T12515 for followup guidance.

Apr 6 2017, 11:25 PM · Files
epriestley created T12515: Upgrading: File Integrity Hashing and SHA1.
Apr 6 2017, 11:24 PM · Files, Guides, Security
epriestley added a revision to T4245: Make repository URIs slightly prettier: Unknown Object (Differential Revision).
Apr 6 2017, 10:53 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley added a revision to T12217: Reduce the hardware cost of Phacility free instances: Unknown Object (Differential Revision).
Apr 6 2017, 10:40 PM · Ops, Phacility
epriestley added a revision to T12298: Allow daemon pools to autoscale down to 0 processes: Unknown Object (Differential Revision).
Apr 6 2017, 10:26 PM · Daemons, Ops, Phacility
epriestley merged task T12514: `refs/keep-around/` commits should be ignored into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Apr 6 2017, 10:23 PM · Diffusion, Bug Report
epriestley merged T12514: `refs/keep-around/` commits should be ignored into T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.
Apr 6 2017, 10:23 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley added a comment to T12514: `refs/keep-around/` commits should be ignored.

I'm going to merge this into T11314, but I don't want to hard-code rules around specific names used by GitHub/GitLab. We can provide more tools to manage these refs, but I don't think the right tool is a bunch of hard-coded rules. These refs are real refs which exist in the repository, and Diffusion should be able to represent them. A driving use case for the original change was a desire to expose Gerrit refs.

Apr 6 2017, 10:23 PM · Diffusion, Bug Report
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

I think things should work now, let me know if you're still seeing issues. Thanks for the report!

Apr 6 2017, 10:03 PM · Owners, Audit, Restricted Project, Differential
epriestley added a revision to T12272: Allow users to accept on behalf of packages they control a containing package for: Unknown Object (Differential Revision).
Apr 6 2017, 9:59 PM · Owners, Audit, Restricted Project, Differential
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

Argh! I broke it while doing last-minute fixes to improve rendering, fix in a moment.

Apr 6 2017, 9:56 PM · Owners, Audit, Restricted Project, Differential
arpagon awarded T10339: Figure out the UI for Maniphest task search by points a Like token.
Apr 6 2017, 9:32 PM · Maniphest
epriestley added a comment to T12272: Allow users to accept on behalf of packages they control a containing package for.

Thanks, that definitely looks like a bug.

Apr 6 2017, 8:48 PM · Owners, Audit, Restricted Project, Differential
epriestley added a revision to T12509: Plan the path forward from HMAC-SHA1: Unknown Object (Differential Revision).
Apr 6 2017, 5:10 PM · Infrastructure, Security
epriestley added a revision to T12509: Plan the path forward from HMAC-SHA1: Unknown Object (Differential Revision).
Apr 6 2017, 5:03 PM · Infrastructure, Security
epriestley added a revision to T12509: Plan the path forward from HMAC-SHA1: Unknown Object (Differential Revision).
Apr 6 2017, 4:38 PM · Infrastructure, Security
epriestley added a comment to T12511: Add Support For User Definable Macro Or Template Markup to Phriction Similar To WikiMedia Templates.

I gave a trivial example as that is better than a complicated one.

Apr 6 2017, 2:51 PM · Phriction, Feature Request
epriestley added a revision to T12470: Store integrity hashes for file blobs in Files: Unknown Object (Differential Revision).
Apr 6 2017, 2:01 PM · Files
epriestley added a comment to T12509: Plan the path forward from HMAC-SHA1.

(That said, the hash cost may become very relevant when we eventually ship "Phabricator Valuable Golden Coin Money", our blockchain-based virtual currency.)

Apr 6 2017, 2:01 PM · Infrastructure, Security
epriestley merged T12513: Failed to index task with too long title into T5679: Search daemon fails when document title >255 chars.
Apr 6 2017, 1:48 PM · Maniphest
epriestley merged task T12513: Failed to index task with too long title into T5679: Search daemon fails when document title >255 chars.
Apr 6 2017, 1:48 PM · Bug Report
epriestley added a comment to T3963: Templates in Phriction.

See T12511#218328.

Apr 6 2017, 1:47 PM · Phriction
epriestley added a comment to T12511: Add Support For User Definable Macro Or Template Markup to Phriction Similar To WikiMedia Templates.

There is basically zero chance we're going to implement parameterized templates which can call one another (easily dozens of hours of work) if the only real use case is making RFC5555 autolink (works today with InlineRule, takes a few minutes to make work).

Apr 6 2017, 1:42 PM · Phriction, Feature Request
epriestley added a comment to T12509: Plan the path forward from HMAC-SHA1.

I get these rough per-hash costs locally (Macbook Pro), with a 64-byte key:

Apr 6 2017, 1:05 PM · Infrastructure, Security
epriestley edited projects for T12510: Requesting changes as Reviewer and member of blocking Group Reviewer, makes Group Reviewer no longer blocking, added: Bug Report (Needs Information); removed Bug Report.
Apr 6 2017, 12:15 PM · Bug Report (Needs Information)
epriestley added a comment to T12510: Requesting changes as Reviewer and member of blocking Group Reviewer, makes Group Reviewer no longer blocking.

I'm having trouble reproducing this, but maybe I'm not fully understanding what you're running into?

Apr 6 2017, 12:14 PM · Bug Report (Needs Information)
epriestley added a comment to T6994: Write a general "Security guidelines" document.

Some guidance about "configure captchas if you're a public-facing, password-login install" would be good here too, but maybe we should just raise it as a setup issue if you have password auth enabled, and let users ignore it if they're VPN'd.

Apr 6 2017, 11:49 AM · Security
epriestley added a comment to T3963: Templates in Phriction.

T12511 discusses some possible use cases, but they are all in the form of {{name|123}} expanding to [[ something.com/123 | 123 ]] (external bug trackers, RFCs, etc).

Apr 6 2017, 11:43 AM · Phriction
epriestley merged T12511: Add Support For User Definable Macro Or Template Markup to Phriction Similar To WikiMedia Templates into T3963: Templates in Phriction.
Apr 6 2017, 11:41 AM · Phriction
epriestley merged task T12511: Add Support For User Definable Macro Or Template Markup to Phriction Similar To WikiMedia Templates into T3963: Templates in Phriction.
Apr 6 2017, 11:41 AM · Phriction, Feature Request
epriestley closed T12512: Bug in Upload URL's (Require user authentication over URL's ) as Resolved.

In the future, please report security issues via HackerOne: https://hackerone.com/phabricator -- notably, this allows us to award you a security bounty if you discover an issue.

Apr 6 2017, 11:39 AM · Security, Bug Report

Apr 5 2017

epriestley added a comment to P2034 aa.

yeah, sorry, in retrospect this is a real underwhelming test

Apr 5 2017, 8:42 PM
epriestley moved T8788: Allow querying for files by name from v3 to vNext on the Files board.
Apr 5 2017, 8:28 PM · Contributor Onboarding, Files
epriestley moved T10828: File deletion should be queued up and run by daemons from v3 to vNext on the Files board.
Apr 5 2017, 8:28 PM · Contributor Onboarding, Daemons, Files, Bug Report
epriestley added a comment to T12509: Plan the path forward from HMAC-SHA1.

I'm maybe going to try to do this in the short term:

Apr 5 2017, 8:26 PM · Infrastructure, Security
epriestley added a comment to T12508: Can't create pastes in this install.

I deployed that and created this masterpiece:

Apr 5 2017, 8:22 PM · Bug Report
epriestley created P2034 aa.
Apr 5 2017, 8:21 PM
epriestley created T12509: Plan the path forward from HMAC-SHA1.
Apr 5 2017, 8:21 PM · Infrastructure, Security
epriestley closed T12508: Can't create pastes in this install as Resolved by committing Restricted Diffusion Commit.
Apr 5 2017, 8:09 PM · Bug Report
epriestley added a revision to T12508: Can't create pastes in this install: Unknown Object (Differential Revision).
Apr 5 2017, 7:57 PM · Bug Report
epriestley claimed T12508: Can't create pastes in this install.

Almost certainly fallout from the increased strictness in D17616, thanks.

Apr 5 2017, 7:55 PM · Bug Report
epriestley closed T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles) as Resolved.

I'm going to call this resolved; T9979 is the survivor for Files and the Maniphest case is probably more involved (T6721).

Apr 5 2017, 7:54 PM · Owners, Files, ApplicationSearch
epriestley closed T9979: Build support for ngram indexes for substring searches (e.g., file, paste, package, task titles), a subtask of T6721: Would like ability to search tasks by title, as Resolved.
Apr 5 2017, 7:54 PM · Search, Maniphest
epriestley added a project to T8788: Allow querying for files by name: Contributor Onboarding.
Apr 5 2017, 7:52 PM · Contributor Onboarding, Files
epriestley added a project to T10828: File deletion should be queued up and run by daemons: Contributor Onboarding.
Apr 5 2017, 7:52 PM · Contributor Onboarding, Daemons, Files, Bug Report
epriestley added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

Just dropping this here since it's the first hit for "SAML" and makes it easier for me to contextualize things when I quote $50K for it, which I'm starting to think is too low:

Apr 5 2017, 7:44 PM · Haskell.org, Auth
epriestley added a comment to T12470: Store integrity hashes for file blobs in Files.

The HackerOne issue for this is here:

Apr 5 2017, 7:29 PM · Files
epriestley added a comment to T12470: Store integrity hashes for file blobs in Files.

The security part of this is fixed by D17625, but I'm planning to write a support script like bin/files integrity or similar to do things like "compute hashes for existing files" and "check that a file or set of files match their integrity hashes".

Apr 5 2017, 7:28 PM · Files
epriestley closed T12219: Some MP4 videos do not play in Chrome as Resolved.

This appears to be resolved for me, now. Handling Range: bytes=123- and Range: bytes=0- (plus the fixes for the broader issues in T8266 and T12079) seemed to be the key issues.

Apr 5 2017, 6:59 PM · Files
epriestley added a revision to T12219: Some MP4 videos do not play in Chrome: Unknown Object (Differential Revision).
Apr 5 2017, 6:34 PM · Files
epriestley added a revision to T12219: Some MP4 videos do not play in Chrome: Unknown Object (Differential Revision).
Apr 5 2017, 6:05 PM · Files
epriestley closed T8266: Some audio isn't streaming correctly in Safari as Resolved.

F60036 now plays correctly for me in Safari.

Apr 5 2017, 5:13 PM · Safari, Files
epriestley added a comment to T12079: Files does not serve HTTP "Content-Range" requests correctly if the underlying blob data is encrypted.

The video in T12078 now plays correctly for me so I think this is, in fact, resolved.

Apr 5 2017, 5:12 PM · Files, Public & Media Relations, Bug Report
epriestley closed T12079: Files does not serve HTTP "Content-Range" requests correctly if the underlying blob data is encrypted as Resolved by committing Restricted Diffusion Commit.
Apr 5 2017, 4:56 PM · Files, Public & Media Relations, Bug Report
epriestley added a revision to T12470: Store integrity hashes for file blobs in Files: Unknown Object (Differential Revision).
Apr 5 2017, 4:56 PM · Files
epriestley added a revision to T8266: Some audio isn't streaming correctly in Safari: Unknown Object (Differential Revision).
Apr 5 2017, 1:53 PM · Safari, Files
epriestley added a revision to T12079: Files does not serve HTTP "Content-Range" requests correctly if the underlying blob data is encrypted: Unknown Object (Differential Revision).
Apr 5 2017, 1:35 PM · Files, Public & Media Relations, Bug Report
epriestley added a comment to T12506: hackerone: possible issue with secrets sharing.

T4721 (which I also linked on the HackerOne report) discusses usability improvements to Passphrase, including better documentation and hinting about this use case and possibly the separation of the "Can Use Credential" and "Can View Secret" policies. These are reasonable usability concerns.

Apr 5 2017, 1:16 PM · Security
epriestley closed T12506: hackerone: possible issue with secrets sharing as Invalid.

You can review the HackerOne report, including my response, here:

Apr 5 2017, 12:51 PM · Security
epriestley edited the content of 2017 Week 13 (Very Early April).
Apr 5 2017, 1:38 AM

Apr 4 2017

epriestley closed T12464: Move away from SHA1 in Files as Resolved by committing Restricted Diffusion Commit.
Apr 4 2017, 11:56 PM · Files
epriestley closed T8348: `arc download` doesn't support chunked downloads as Resolved by committing Restricted Diffusion Commit.
Apr 4 2017, 11:16 PM · Restricted Project, Files, Arcanist
epriestley closed T8348: `arc download` doesn't support chunked downloads, a subtask of T11357: Move Files to EditEngine and modern APIs, as Resolved.
Apr 4 2017, 11:16 PM · Restricted Project, Files
epriestley added a comment to T8348: `arc download` doesn't support chunked downloads.

After D17614, arc download uses file.search to retrieve a URI it can GET, then does a normal HTTP GET to that URI, retrieving the file content in the HTTP response body.

Apr 4 2017, 11:14 PM · Restricted Project, Files, Arcanist
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:54 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:49 PM · Files
epriestley added a revision to T12464: Move away from SHA1 in Files: Unknown Object (Differential Revision).
Apr 4 2017, 10:38 PM · Files