Page MenuHomePhabricator
Feed Advanced Search

Aug 23 2016

rayzyar edited projects for T11517: arc lint missed some error reported from the golint, added: Bug Report; removed Bug Report (Needs Information).
Aug 23 2016, 5:41 PM · Bug Report (Needs Information), Arcanist, Lint
chad added a comment to T11517: arc lint missed some error reported from the golint.

Please follow the instructions in Contributing Bug Reports. This is not a valid report without version information and step by step reproduction information.

Aug 23 2016, 1:57 PM · Bug Report (Needs Information), Arcanist, Lint
epriestley closed T11516: Test open as Invalid.
Aug 23 2016, 11:56 AM · Bug Report
• liub815 added a comment to T10405: Phabricator should generally work properly even if "gd" is not installed.

who can help me?

Aug 23 2016, 9:22 AM · Setup, Restricted Project
rayzyar added projects to T11517: arc lint missed some error reported from the golint: Lint, Arcanist.
Aug 23 2016, 9:08 AM · Bug Report (Needs Information), Arcanist, Lint
rayzyar created T11517: arc lint missed some error reported from the golint.
Aug 23 2016, 9:06 AM · Bug Report (Needs Information), Arcanist, Lint
• j66166 created T11516: Test open.
Aug 23 2016, 8:26 AM · Bug Report

Aug 22 2016

epriestley moved T10951: Search shows document types corresponding to disabled apps from Backlog to Basic on the Contributor Onboarding board.
Aug 22 2016, 7:50 PM · Contributor Onboarding, Search, Bug Report
epriestley added a comment to T10951: Search shows document types corresponding to disabled apps.

Perhaps in a separate change, it would be nice to maybe show the application name under the more modern document types -- for example, show "Diffusion" here:

Aug 22 2016, 7:49 PM · Contributor Onboarding, Search, Bug Report
epriestley assigned T10951: Search shows document types corresponding to disabled apps to jcox.

To reach this dialog, mash some text into the search field in the global menu bar, then hit enter.

Aug 22 2016, 7:41 PM · Contributor Onboarding, Search, Bug Report
epriestley closed T10018: Application transactions don't get avatars in the Recent Activity Feed as Resolved.

This was resolved in conjunction with T8952.

Aug 22 2016, 6:19 PM · Bug Report, Feed
epriestley closed T10682: Applications have no profile photos when they author transactions as Resolved.

I believe this was resolved as part of T8952:

Aug 22 2016, 5:55 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a project to T10881: git diff parsing fails with --submodule=log: Contributor Onboarding.
Aug 22 2016, 5:46 PM · Contributor Onboarding, Arcanist, Bug Report
epriestley added a project to T10951: Search shows document types corresponding to disabled apps: Contributor Onboarding.
Aug 22 2016, 5:44 PM · Contributor Onboarding, Search, Bug Report
jessjohnson added a comment to T11188: Updating to latest Phabricator caused feed corruption.

To build on what was originally suggested, you can have all your repos stop publishing events by running the following which will list all repos and put them back to importing mode so they don't publish events:

Aug 22 2016, 4:45 PM · Bug Report
epriestley added projects to T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:": Differential, Diffusion.
Aug 22 2016, 8:48 AM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley renamed T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:" from arc complains when tests is in the title to Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:".
Aug 22 2016, 8:48 AM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley reopened T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:" as "Open".

I agree with that (and actually believed we already did that, see T11485 for me claiming that this is the current behavior). We'll change this.

Aug 22 2016, 8:47 AM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
kparal added a comment to T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:".

@chad, what is the rationale behind processing the very first line of the git commit message (the title)? I can't find any reason to do so, the first line is always the title. If you just ignored the first line and not performed any extra arc processing, this issue would go away. What am I missing?

Aug 22 2016, 8:41 AM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley closed T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project. as Invalid.

We haven't seen other reports of similar issues and can't reproduce this issue ourselves in a variety of production and development environments.

Aug 22 2016, 7:56 AM · Bug Report
epriestley closed T11498: "Change Subscribers" field does not include subscribers that will be added to a task when a Maniphest comment is submitted as Resolved.

I'm going to close this since it's working as intended and was just based on a miscommunication -- the actions UI (above the comment text area) is not expected to show a preview of the effects of a change. Instead, the preview UI (below the comment text area) shows this preview information.

Aug 22 2016, 7:54 AM · Bug Report
avivey added a comment to T11507: Many Modal workflows don't work ( JS Crash ).

Have you fully read Contributing Bug Reports? This ticket is missing most of what is required for a handling, primarily reproduction steps, as highlighted there.

Aug 22 2016, 1:52 AM · Bug Report (Needs Information)
• ramprabhuj created T11507: Many Modal workflows don't work ( JS Crash ).
Aug 22 2016, 1:20 AM · Bug Report (Needs Information)

Aug 21 2016

lukasz.tarasiewicz86 added a comment to T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project..

I've now tried on MySQL 5.6.27 instead of MariaDB. The same thing - cannot create a project. This time the process results in 504 Gateway Time-out. I guess if I'm the only person reporting this issue, the problem might lie with my setup. What's puzzling my is that it's only with the projects. 60sec should be enough for the FPM to process this request, I guess. Thanks for looking into it.

Aug 21 2016, 8:49 PM · Bug Report

Aug 20 2016

• CocoaWiki added a comment to T11504: Config View Error.

Oh, Complete!

Aug 20 2016, 10:58 PM · Bug Report
epriestley merged T11503: Notifications for past events sent after Phabricator upgrade into T11188: Updating to latest Phabricator caused feed corruption.
Aug 20 2016, 10:55 PM · Bug Report
• CocoaWiki added a comment to T11504: Config View Error.

root@ip:/var/www/issues# cd phabricator/
root@ip:/var/www/issues/phabricator# git pull origin master
From https://github.com/phacility/phabricator

  • branch master -> FETCH_HEAD

Already up-to-date.
root@ip:/var/www/issues/phabricator# cd ../libphutil/
root@ip:/var/www/issues/libphutil# git pull origin master
From https://github.com/phacility/libphutil

  • branch master -> FETCH_HEAD

Already up-to-date.
root@ip:/var/www/issues/libphutil# cd ../arcanist/
root@ip:/var/www/issues/arcanist# git pull origin master
From https://github.com/phacility/arcanist

  • branch master -> FETCH_HEAD

Already up-to-date.

Aug 20 2016, 10:54 PM · Bug Report
chad added a comment to T11504: Config View Error.

You shouldn't need to edit code, just update Phabricator. https://secure.phabricator.com/book/phabricator/article/upgrading/

Aug 20 2016, 10:54 PM · Bug Report
epriestley added a comment to T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project..

I can't reproduce this. Here's what I did:

Aug 20 2016, 10:52 PM · Bug Report
• CocoaWiki added a comment to T11504: Config View Error.

I using git master. and i did edit code to https://secure.phabricator.com/diffusion/P/browse/master/src/applications/config/controller/PhabricatorConfigListController.php;f379858874a3336dc36cc8b7e77b0d0b698b2fff$54 and error not complete.

Aug 20 2016, 10:51 PM · Bug Report
lukasz.tarasiewicz86 updated the task description for T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project..
Aug 20 2016, 10:47 PM · Bug Report
lukasz.tarasiewicz86 updated the task description for T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project..
Aug 20 2016, 10:46 PM · Bug Report
lukasz.tarasiewicz86 renamed T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project. from 1205: Lock wait timeout exceeded; try restarting transaction when creating a new project. to "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project..
Aug 20 2016, 10:44 PM · Bug Report
avivey updated the task description for T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project..
Aug 20 2016, 10:42 PM · Bug Report
lukasz.tarasiewicz86 renamed T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project. from 1205: Lock wait timeout exceeded; try restarting transaction whnn creating a new project. to 1205: Lock wait timeout exceeded; try restarting transaction when creating a new project..
Aug 20 2016, 10:36 PM · Bug Report
lukasz.tarasiewicz86 created T11505: "1205: Lock wait timeout exceeded; try restarting transaction" when creating a new project..
Aug 20 2016, 10:31 PM · Bug Report
chad closed T11504: Config View Error as Resolved.

Going to assume you are not up to date.

Aug 20 2016, 1:54 PM · Bug Report
chad added a comment to T11504: Config View Error.

What version of Phabricator are you using? This should have already been resolved at HEAD of master.

Aug 20 2016, 1:52 PM · Bug Report
• CocoaWiki created T11504: Config View Error.
Aug 20 2016, 9:38 AM · Bug Report
chad added a comment to T11503: Notifications for past events sent after Phabricator upgrade.

Well, I'm guessing overall, roughy my theory is:

Aug 20 2016, 1:40 AM · Diffusion, Bug Report (Needs Information)
chad added a comment to T11503: Notifications for past events sent after Phabricator upgrade.

This is expected, as they are most likely not previously discovered commits.

Aug 20 2016, 1:29 AM · Diffusion, Bug Report (Needs Information)
jessjohnson updated the task description for T11503: Notifications for past events sent after Phabricator upgrade.
Aug 20 2016, 1:15 AM · Diffusion, Bug Report (Needs Information)
jessjohnson created T11503: Notifications for past events sent after Phabricator upgrade.
Aug 20 2016, 1:14 AM · Diffusion, Bug Report (Needs Information)

Aug 19 2016

avivey added a revision to T10635: Loading differential revision slow when lots of unit test messages exist: Restricted Differential Revision.
Aug 19 2016, 7:16 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley added a comment to T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan.

This should be resolved at HEAD of master. Thanks for the report and the detailed analysis of the issue.

Aug 19 2016, 6:22 PM · PHUI, Harbormaster, Bug Report
epriestley closed T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan as Resolved by committing Restricted Diffusion Commit.
Aug 19 2016, 6:09 PM · PHUI, Harbormaster, Bug Report
epriestley added a revision to T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan: Restricted Differential Revision.
Aug 19 2016, 5:45 PM · PHUI, Harbormaster, Bug Report
epriestley added a comment to T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan.

D15133 (making array utility functions accept any array-like object) is a possible attack on this in the general case, but I'm just going to fix this narrowly for now since it hasn't been a frequent/common/recurring problem so far. A more general approach may be warranted in the longer run.

Aug 19 2016, 5:36 PM · PHUI, Harbormaster, Bug Report
epriestley claimed T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan.
Aug 19 2016, 5:34 PM · PHUI, Harbormaster, Bug Report
chad merged task T11500: unable to submit a diff with "tests:" in git commit title into T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:".
Aug 19 2016, 4:53 PM · Arcanist, Bug Report
chad merged T11500: unable to submit a diff with "tests:" in git commit title into T10312: Always interpret the first line of commit messages as a title, even if it begins with a recognized label like "Test Plan:".
Aug 19 2016, 4:53 PM · Restricted Project, Diffusion, Differential, Arcanist, Bug Report
epriestley added a comment to T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.

The fatals should be fixed in HEAD of master. I'm going to retarget this task to clean up the actual method calls, but this should have no user-facing impact.

Aug 19 2016, 3:32 PM · Infrastructure
epriestley added a comment to T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.

D16420 restores setIcon() as an alias of setStatusIcon() as a quick fix for the immediate issue, since I found at least two other affected interfaces (Drydock, Almanac) and am not confident there aren't more.

Aug 19 2016, 11:56 AM · Infrastructure
epriestley added a revision to T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView: Restricted Differential Revision.
Aug 19 2016, 11:55 AM · Infrastructure
epriestley updated subscribers of T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.

This was likely broken by D16418. I think setStatusIcon() provides equivalent functionality, let me take a look.

Aug 19 2016, 11:50 AM · Infrastructure
epriestley closed T11499: Unauthorized access to files - security issue as Invalid.

Yes, this is intended behavior. See T10262 for discussion. See T10262#158198 for comparison to other systems, many of which use the same approach to access control for the same reasons.

Aug 19 2016, 11:47 AM · Diffusion, Bug Report
alrouen added a comment to T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.

Same issue here

Aug 19 2016, 10:33 AM · Infrastructure
asherkin added a comment to T11499: Unauthorized access to files - security issue.

This is intentional (and not a security issue), the URI contains a security token valid for 30 days (or until the policy is changed).

Aug 19 2016, 10:01 AM · Diffusion, Bug Report
Rado created T11501: Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.
Aug 19 2016, 9:05 AM · Infrastructure
kparal created T11500: unable to submit a diff with "tests:" in git commit title.
Aug 19 2016, 9:01 AM · Arcanist, Bug Report
exp10r3r created T11499: Unauthorized access to files - security issue.
Aug 19 2016, 6:41 AM · Diffusion, Bug Report
epriestley updated subscribers of T11498: "Change Subscribers" field does not include subscribers that will be added to a task when a Maniphest comment is submitted.

Sorry, I was responding primarily to @chad there -- the preview is at the bottom. I've circled what I was talking about here:

Aug 19 2016, 4:11 AM · Bug Report
MZMcBride created T11498: "Change Subscribers" field does not include subscribers that will be added to a task when a Maniphest comment is submitted.
Aug 19 2016, 4:04 AM · Bug Report

Aug 18 2016

epriestley added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

(I believe we already show any changes that pressing the submit button will make to subscribers accurately in the preview. This wasn't always true prior to EditEngine and I think the preview/actual effect would sometimes disagree in weird cases, but I believe the preview is now always fully accurate. However, it's quite easy to miss.)

Aug 18 2016, 9:51 PM · Remarkup, Bug Report
chad added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

When a user writes a Maniphest comment, I think fully and correctly populating the "Change Subscribers" field, including its new/upcoming additions, would be a good and unobjectionable feature. This would allow the currently unconditional additions to be removed manually prior to form submission. This would still be tedious, but at least I could make a comment without having to either mangle the quote or go back after commenting to perform a separate manual action unsubscribing the user that I didn't intend to add.

Aug 18 2016, 3:18 PM · Remarkup, Bug Report
chad merged task T11496: No clear instructions for translation into T5267: Localize Phabricator.
Aug 18 2016, 3:06 PM · Bug Report
chad closed T11496: No clear instructions for translation as Invalid.

Arcanist is the command line tool for Phabricator. You should have installed it when you installed Phabricator.

Aug 18 2016, 3:05 PM · Bug Report
rabahmeradi added a comment to T11496: No clear instructions for translation.

You should install arc. arc is the script in arcanist/bin/arc

Aug 18 2016, 2:53 PM · Bug Report
mpiontek added a comment to T11496: No clear instructions for translation.

I am so sorry, if my comments look a little bit "dumb".

Aug 18 2016, 2:38 PM · Bug Report
MZMcBride added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

If you don't like the @mention-implies-CC behavior, you can disable it by applying this patch to your install:

[...]

Aug 18 2016, 2:20 PM · Remarkup, Bug Report
chad added a comment to T11496: No clear instructions for translation.

You'll need to run arc liberate to pick up the new file so Phabricator can find it or put it in src/extensions. Then if you're an admin, go into Settings -> Global Default Settings, and change the install language there.

Aug 18 2016, 2:17 PM · Bug Report
mpiontek added a comment to T11496: No clear instructions for translation.

No i realized, that the File with the translation has to go to the "/root/libphutil/src/extensions" Folder, some Values are translated in the ui, but others aren't. Is there a file, where i can find all strings, to translate it? Or is there another way to find out how to translate a specific string?

Aug 18 2016, 2:13 PM · Bug Report
rabahmeradi updated subscribers of T11496: No clear instructions for translation.

My bad I didn't see the second comment by @chad. I know it is possible as @epriestley changed the language of this instance (see D16310#190724).

Aug 18 2016, 2:09 PM · Bug Report
mpiontek added a comment to T11496: No clear instructions for translation.

Let me add some note: A changing of the "Translation" - Dropdown in the individual account settings never makes a change. So it is not important if i choose german or something else. That is not influencing my request, but is that a normal behaviour? Or did i maybe make a mistake when i set up the system?

Aug 18 2016, 1:56 PM · Bug Report
mpiontek added a comment to T11496: No clear instructions for translation.

This is the full code of the file in my case.

Aug 18 2016, 1:13 PM · Bug Report
mpiontek added a comment to T11496: No clear instructions for translation.

Do you mean the patch, added by devurandom ? The first part of the patch ($default...) is not existing in my PhabricatorAccountSettingsPanel.php

Aug 18 2016, 1:04 PM · Bug Report
rabahmeradi added a comment to T11496: No clear instructions for translation.

Does T8916 help?

Aug 18 2016, 12:26 PM · Bug Report
mpiontek created T11496: No clear instructions for translation.
Aug 18 2016, 12:09 PM · Bug Report
nemobis added a comment to T11471: Quoting Phabricator Maniphest comments auto-subscribes users who have removed themselves from tasks.

If you don't like the @mention-implies-CC behavior

Aug 18 2016, 12:07 PM · Remarkup, Bug Report
epriestley closed T11494: test as Spite.
Aug 18 2016, 11:51 AM · Bug Report
tycho.tatitscheff added a comment to T11494: test.

This is not a demo bug tracker. Please Close this task and go to https://admin.phacility.com/auth/register/ to create a demo account for free.

Aug 18 2016, 10:52 AM · Bug Report
• dfgthtfdefrgtfdef updated the task description for T11494: test.
Aug 18 2016, 8:01 AM · Bug Report
rabahmeradi added a project to T11495: Drydock doesn't delete working copies: Drydock.
Aug 18 2016, 8:00 AM · Bug Report (Needs Information), Drydock
• dfgthtfdefrgtfdef updated the task description for T11494: test.
Aug 18 2016, 8:00 AM · Bug Report
rabahmeradi created T11495: Drydock doesn't delete working copies.
Aug 18 2016, 7:59 AM · Bug Report (Needs Information), Drydock
• dfgthtfdefrgtfdef updated the task description for T11494: test.
Aug 18 2016, 7:59 AM · Bug Report
• dfgthtfdefrgtfdef created T11494: test.
Aug 18 2016, 7:58 AM · Bug Report
jasonrumney created T11493: Unable to view Harbormaster Build Plans after tagging many projects on a build plan.
Aug 18 2016, 3:40 AM · PHUI, Harbormaster, Bug Report
epriestley closed T11492: Test as Spite.
Aug 18 2016, 1:40 AM · Bug Report
• erichaydel created T11492: Test.
Aug 18 2016, 1:32 AM · Bug Report
chad closed T11491: Preview of remarkup with a checkbox doesn't render properly as Resolved by committing Restricted Diffusion Commit.
Aug 18 2016, 1:23 AM · Remarkup, Bug Report
avivey added a comment to T11145: Dialog submit buttons don't disable on click.

https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/js/core/behavior-form.js:57
looks like it's supposed to be listening to submit, but there's no submit event being fired while in a dialog; It does fire when the same dialog is loaded as a full-page, so some magic is happening there.

Aug 18 2016, 12:24 AM · Restricted Project, PHUI, Bug Report

Aug 17 2016

chad added a revision to T11491: Preview of remarkup with a checkbox doesn't render properly: Restricted Differential Revision.
Aug 17 2016, 9:58 PM · Remarkup, Bug Report
chad added a comment to T11491: Preview of remarkup with a checkbox doesn't render properly.

.aphront-form-input input is to blame.

Aug 17 2016, 9:47 PM · Remarkup, Bug Report
cspeckmim created T11491: Preview of remarkup with a checkbox doesn't render properly.
Aug 17 2016, 9:34 PM · Remarkup, Bug Report
avivey added a comment to T10746: Aborted build in Harbormaster still shows as building in Diffusion.

I'm also seeing this for failed builds:

pasted_file (91×438 px, 12 KB)

Aug 17 2016, 7:45 PM · Restricted Project, Harbormaster, Bug Report
epriestley closed T11489: Arcanist: Duplicate at question as Resolved.

Resolved by D16415.

Aug 17 2016, 5:36 PM · Arcanist, Bug Report
Luke081515.2 updated the task description for T11489: Arcanist: Duplicate at question.
Aug 17 2016, 5:01 PM · Arcanist, Bug Report
Luke081515.2 added a revision to T11489: Arcanist: Duplicate at question: Restricted Differential Revision.
Aug 17 2016, 4:55 PM · Arcanist, Bug Report
Luke081515.2 added a comment to T11489: Arcanist: Duplicate at question.

I'm going to upload a patch in a few minutes (I can't claim the task :-/).

Aug 17 2016, 4:36 PM · Arcanist, Bug Report