Page MenuHomePhabricator
Create Task
Maniphest T11501

Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView
Closed, ResolvedPublic
Actions

Description

Can't access to pages with url /config/ and /settings/:

>>> UNRECOVERABLE FATAL ERROR <<<

Call to undefined method PHUIObjectItemView::setIcon()

/var/www/hismith/data/www/forge.hismith.ru/phabricator/src/applications/config/controller/PhabricatorConfigListController.php:54

┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

phabricator - cant view, but now i have fresh update
arcanist 3ae0cc8d41e26218ac5d0871ce6b73d0377288db (17 Aug 2016)
libphutil 9c03af69571fc72d0ecbb13b8f5e243e2ba41a51 (11 Aug 2016)

Revisions and Commits

rP Phabricator
D16421rPe7aa874f5eba Fix getIcon calls in PHUIObjectListItem
D16420rP1ecce605890c Keep setIcon() working for now on PHUIObjectItemView

Related Objects

Event Timeline

Rado created this task.Aug 19 2016, 9:05 AM
alrouen added a subscriber: alrouen.Aug 19 2016, 10:33 AM

Same issue here

epriestley added subscribers: chad, epriestley.Aug 19 2016, 11:50 AM

This was likely broken by D16418. I think setStatusIcon() provides equivalent functionality, let me take a look.

(+@chad)

epriestley added a revision: D16420: Keep setIcon() working for now on PHUIObjectItemView.Aug 19 2016, 11:55 AM
epriestley added a comment.Aug 19 2016, 11:56 AM

D16420 restores setIcon() as an alias of setStatusIcon() as a quick fix for the immediate issue, since I found at least two other affected interfaces (Drydock, Almanac) and am not confident there aren't more.

That should stabilize things, and let us swap callsites over at a more leisurely pace.

epriestley added a commit: rP1ecce605890c: Keep setIcon() working for now on PHUIObjectItemView.Aug 19 2016, 2:26 PM
epriestley added a comment.Aug 19 2016, 3:32 PM

The fatals should be fixed in HEAD of master. I'm going to retarget this task to clean up the actual method calls, but this should have no user-facing impact.

epriestley renamed this task from Can't access to user settings and phabricator config to Clean up setIcon() vs setStatusIcon() calls in PHUIObjectItemView.Aug 19 2016, 3:33 PM
epriestley assigned this task to chad.
epriestley triaged this task as Low priority.
epriestley edited projects, added Infrastructure; removed Bug Report.
Herald added a subscriber: eadler. · View Herald TranscriptAug 19 2016, 3:33 PM
chad added a revision: D16421: Fix getIcon calls in PHUIObjectListItem.Aug 19 2016, 4:31 PM
chad closed this task as Resolved by committing rPe7aa874f5eba: Fix getIcon calls in PHUIObjectListItem.Aug 19 2016, 4:34 PM
chad added a commit: rPe7aa874f5eba: Fix getIcon calls in PHUIObjectListItem.
Phabricator · Built by Phacility