Page MenuHomePhabricator
Feed Advanced Search

May 11 2016

epriestley added a revision to T10952: Cannot edit pastes, if you want to keep the content: Restricted Differential Revision.
May 11 2016, 10:34 PM · Paste, Bug Report
florianb awarded T5132: Document the special syntax you can use in commit messages to cause effects a Love token.
May 11 2016, 5:40 PM · Guides, Diffusion
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 11 2016, 5:27 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 5:21 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 4:48 PM · Diffusion (v3)
epriestley added a comment to T10939: Support for OWNERS files.

I think some setting like:

May 11 2016, 4:28 PM · Prioritized, Restricted Project, Owners
epriestley added a revision to T10923: Diffusion API/URI Errata: Restricted Differential Revision.
May 11 2016, 3:19 PM · Diffusion (v3)
epriestley added a comment to T3980: Support "Bind to External Thing" to define project membership.

This was moved into the prioritization queue by a particular customer that was interested in defining Owners via Projects via external sync.

May 11 2016, 2:56 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 2:27 PM · Diffusion (v3)
yelirekim awarded T10751: Make Phabricator Highly Available a Mountain of Wealth token.
May 11 2016, 2:23 PM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10948: Hide non-functional clone URLs as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 2:18 PM · Feature Request, Diffusion
epriestley closed T10949: Unable to apply patch 'phabricator:20160112.repo.02.uri.index.php': Table 'phabricator_repository.repository_uri' doesn't exist as Resolved.

Cool -- thanks for the report, and sorry about the issue! Some of the Diffusion/repository stuff has been a little choppy lately as we've rolled out changes in connection with T10922 / T10923. Let us know if you run into anything else.

May 11 2016, 2:11 PM · Bug Report
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 2:03 PM · Diffusion (v3)
epriestley added a revision to T10948: Hide non-functional clone URLs: Unknown Object (Differential Revision).
May 11 2016, 2:03 PM · Feature Request, Diffusion
epriestley added a comment to T10948: Hide non-functional clone URLs.

If your install is not available over http, set security.require-https in Config. This will disable the http URI.

May 11 2016, 1:55 PM · Feature Request, Diffusion
epriestley removed a project from T3980: Support "Bind to External Thing" to define project membership: Prioritized.

I think this was building up toward T10939, and the actual solutions we're looking at there probably don't involve this.

May 11 2016, 1:51 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
epriestley removed a project from T10621: Create projects from external thing (extension to T3980): Prioritized.

I think this was building up toward T10939, and the actual solutions we're looking at there probably don't involve this.

May 11 2016, 1:51 PM · Restricted Project, Restricted Project, LDAP, Projects, Feature Request
epriestley closed T10941: Subversion fails to execute pre-commit hook if CWD isn't readable as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 1:48 PM · Diffusion, Subversion, Bug Report
epriestley closed T10815: Confusing diffusion error with empty, non-activated hosted repository as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 1:39 PM · Diffusion, Bug Report
epriestley added a comment to T10949: Unable to apply patch 'phabricator:20160112.repo.02.uri.index.php': Table 'phabricator_repository.repository_uri' doesn't exist.

This should now be fixed in HEAD of master -- try updating again? You'll need to git pull in phabricator/ to pick up the change.

May 11 2016, 1:37 PM · Bug Report
epriestley closed T9554: Trigger "import" heuristics for imported repositories as Resolved by committing Restricted Diffusion Commit.
May 11 2016, 1:36 PM · Diffusion, Restricted Project, Restricted Project
epriestley added a comment to T10949: Unable to apply patch 'phabricator:20160112.repo.02.uri.index.php': Table 'phabricator_repository.repository_uri' doesn't exist.

This should be fixed shortly by D15876.

May 11 2016, 1:35 PM · Bug Report
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

The problem is that a user will not read the entire email from top to bottom. There is far too much information to do that on every email that gets sent, and most of it is essentially boiler plate.

May 11 2016, 1:20 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10939: Support for OWNERS files.

I mean that it's minor to implement -- the current plan on T9372 is "don't make any major structural changes, just adjust the existing bucketing algorithm".

May 11 2016, 12:57 PM · Prioritized, Restricted Project, Owners
epriestley changed the visibility for D3025: Add/update some documentation on branches and reviewable code.
May 11 2016, 12:26 PM
• oswaldo awarded T4548: Support "Mylyn" Eclipse plugin a Like token.
May 11 2016, 7:03 AM · Feature Request, Maniphest
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 11 2016, 2:07 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 11 2016, 1:39 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a revision to T10694: Improve behavior of context for inline comments in mail: Unknown Object (Differential Revision).
May 11 2016, 1:12 AM · Prioritized, Restricted Project, Differential, Mail
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 11 2016, 12:18 AM · Diffusion (v3)
epriestley created T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist.
May 11 2016, 12:17 AM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 11 2016, 12:14 AM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 12:14 AM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 11 2016, 12:01 AM · Diffusion (v3)

May 10 2016

epriestley added a comment to T10926: Make it more likely to see assignee & reporter in task view without having to scroll down.

I think it's a custom select field with an explicit nonempty "None" value, so display is expected.

May 10 2016, 11:32 PM · Transactions, Feature Request, Maniphest
rftfaria awarded T5954: Modularize "Export to Excel" as a feature of ApplicationSearch a Like token.
May 10 2016, 8:35 PM · Custom Fields, ApplicationSearch
epriestley closed T10090: Updating Herald rule throws Unhandled Exception as Resolved.

This may have been fixed by D15507. Otherwise, we can't reproduce it, so we can't move forward. See Providing Reproduction Steps.

May 10 2016, 4:20 PM · Herald, Bug Report
epriestley renamed T10941: Subversion fails to execute pre-commit hook if CWD isn't readable from Subversion commits fail with "Commit blocked by pre-commit hook (exit code 255) with no output" to Subversion fails to execute pre-commit hook if CWD isn't readable.
May 10 2016, 2:33 PM · Diffusion, Subversion, Bug Report
epriestley added a revision to T10941: Subversion fails to execute pre-commit hook if CWD isn't readable: Unknown Object (Differential Revision).
May 10 2016, 2:32 PM · Diffusion, Subversion, Bug Report
epriestley awarded T10941: Subversion fails to execute pre-commit hook if CWD isn't readable a Mountain of Wealth token.
May 10 2016, 2:30 PM · Diffusion, Subversion, Bug Report
epriestley edited this Badge.
May 10 2016, 2:30 PM
epriestley added a comment to T10941: Subversion fails to execute pre-commit hook if CWD isn't readable.

Awesome! Thanks for doing all the work to figure out what was going on. I'll get a diff out to apply that fix in a slightly nicer way.

May 10 2016, 2:30 PM · Diffusion, Subversion, Bug Report
epriestley closed T3607: Diffusion should raise a reasonable error when the default branch does not exist as Resolved.

This behavior seems reasonable at HEAD and we haven't seen other issues with it.

May 10 2016, 2:26 PM · Diffusion
epriestley closed T7796: Import from SVN is running forever as Invalid.

This report doesn't include reproduction steps so we can't move forward. See Contributing Bug Reports and Providing Reproduction Steps.

May 10 2016, 2:19 PM · Diffusion
epriestley closed T10460: Commit Still Parsing as Resolved.

It sounds like this is resolved.

May 10 2016, 2:16 PM · Diffusion, Bug Report (Needs Information)
epriestley added a revision to T10815: Confusing diffusion error with empty, non-activated hosted repository: Unknown Object (Differential Revision).
May 10 2016, 2:15 PM · Diffusion, Bug Report
epriestley moved T10923: Diffusion API/URI Errata from Backlog to v3 on the Diffusion board.
May 10 2016, 2:06 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 10 2016, 2:06 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 10 2016, 2:05 PM · Diffusion (v3)
epriestley added a revision to T9554: Trigger "import" heuristics for imported repositories: Unknown Object (Differential Revision).
May 10 2016, 2:05 PM · Diffusion, Restricted Project, Restricted Project
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 10 2016, 1:28 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 10 2016, 1:27 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 10 2016, 1:27 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 10 2016, 12:56 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 10 2016, 12:56 PM · Diffusion (v3)
epriestley added a comment to T10941: Subversion fails to execute pre-commit hook if CWD isn't readable.

Thanks for hunting that down!

May 10 2016, 12:27 PM · Diffusion, Subversion, Bug Report
epriestley closed T10406: Archived repositories aren't imported as Resolved by committing Restricted Diffusion Commit.
May 10 2016, 12:15 PM · Bug Report, Diffusion

May 9 2016

epriestley added a comment to T10941: Subversion fails to execute pre-commit hook if CWD isn't readable.

I can't reproduce this:

May 9 2016, 11:50 PM · Diffusion, Subversion, Bug Report
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 11:42 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 9 2016, 11:42 PM · Diffusion (v3)
epriestley merged T10942: Subversion repositories are created with incorrect default URI into T10923: Diffusion API/URI Errata.
May 9 2016, 11:42 PM · Diffusion (v3)
epriestley merged task T10942: Subversion repositories are created with incorrect default URI into T10923: Diffusion API/URI Errata.
May 9 2016, 11:42 PM · Bug Report
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 11:31 PM · Diffusion (v3)
epriestley closed T8611: When Diffusion's "Can Create Repositories" application setting is "All Users," users still can't create repositories as Wontfix.

I think there were some bugs in the past that have now been resolved, but I'm not planning to fix the root of this, which is that you can not create repositories if the default "Edit Policy" excludes you, even if you have permission to create them according to "Can Create Repositories".

May 9 2016, 11:31 PM · Policy
epriestley added a comment to T10406: Archived repositories aren't imported.

D15873 makes this explicit in the dialog.

May 9 2016, 11:25 PM · Bug Report, Diffusion
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 11:24 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 9 2016, 11:21 PM · Diffusion (v3)
epriestley added a revision to T10406: Archived repositories aren't imported: Unknown Object (Differential Revision).
May 9 2016, 11:21 PM · Bug Report, Diffusion
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 9 2016, 10:45 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 10:38 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 9:26 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 9 2016, 9:25 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 9:16 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 9:09 PM · Diffusion (v3)
epriestley added a comment to T10923: Diffusion API/URI Errata.

Ah, thanks.

May 9 2016, 9:08 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 9 2016, 8:56 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 8:53 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 8:19 PM · Diffusion (v3)
epriestley created T10940: Enrolling an existing device in a repository cluster has surprising effects and inconsistent severity.
May 9 2016, 8:15 PM · Diffusion, Clusters
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

Would putting a large clickable "view thing" button in HTML email like the mock in T6600 potentially help address points (1) and (2) -- something like this?

May 9 2016, 7:43 PM · Prioritized, Restricted Project, Differential, Mail
epriestley added a member for Community: michaeljs1990.
May 9 2016, 7:34 PM
epriestley added a member for Blessed Committers: michaeljs1990.
May 9 2016, 7:34 PM
epriestley added a comment to T10939: Support for OWNERS files.

Overall, I'm leaning toward something in this vein to start with:

May 9 2016, 6:49 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

Let me look at how much of a mess adding "include, indirect, exclude" modes would be. I do think that's cleaner than pure-social "force clear" for this case if we aren't getting into too much trouble, and it's fine on the application side as long as the parent package is the one weakening its ownership over the children.

May 9 2016, 5:47 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

I guess we could have a third mode like "exclude, sort of". It's intentional that / owns everything by default so I can't go create a /src/ package and steal ownership of all the important code.

May 9 2016, 5:45 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

Wouldn't that result in aaa getting added to 100% of reviews in a given repo?

May 9 2016, 5:40 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

Yeah, I think it got discussed here and there but no one really had a good use case for it.

May 9 2016, 5:35 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

I think that already is expressible:

May 9 2016, 5:31 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

Can you walk me though the /a/b/ case in more detail? Maybe I'm misunderstanding.

May 9 2016, 5:22 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

This would solve other issues with root owners accepting on behalf of everyone accidentally

May 9 2016, 5:21 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

Another issue that I can't find an existing task for already is that OWNERS are non-hierarchical.

May 9 2016, 5:18 PM · Prioritized, Restricted Project, Owners
epriestley added a comment to T10939: Support for OWNERS files.

It seems like T8887 would mostly resolve this on its own? That is, you don't need T731, T1279, T10622, if you have T8887, do you?

May 9 2016, 5:14 PM · Prioritized, Restricted Project, Owners
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 5:02 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 9 2016, 3:29 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 2:08 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 9 2016, 2:07 PM · Diffusion (v3)
epriestley added a revision to T10923: Diffusion API/URI Errata: Unknown Object (Differential Revision).
May 9 2016, 1:31 PM · Diffusion (v3)
epriestley updated the task description for T10923: Diffusion API/URI Errata.
May 9 2016, 1:31 PM · Diffusion (v3)
epriestley added a comment to T10934: Phabricator not working with HHVM + proxygen server mode.

Or see @avivey's far more complete response.

May 9 2016, 4:44 AM · Bug Report
epriestley closed T10934: Phabricator not working with HHVM + proxygen server mode as Wontfix.

We don't support HHVM.

May 9 2016, 4:43 AM · Bug Report