Page MenuHomePhabricator
Feed Advanced Search

Mar 7 2016

epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

Awesome, thanks!

Mar 7 2016, 9:26 PM · Harbormaster (v3), Diffusion, Arcanist
avivey added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

I have a 500mb repo somewhere, and it would reproduce very easily to me, so I'll test this.

Mar 7 2016, 9:25 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley added a comment to T10093: When builds fail because the staging area was not pushed, make the cause clear.

After D15427, this should be pretty clear for "Land Revision".

Mar 7 2016, 5:27 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley closed T6983: Best practices for repository creation as Resolved.

Importing SVN repositories as single repositories is recommended (Facebook's had several million commits in 2011, IIRC).

Mar 7 2016, 5:21 PM · Documentation, Diffusion
epriestley updated subscribers of T6848: It should be possible to view a repository's policies without necessarily being able to edit it.
Mar 7 2016, 5:19 PM · Diffusion (v3)
epriestley merged task T10534: No ability to view push permissions without edit rights. into T6848: It should be possible to view a repository's policies without necessarily being able to edit it.
Mar 7 2016, 5:19 PM · Diffusion, Feature Request
epriestley closed T5929: User copied a working copy over a Diffusion working copy and nothing worked anymore as Wontfix.

This hasn't happened again and I think it's less reasonable to expect it to work in modern Phabricator.

Mar 7 2016, 5:18 PM · Diffusion
epriestley added a comment to T3607: Diffusion should raise a reasonable error when the default branch does not exist.

I think this was resolved at some point -- this is the behavior at HEAD, which seems broadly reasonable:

Mar 7 2016, 5:17 PM · Diffusion
epriestley closed T2225: Render only the first 1,000 changed paths by default when viewing a commit in Diffusion as Resolved.

This was fixed a couple of years ago in D4730, and works fine on the modern LLVM install: http://reviews.llvm.org/rL170845

Mar 7 2016, 5:13 PM · Diffusion, Differential
benjumanji created T10534: No ability to view push permissions without edit rights..
Mar 7 2016, 5:00 PM · Diffusion, Feature Request
epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Restricted Differential Revision.
Mar 7 2016, 4:49 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Restricted Differential Revision.
Mar 7 2016, 3:15 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley added a comment to T10093: When builds fail because the staging area was not pushed, make the cause clear.

After D15424, arc fails when failing to push the staging area.

Mar 7 2016, 2:55 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley closed T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote, a subtask of T8238: Formally support side-band change handoff in external repositories, as Resolved.
Mar 7 2016, 2:53 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley closed T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote as Resolved by committing Restricted Diffusion Commit.
Mar 7 2016, 2:53 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

I've marked D15424 as fixing this, although I don't have a detailed understanding of exactly what goes on in the git protocol and which heuristics it is using. In particular, I haven't been able to trick it into doing too much work locally (maybe it also looks at parents?).

Mar 7 2016, 2:53 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley added a revision to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote: Restricted Differential Revision.
Mar 7 2016, 2:27 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley closed T10528: Option+Click function in Differential doesn't always link to the correct line in Diffusion. as Resolved.

This is on a daily cron, I think you missed the update by a couple of hours. Link works OK for me now.

Mar 7 2016, 1:28 PM · Diffusion, Differential, Bug Report
epriestley added a comment to T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery"..

Hi! How can we reproduce this behavior?

Mar 7 2016, 1:27 PM · Audit, Diffusion, Bug Report
• tinytiongson added a project to T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery".: Diffusion.
Mar 7 2016, 10:30 AM · Audit, Diffusion, Bug Report
Mnkras added a comment to T10528: Option+Click function in Differential doesn't always link to the correct line in Diffusion..

Ah, makes sense.

Mar 7 2016, 12:59 AM · Diffusion, Differential, Bug Report
avivey added a comment to T10528: Option+Click function in Differential doesn't always link to the correct line in Diffusion..

That's because the symbols db on this install aren't always up-to-date; utils.php was updated recently, but the db still points to the old location...

Mar 7 2016, 12:58 AM · Diffusion, Differential, Bug Report
Mnkras created T10528: Option+Click function in Differential doesn't always link to the correct line in Diffusion..
Mar 7 2016, 12:52 AM · Diffusion, Differential, Bug Report

Mar 6 2016

epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Restricted Differential Revision.
Mar 6 2016, 11:37 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request

Mar 5 2016

epriestley closed T10519: no email sent for inline comments on a Diffusion commit as Resolved by committing Restricted Diffusion Commit.
Mar 5 2016, 10:18 PM · Mail, Diffusion, Bug Report
epriestley added a comment to T10519: no email sent for inline comments on a Diffusion commit.

Thanks for the report! This was a bug.

Mar 5 2016, 9:57 PM · Mail, Diffusion, Bug Report
epriestley claimed T10519: no email sent for inline comments on a Diffusion commit.
Mar 5 2016, 9:55 PM · Mail, Diffusion, Bug Report
epriestley added a revision to T10519: no email sent for inline comments on a Diffusion commit: Restricted Differential Revision.
Mar 5 2016, 9:55 PM · Mail, Diffusion, Bug Report
shuying created T10519: no email sent for inline comments on a Diffusion commit.
Mar 5 2016, 7:10 AM · Mail, Diffusion, Bug Report
epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

Yeah, that claim assumes someone will arc diff some published commit sooner or later (i.e., run arc diff while on master with no local changes). While this wouldn't happen on a normal workflow or on purpose, I suspect it happens more-often-than-never.

Mar 5 2016, 12:06 AM · Harbormaster (v3), Diffusion, Arcanist
avivey added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

From what I see, this doesn't actually normalize over time, if the staging repo is used only for staging: none of the /diff/ refs will ever be a parent of master from the real repo, because of the rebase during arc-land (I've written this at some point in Manual Staging Area Caveat).

Mar 5 2016, 12:03 AM · Harbormaster (v3), Diffusion, Arcanist

Mar 4 2016

benjumanji closed Q331: Is it possible to reindex commit metadata? as resolved.
Mar 4 2016, 5:55 PM · Diffusion
benjumanji updated Q331: Is it possible to reindex commit metadata? from to Is it possible to reindex commit metadata?.
Mar 4 2016, 11:50 AM · Diffusion

Mar 3 2016

epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

Yes, this should eliminate the need to sync/cron/do anything.

Mar 3 2016, 3:09 PM · Harbormaster (v3), Diffusion, Arcanist
cburroughs added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

Would this eliminate most of the benefit from cron based "sync refs from the main repo" glue?

Mar 3 2016, 3:08 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley moved T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote from Backlog to v3 on the Harbormaster board.
Mar 3 2016, 2:58 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley created T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.
Mar 3 2016, 2:58 PM · Harbormaster (v3), Diffusion, Arcanist

Feb 29 2016

epriestley closed T10467: Diffusion history doesn't update as Invalid.

Unfortunately, this bug is reproducible on my installation by simply visiting the Diffusion URL, there are no other steps.

Feb 29 2016, 12:54 PM · Bug Report (Needs Information), Diffusion
adityar7 added a comment to T10467: Diffusion history doesn't update.

I did look at the page.

Feb 29 2016, 10:21 AM · Bug Report (Needs Information), Diffusion
lordmortis added a comment to T7789: Support Git Large File Storage.

We're also about to select a source code hosting / project management tool, and Phabricator looks awesome but git-lfs support is a requirement for us!

Feb 29 2016, 3:12 AM · Customer Impact, Restricted Project, Files, Diffusion
epriestley closed T9926: SVN Commit fails, hard to debug as Invalid.

This has been open for several months without forward progress.

Feb 29 2016, 12:48 AM · Bug Report (Needs Information), Subversion, Diffusion

Feb 28 2016

epriestley edited projects for T10467: Diffusion history doesn't update, added: Bug Report (Needs Information); removed Bug Report.
Feb 28 2016, 11:32 PM · Bug Report (Needs Information), Diffusion
chad added a comment to T10467: Diffusion history doesn't update.

See Contributing Bug Reports for what we look for in a bug report. Specifically we need steps to reproduce the issue. If you're not sure if its a bug or other issue, and don't have steps to reproduce, please use the other Community Resources available for help.

Feb 28 2016, 3:15 PM · Bug Report (Needs Information), Diffusion
adityar7 created T10467: Diffusion history doesn't update.
Feb 28 2016, 2:23 PM · Bug Report (Needs Information), Diffusion
• teror4uks added a comment to T10460: Commit Still Parsing.

I am solving this problem. Reason was in empty Callsign in setting repository. After I added callsing, revisions became openable for audits.

Feb 28 2016, 10:12 AM · Diffusion, Bug Report (Needs Information)
Krinkle added a project to T2442: Show images in Diffusion diffs: Wikimedia.
Feb 28 2016, 1:08 AM · Wikimedia, Diffusion

Feb 27 2016

• teror4uks added a comment to T10460: Commit Still Parsing.

i am cloning repo in my local phabricator(ssh only read) and cloning repo in my notebook, then add new file in dir1 "test" and commit he in rSVNTEST then accept commit and i found this revision on my local phabricator where she all the same do not open for review code same all post revisions...

Снимок экрана от 2016-02-27 20:34:34.png (768×1 px, 149 KB)

Feb 27 2016, 5:36 PM · Diffusion, Bug Report (Needs Information)
• teror4uks added a comment to T10460: Commit Still Parsing.

okey im trying pull test repo in my sandbox, but im not sure what it's working. Chad how you can see on offer connect in my local phabricator and see all your self ? :)

Feb 27 2016, 5:08 PM · Diffusion, Bug Report (Needs Information)
chad added a comment to T10460: Commit Still Parsing.

We're also not familiar with https://riouxsvn.com/, so maybe removing that host as a variable would help. Phabricator has built in SVN hosting.

Feb 27 2016, 4:40 PM · Diffusion, Bug Report (Needs Information)
chad added a comment to T10460: Commit Still Parsing.

Unfortunately no, we need reproduction steps to be able to move further. We need some means of observing the issue in a local sandbox so we can be sure we've found and fixed the right bug. That might mean you isolating the offending commit that is giving Phabricator trouble, breaking down to a minimal test case, and pushing an example to rSVNTEST for us to inspect.

Feb 27 2016, 4:37 PM · Diffusion, Bug Report (Needs Information)
• teror4uks added a comment to T10460: Commit Still Parsing.

chad you have any ideas what's wrong in my local phabricator or whath next steps i have to do for resove it's problem?

Feb 27 2016, 4:19 PM · Diffusion, Bug Report (Needs Information)
chad edited projects for T10460: Commit Still Parsing, added: Bug Report (Needs Information), Diffusion; removed Bug Report.
Feb 27 2016, 4:10 PM · Diffusion, Bug Report (Needs Information)

Feb 26 2016

epriestley moved T10093: When builds fail because the staging area was not pushed, make the cause clear from Backlog to v3 on the Harbormaster board.
Feb 26 2016, 3:06 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley removed 1 mock(s) for T10433: Repo in Diffusion has no padding after Branches box if footer is not configured: Restricted Pholio Mock.
Feb 26 2016, 1:55 PM · Diffusion, Bug Report
• 9999999999 added 1 mock(s) for T10433: Repo in Diffusion has no padding after Branches box if footer is not configured: Restricted Pholio Mock.
Feb 26 2016, 1:07 PM · Diffusion, Bug Report

Feb 25 2016

avivey added a subtask for T9287: Working with many repositories: T10337: Implement `diffusion.search` and think about `diffusion.edit`.
Feb 25 2016, 9:32 PM · Restricted Project, Restricted Project, Diffusion
ianvkoeppe closed Q321: Diffusion Setup Mac OSX as resolved.
Feb 25 2016, 3:30 PM · Diffusion

Feb 24 2016

• Persona created T10445: Triggering Repository Updates.
Feb 24 2016, 1:28 PM
ianvkoeppe updated Q321: Diffusion Setup Mac OSX from to Diffusion Setup Mac OSX.
Feb 24 2016, 3:52 AM · Diffusion
epriestley added a comment to T10433: Repo in Diffusion has no padding after Branches box if footer is not configured.

I guess "off" is default, so "disabled" isn't quite accurate.

Feb 24 2016, 1:30 AM · Diffusion, Bug Report
epriestley renamed T10433: Repo in Diffusion has no padding after Branches box if footer is not configured from Repo in Diffusion has no padding after Branches box if footer is disabled to Repo in Diffusion has no padding after Branches box if footer is not configured.
Feb 24 2016, 1:30 AM · Diffusion, Bug Report
epriestley renamed T10433: Repo in Diffusion has no padding after Branches box if footer is not configured from Repo in Diffusion has no padding after Branches box to Repo in Diffusion has no padding after Branches box if footer is disabled.
Feb 24 2016, 1:02 AM · Diffusion, Bug Report
Mnkras created T10433: Repo in Diffusion has no padding after Branches box if footer is not configured.
Feb 24 2016, 12:26 AM · Diffusion, Bug Report

Feb 23 2016

epriestley renamed T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded from Can not Download large diffs in diffusion "No configured storage engine can store this file" to Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.
Feb 23 2016, 6:26 PM · Phacility, Files, Diffusion, Bug Report
ppggff added a comment to T10264: git clone using http hangs after update.

@epriestley, test files in last comment indicate 31 can decompress gzip properly.
please check it.

Feb 23 2016, 4:59 PM · Bug Report, Diffusion
pouyana added a comment to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded.

Thanks for the heads up. I will contact my user with this information. What you said make totally sense to me :).

Feb 23 2016, 12:45 PM · Phacility, Files, Diffusion, Bug Report
epriestley added a project to T10423: Huge diffs (>8MB) should stream directly into file storage in Diffusion when downloaded: Diffusion.
Feb 23 2016, 12:37 PM · Phacility, Files, Diffusion, Bug Report
ProfFan added a comment to T4618: Phabricator high cpu usage.
Feb 23 2016, 5:09 AM · Diffusion
avivey added a revision to T929: Allow two arbitrary revisions to be compared in Diffusion: Restricted Differential Revision.
Feb 23 2016, 1:38 AM · Diffusion (v3), Restricted Project
scode moved T9210: break apart Publish/Notify repo setting from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 23 2016, 12:02 AM · Restricted Project, Restricted Project, Diffusion

Feb 22 2016

eadler added a project to T9210: break apart Publish/Notify repo setting: Restricted Project.
Feb 22 2016, 11:53 PM · Restricted Project, Restricted Project, Diffusion
eadler removed a project from T9383: Support `git notes`: Restricted Project.
Feb 22 2016, 11:52 PM · KDE, Git, Diffusion
eadler closed T10415: Make it easier to manage large number of repositories with similar configuration via the web ui as Resolved.

To be clear: I was trying to describe my problem, not ask for a specific solution. EditEngine for creation would help a lot but I was focused on editing. I guess T10337 would actually solve the issue, though not in the web UI.

Feb 22 2016, 9:44 PM · Restricted Project, Diffusion, Feature Request
eadler closed T10415: Make it easier to manage large number of repositories with similar configuration via the web ui, a subtask of T9287: Working with many repositories, as Resolved.
Feb 22 2016, 9:44 PM · Restricted Project, Restricted Project, Diffusion
epriestley added a comment to T10415: Make it easier to manage large number of repositories with similar configuration via the web ui.

Sorry, I'm still not sure I quite understand the specific use cases for this feature that you anticipate.

Feb 22 2016, 8:28 PM · Restricted Project, Diffusion, Feature Request
eadler added a comment to T10415: Make it easier to manage large number of repositories with similar configuration via the web ui.

We have 2 distinct profiles and a few one-offs.
Ideally the following would be managed: Policies, Text Encoding, Branches, Actions. The remainder are templatized but obviously differ from repo to repo.

Feb 22 2016, 8:01 PM · Restricted Project, Diffusion, Feature Request
chad closed T10409: Document-pro CSS rule is bleeding into Diffusion property lists as Resolved by committing Restricted Diffusion Commit.
Feb 22 2016, 7:54 PM · Diffusion
chad added a revision to T10409: Document-pro CSS rule is bleeding into Diffusion property lists: Restricted Differential Revision.
Feb 22 2016, 7:50 PM · Diffusion
epriestley added a comment to T10415: Make it easier to manage large number of repositories with similar configuration via the web ui.

Do you legitimately have several distinct "profiles"? What differs between them?

Feb 22 2016, 7:27 PM · Restricted Project, Diffusion, Feature Request
avivey added a subtask for T9287: Working with many repositories: T10415: Make it easier to manage large number of repositories with similar configuration via the web ui.
Feb 22 2016, 6:22 PM · Restricted Project, Restricted Project, Diffusion
avivey added a parent task for T10415: Make it easier to manage large number of repositories with similar configuration via the web ui: T9287: Working with many repositories.
Feb 22 2016, 6:22 PM · Restricted Project, Diffusion, Feature Request
eadler renamed T10415: Make it easier to manage large number of repositories with similar configuration via the web ui from Make it easier to manage large number of repositories with similar configuration to Make it easier to manage large number of repositories with similar configuration via the web ui.
Feb 22 2016, 6:11 PM · Restricted Project, Diffusion, Feature Request
eadler moved T10415: Make it easier to manage large number of repositories with similar configuration via the web ui from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 22 2016, 6:07 PM · Restricted Project, Diffusion, Feature Request
eadler created T10415: Make it easier to manage large number of repositories with similar configuration via the web ui.
Feb 22 2016, 6:07 PM · Restricted Project, Diffusion, Feature Request
epriestley closed T10395: Deploy SSH keys associated with a repository as Resolved.
Feb 22 2016, 3:20 PM · Feature Request (Needs Information), Diffusion
amartin33 added a comment to T10395: Deploy SSH keys associated with a repository.

Yes that should work for my use case - I've tested and verified this functionality. Thanks!

Feb 22 2016, 3:13 PM · Feature Request (Needs Information), Diffusion
chad added a comment to T10409: Document-pro CSS rule is bleeding into Diffusion property lists.

oh

Feb 22 2016, 3:07 PM · Diffusion
epriestley created T10409: Document-pro CSS rule is bleeding into Diffusion property lists.
Feb 22 2016, 12:56 PM · Diffusion
epriestley added a comment to T10406: Archived repositories aren't imported.

This just sounds a lot like "I ran rm -rf /var/repo/X/ and all the data for rX vanished" to me, which is completely expected and should be predictable.

Feb 22 2016, 12:52 PM · Bug Report, Diffusion
epriestley added a comment to T10406: Archived repositories aren't imported.

None of the repository replication code is even written, though. What behavior do you expect today?

Feb 22 2016, 12:47 PM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

When we migrate our repository hosting to Phabricator, I plan to setup multiple repository hosts for sufficient redundancy. In this case, I would expect the new hosts to clone the repositories from a read-only slave.

Feb 22 2016, 10:21 AM · Bug Report, Diffusion
epriestley added a comment to T10406: Archived repositories aren't imported.

Suppose you have a hosted, active repository and do this:

Feb 22 2016, 10:20 AM · Bug Report, Diffusion
mrjoops added a comment to T10389: File listing is truncated in repository view.

Just a word to confirm the issue is solved in the new stable release.

Feb 22 2016, 9:33 AM · Diffusion, Bug Report
chad added a comment to T10406: Archived repositories aren't imported.

Thanks! The moving of the host was I think my main point that clarified it for me.

Feb 22 2016, 6:35 AM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

The steps to reproduce are quite simple:

Feb 22 2016, 6:33 AM · Bug Report, Diffusion
chad added a comment to T10406: Archived repositories aren't imported.

Well, specifically what you were doing, and what issues were caused after. Like moving tiers.

Feb 22 2016, 6:25 AM · Bug Report, Diffusion
chad added a comment to T10406: Archived repositories aren't imported.

Ok, if you feel this is a bug report, can you list the steps to reproduce the core issue in the description?

Feb 22 2016, 6:20 AM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

If the repository is hosted elsewhere then Phabricator isn't the canonical source, and the other system would be responsible for data anyway.

Feb 22 2016, 6:06 AM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

The problem here is that things will mysteriously stop working. Let's say that I refer to rXabcdef in a comment and then later mark rX as archived and replace my repository tier. Anyone who later clicks on the rXabcdef reference will hit an error.

Feb 22 2016, 6:06 AM · Bug Report, Diffusion
chad added a comment to T10406: Archived repositories aren't imported.

That's what I mean by "I must be missing something". What data is lost if it's hosted elsewhere?

Feb 22 2016, 6:04 AM · Bug Report, Diffusion