Page MenuHomePhabricator
Feed Advanced Search

Feb 2 2016

epriestley closed T10269: Duplicate entry for key "key_object" as Invalid.

sorry that I can't provide reproduction steps

Feb 2 2016, 10:32 PM · Maniphest
epriestley added a comment to T10266: Firefox body scroll fails when dragging tasks.

(Specifically, the scrolling is a feature which I added in D10188 but punted on making work in Firefox.)

Feb 2 2016, 9:57 PM · Firefox, Projects
epriestley closed T10267: Ancestral review dependency as Resolved.

Write Depends on D123. in the summary of B.

Feb 2 2016, 9:56 PM · Feature Request
epriestley added a revision to T10010: Implement Subprojects: Restricted Differential Revision.
Feb 2 2016, 9:07 PM · Projects (v3)
epriestley added a comment to T10256: Unable to set default page for some projects.

Nice. This is likely something easy/simple/silly, I just haven't been able to reproduce it locally and the answer has yet to come to me in a dream.

Feb 2 2016, 8:08 PM · Projects, Bug Report
exp10r3r awarded T9348: No way to kick users out of a Conpherence a Love token.
Feb 2 2016, 6:14 PM · Conpherence (v4)
epriestley closed T10259: fetch log crashes when using IP v6 (http), fetch fails as Resolved by committing Restricted Diffusion Commit.
Feb 2 2016, 6:13 PM · Diffusion, Bug Report
epriestley added a revision to T10259: fetch log crashes when using IP v6 (http), fetch fails: Unknown Object (Differential Revision).
Feb 2 2016, 6:09 PM · Diffusion, Bug Report
epriestley added a comment to T10259: fetch log crashes when using IP v6 (http), fetch fails.

ip2long can also return negative values (see rP30473549).

Feb 2 2016, 5:52 PM · Diffusion, Bug Report
epriestley added a comment to T8972: Editing a room edits the previously selected one.

Yep, we'll close issues once we resolve them.

Feb 2 2016, 4:47 PM · Conpherence (v4)
epriestley created T10266: Firefox body scroll fails when dragging tasks.
Feb 2 2016, 4:36 PM · Firefox, Projects
epriestley closed T10263: Using Cmd+Enter on "Add Actions" results in actions not being applied as Invalid.

This was almost certainly fixed by 5a723bf (D14991 / T10116) on January 11.

Feb 2 2016, 3:12 PM · Bug Report
epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 2 2016, 2:31 PM · Projects (v3), Workboards
epriestley added a comment to T10263: Using Cmd+Enter on "Add Actions" results in actions not being applied.

What version of Phabricator are you running?

Feb 2 2016, 2:59 AM · Bug Report
epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 2 2016, 1:49 AM · Projects (v3), Workboards
epriestley updated the task description for T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:19 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley updated the task description for T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:18 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley updated subscribers of T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:15 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley merged task T6007: "File link has expired" when trying to shared direct links to images into T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:15 AM · Files
epriestley updated the task description for T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:15 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley updated subscribers of T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:08 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley merged task T9896: make images from comments visible in email into T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:08 AM · Restricted Project, Remarkup, Mail
epriestley merged task T10261: Images in Phriction are served with `no-cache` cache-control on Phacility into T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:08 AM · Bug Report
epriestley updated subscribers of T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:08 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley updated subscribers of T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:07 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley merged task T9377: Image lightbox perceived slow due to always creating new urls into T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:07 AM · Files, Wikimedia
epriestley updated subscribers of T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:07 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley merged task T8359: Switching between images in Pholio causes a full reload of the image into T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:07 AM · Pholio
epriestley renamed T10262: Scramble file secrets when attached objects change their view policies from Paranoid file security from WMF causes nearly universal performance problems to Paranoid file URL security mode causes nearly universal performance problems.
Feb 2 2016, 1:07 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley created T10262: Scramble file secrets when attached objects change their view policies.
Feb 2 2016, 1:07 AM · Restricted Project, Restricted Project, Wikimedia, Files
epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 2 2016, 1:04 AM · Projects (v3), Workboards
epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 2 2016, 12:00 AM · Projects (v3), Workboards

Feb 1 2016

epriestley added a revision to T5240: Dragging items (cards, panels) could be better in Workboards: Unknown Object (Differential Revision).
Feb 1 2016, 8:51 PM · Projects (v3), Workboards
epriestley added a member for Blessed Committers: yelirekim.
Feb 1 2016, 7:18 PM
epriestley added a comment to T7755: Improve reliability of real-time notification delivery.

It sounds like neither of you have actually configured Phabricator's real-time infrastructure. See:

Feb 1 2016, 6:27 PM · Conpherence
epriestley closed T10247: Don't show custom user icons in typeaheads as Resolved by committing Restricted Diffusion Commit.
Feb 1 2016, 5:49 PM · Typeahead, Bug Report
epriestley renamed T10257: xhpast does not build on ARM hardware from arcanist: unable to run arc liberate on armhf hardware to xhpast does not build on ARM hardware.
Feb 1 2016, 5:48 PM · XHPAST, Bug Report
epriestley closed T10242: Images uploaded to user profile descriptions unviewable as Resolved by committing Restricted Diffusion Commit.
Feb 1 2016, 5:46 PM · People, Bug Report
epriestley added a revision to T10247: Don't show custom user icons in typeaheads: Unknown Object (Differential Revision).
Feb 1 2016, 5:46 PM · Typeahead, Bug Report
epriestley added a revision to T10242: Images uploaded to user profile descriptions unviewable: Unknown Object (Differential Revision).
Feb 1 2016, 5:38 PM · People, Bug Report
epriestley renamed T10252: Username autocompletion doesn't work with some non-US keyboard layouts from Username autocomplettion doesn't work with some non-US keyboard layouts to Username autocompletion doesn't work with some non-US keyboard layouts.
Feb 1 2016, 5:34 PM · Restricted Project, Bug Report
epriestley renamed T10252: Username autocompletion doesn't work with some non-US keyboard layouts from Username autocomplettion doesn't work with Chrome Browser to Username autocomplettion doesn't work with some non-US keyboard layouts.
Feb 1 2016, 5:34 PM · Restricted Project, Bug Report
epriestley added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

I can reproduce some variant of this locally by following these steps on OS X:

Feb 1 2016, 5:34 PM · Restricted Project, Bug Report
epriestley added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

Ah, thanks. I think this is almost certainly related to your keyboard layout and how we're detecting that you typed "@".

Feb 1 2016, 5:30 PM · Restricted Project, Bug Report
epriestley renamed T10247: Don't show custom user icons in typeaheads from User definied symbol os not shown at "assigned to" to Don't show custom user icons in typeaheads.
Feb 1 2016, 5:17 PM · Typeahead, Bug Report
epriestley added a comment to T10253: Importing linux git repository fails on one commit claiming non-utf8 string is used instead of utf8.

I cloned Linux and examined the commit, but couldn't immediately see anything wrong with it. I'll do the full import when I have a chance.

Feb 1 2016, 5:17 PM · Diffusion, Bug Report
epriestley added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

@OCram, do you have an non-US keyboard?

Feb 1 2016, 3:37 PM · Restricted Project, Bug Report
epriestley triaged T10257: xhpast does not build on ARM hardware as Wishlist priority.
  • You only need to run arc liberate when developing Phabricator itself (e.g., writing Phabricator extensions or otherwise modifying Phabricator).
    • The one ARM system (the Raspberry Pi) we have other direct evidence of users attempting to do installs on is explicitly not supported as a Phabricator host platform -- see Installation Guide. You can try, but you're on your own.
    • If you're using an ARM system that could, in theory, broadly qualify as a "normal computer" to host and/or develop Phabricator this is something we might eventually look at supporting, but we don't currently have any evidence that anyone else is trying to do this. We are vanishingly unlikely to dedicate resources to ARM support for the benefit of only one user (if you are developing on ARM hardware) or one install (if you are hosting on ARM hardware).
    • If you did read the "Installation Guide" and believed ARM hardware to reasonably qualify as "a normal computer", we can add additional language to make it clear that ARM is not included in what we consider "a normal computer".
Feb 1 2016, 3:35 PM · XHPAST, Bug Report
epriestley added a comment to T10257: xhpast does not build on ARM hardware.

Is the local system a raspberry pi?

Feb 1 2016, 3:27 PM · XHPAST, Bug Report
epriestley added a revision to T10010: Implement Subprojects: Unknown Object (Differential Revision).
Feb 1 2016, 3:19 PM · Projects (v3)
epriestley closed T10255: Edit permissions for Project (before and after some update of Phabricator) as Invalid.

You can use bin/policy unlock to unlock an object.

Feb 1 2016, 3:15 PM · Bug Report
epriestley added a comment to T10256: Unable to set default page for some projects.

I can't reproduce this.

Feb 1 2016, 3:05 PM · Projects, Bug Report
epriestley added a comment to T10252: Username autocompletion doesn't work with some non-US keyboard layouts.

I can't reproduce this with Chrome 48.0.2564.97 on OSX. Here's the autocomplete working on my local instance in Chrome:

Feb 1 2016, 12:40 PM · Restricted Project, Bug Report
grmbl awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Feb 1 2016, 11:34 AM · Workboards (v3), Restricted Project
epriestley closed T10251: 【iOS】add unit test as Spite.
Feb 1 2016, 1:56 AM · Feature Request
epriestley updated the task description for T10246: Deploy Drydock in the Phacility cluster.
Feb 1 2016, 12:12 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley closed T10092: User reports Drydock not parallelizing working copy builds as Resolved.
Feb 1 2016, 12:06 AM · Drydock

Jan 31 2016

epriestley added a comment to T10247: Don't show custom user icons in typeaheads.

Yeah, I agree that these are pretty confusing in typeaheads. They kind of ended up there by accident, I'll swap them back to always being fa-user in that context.

Jan 31 2016, 11:50 PM · Typeahead, Bug Report
epriestley added a comment to T10250: FATAL ERROR - AphrontTagView.

Should be fixed at HEAD. Thanks for the report!

Jan 31 2016, 11:20 PM · Bug Report
epriestley closed T10250: FATAL ERROR - AphrontTagView as Resolved by committing Restricted Diffusion Commit.
Jan 31 2016, 11:20 PM · Bug Report
epriestley added a revision to T10250: FATAL ERROR - AphrontTagView: Unknown Object (Differential Revision).
Jan 31 2016, 11:18 PM · Bug Report
epriestley added a comment to T10250: FATAL ERROR - AphrontTagView.

@chad, I'm going to push this back down to PHUIHandleTagListView.php and rename it:

Jan 31 2016, 11:14 PM · Bug Report
epriestley added a comment to T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails.

I merged these to stable and upgraded web001 to fix the immediate issue. The utf8 fix technically needs to go to the repo hosts, but we don't need it there immediately since it only aided in identifying and debugging the gzip issue.

Jan 31 2016, 12:52 AM · Phacility, Diffusion
epriestley closed T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails as Resolved by committing Restricted Diffusion Commit.
Jan 31 2016, 12:48 AM · Phacility, Diffusion
epriestley added a revision to T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails: Unknown Object (Differential Revision).
Jan 31 2016, 12:46 AM · Phacility, Diffusion
epriestley added a comment to T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails.

Alright, I made some progress on this.

Jan 31 2016, 12:42 AM · Phacility, Diffusion
epriestley added a revision to T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails: Unknown Object (Differential Revision).
Jan 31 2016, 12:04 AM · Phacility, Diffusion
epriestley added a comment to T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails.

Slightly more useful:

Jan 31 2016, 12:01 AM · Phacility, Diffusion

Jan 30 2016

epriestley added a comment to T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails.

Logging for this is now in production, but the initial data is totally useless:

Jan 30 2016, 11:49 PM · Phacility, Diffusion
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

I've issued all instances a 72-hour credit for this disruption.

Jan 30 2016, 8:51 PM · Phacility
epriestley closed T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster as Resolved.

I purged dead instances on db001 more aggressively, leaving us with this result:

Jan 30 2016, 8:48 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

Service on db001 has been restored, although there's a backlog of backups + daemons that are slamming it so it won't be very responsive until those drain.

Jan 30 2016, 7:38 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

db001 is still loading. It's through the particularly slow instance and I expect it to finish in the relatively near future.

Jan 30 2016, 5:02 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
  • db004 loaded in 14m18s and is now 11% utilized (6.2G).
  • db005 is 77% utilized (46G) with a 250MB compressed backup.
  • db005 dumped in about 1m30s.
  • db005 loaded in 8m22s.
  • db005 is now 8% utilized (4.7GB).
  • db001 is still loading, and I think I pretty much just have to wait it out. Major issue is one enormous, disabled "test" instance but there's no easy way to skip it.
Jan 30 2016, 1:57 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
  • I destroyed out-of-service instances on db004.
  • I disabled and destroyed two very large "test" instances which were still technically in service but had one user, no activity, and were long overdue on billing (just not >120 days overdue yet, so they hadn't triggered automatic suspension). One of them had some extra information which strongly suggested it was a "test" instance. If this was in error, they can be restored from backups later.
  • This leaves db004 59% utilized (35G) with a 1.1GB compressed backup size.
  • db004 dumped in 3m32s.
  • db004 is now loading.
  • I'm preparing db005.
  • db001 is still loading.
Jan 30 2016, 1:28 PM · Phacility
yaserkh awarded T1139: Internationalize Phabricator a Love token.
Jan 30 2016, 1:11 PM · Localization
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
  • db003 has 31% utilization (19G) with a 250MB total compressed backup size.
  • Reassuringly, dump time was 1m49s.
  • Load time was 6m32s.
  • db003 is now 8% utilized (4.3G).
  • I'm prepping db004.
  • db001 is still loading.
Jan 30 2016, 1:11 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
  • The db002 load completed in a relatively reasonable 17m50s.
  • Utilization is now 18% (11G). A sizable chunk of this is removable at some future date.
  • I'm in the process of preparing db003.
  • The db001 load is ongoing.
Jan 30 2016, 12:53 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
  • The db002 dump completed in 7m31s, which is much more promising.
  • I wiped the data and enabled per-file tables.
  • I'm currently reloading the databases.
Jan 30 2016, 12:34 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
  • db001 compressed much better than admin001 or secure001 and overshot volume free space on restore. I've cleared space and restarted the restore.
  • db002 is starting at 31% utilized (19GB) with a 3GB compressed backup (a significant portion of this is unmigrated file data, though, which I expect to dump and restore relatively quickly).
  • I disabled network on db002 and am dumping the data.
Jan 30 2016, 12:25 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
  • I destroyed all out-of-service test instances on the host.
  • I destroyed one unusually large out-of-service "test" instance.
  • This left us 67% utilized (40GB) with a 1.3GB compressed backup.
  • I disabled network traffic.
  • I dumped the databases, which took 35m44s (???).
  • I wiped the data and enabled per-file tables.
  • I'm currently reloading the databases, but I expect that to take a while.
Jan 30 2016, 12:19 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

I'm beginning this on db001 now. The high volume utilization shouldn't be an issue since the ultimate process doesn't involve doing anything in place.

Jan 30 2016, 10:20 AM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

This host took 4m4s to dump and 9m36s to restore. Utilization is now 21% (6.1G).

Jan 30 2016, 10:19 AM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

Er, I was reading the wrong backup filesize -- the actual size is 1.5GB. A big chunk of this is in parse caches, so I ran bin/cache purge --purge-all. I'm now doing the actual maintenance.

Jan 30 2016, 9:56 AM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

I'm beginning this on secure001 now (this host). Prior to maintenance, the volume is 52% utilized (16GB) with a 306M compressed backup. Service on this host will be briefly interrupted.

Jan 30 2016, 9:54 AM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

I disabled network connections to MySQL and restarted it.

Jan 30 2016, 9:52 AM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

Prior to optimization, admin001 was 46% utilized (27GB of database data) with a 434M total backup size.

Jan 30 2016, 9:39 AM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

I am beginning this on admin001 now.

Jan 30 2016, 9:18 AM · Phacility
epriestley created T10246: Deploy Drydock in the Phacility cluster.
Jan 30 2016, 1:13 AM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley edited the content of Changelog.
Jan 30 2016, 12:45 AM
epriestley created 2016 Week 5 (Very Late January).
Jan 30 2016, 12:45 AM

Jan 29 2016

epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

This may actually be not-too-terrible. I think there's a good chance that db005 really does have less than 22% of a volume of "actual" data, since the compressed size of backups for all active instances on the shard is only about 300MB. We had a bunch of heavy test instance churn on that shard for whatever reason.

Jan 29 2016, 8:06 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

I'm going to do this tonight/tomorrow, but this is going to be fairly involved. Current utilization is:

Jan 29 2016, 7:49 PM · Phacility
epriestley awarded T10241: Modifying an externally-hosted repository's URL/path can unintentionally change the credentials a Evil Spooky Haunted Tree token.
Jan 29 2016, 6:00 PM · Passphrase, Diffusion, Bug Report
epriestley added a comment to T10239: Ability to pass more info to custom linters.

what the heck

Jan 29 2016, 5:18 PM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.

Maybe clang-format could be changed to give an output that's properly "split up" -- I don't know how feasible it would be, but given how fiddly it is (the whole tool is a collection of special cases), I expect that would be Hard.

Jan 29 2016, 5:11 PM · Feature Request
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Jan 29 2016, 3:01 PM
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

This is live on this server (secure.phabricator.com) -- let us know if you're still seeing issues. Seems OK for me on a physical iPhone 4s.

Jan 29 2016, 2:59 PM · Safari, Mobile, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

This is now deployed to this server (secure.phabricator.com) -- let me know if you're still seeing issues? Behavior seems OK in the simulator and with my physical iPhone 4s, but I don't have a fancy physical 6s to test.

Jan 29 2016, 2:57 PM · Safari, Differential, Bug Report
epriestley closed T10229: In iOS Safari, buttons must be tapped twice to fire. as Resolved by committing Restricted Diffusion Commit.
Jan 29 2016, 2:55 PM · Safari, Mobile, Bug Report