Page MenuHomePhabricator

FATAL ERROR - AphrontTagView
Closed, ResolvedPublic

Description

Updated to latest version.

>>> UNRECOVERABLE FATAL ERROR <<<

Can&#039;t use method return value in write context

/var/www/xxxx/src/view/AphrontTagView.php:81


┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻

Revisions and Commits

Event Timeline

Can you provide details on reproducing the errors? My sandbox and this install are both at HEAD.

Sounds like this might be a PHP version issue, are you using one older than 5.5?

@chad, I'm going to push this back down to PHUIHandleTagListView.php and rename it:

  • In PHP prior to 5.5, you can't pass an expression to empty().
  • This conflicts conceptually with AphrontFormControl->isEmpty(), which has a different meaning, but is part of the same class tree (AphrontView).
  • Calling this method will render the content, which is potentially very expensive and can lead to double-rendering, which sometimes causes problematic side effects (e.g., double registration of Javelin behaviors).

i just did a simple git pull like every other update

PHP 5.4.36-0+deb7u1 (cli) (built: Dec 31 2014 07:31:33) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies

Should be fixed at HEAD. Thanks for the report!

yes it's fixed. thx for the fast response.