Maniphest T10259

fetch log crashes when using IP v6 (http), fetch fails
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	avivey
	Feb 1 2016, 8:42 PM

Tags

Referenced Files

None

Subscribers

Description

Error trace: https://phabricator.pmoreau.org/P85

looks like ip2long should return FALSE, and LISK gets an empty string.

(I don't have an ip6 setup to test this, but the user confirms ip6)

Revisions and Commits

rP Phabricator
	D15165	rP9d125b459ea8 Use large text columns to store IP addresses

Related Objects

Mentioned In: rP30473549acfb: Add a basic pull event log for debugging repository cloning
Mentioned Here: rP9d125b459ea8: Use large text columns to store IP addresses
rP30473549acfb: Add a basic pull event log for debugging repository cloning
rPHUf43291e99d36: Distinguish more carefully between different kinds of MySQL connection errors
rARC57f6fb59d739: Make `arc unit` NoseTestEngine work in a sub-dir
rPd41aaba2a184: Fix coverage line index lookup in diffusion browser

Event Timeline

avivey renamed this task from fetch log crashes when using IP v6 (http) to fetch log crashes when using IP v6 (http), fetch fails.Feb 1 2016, 8:42 PM

avivey created this task.

• pmoreau added a subscriber: • pmoreau.Feb 1 2016, 8:46 PM

Not sure if lisk should interpret "false" as "null" in this case?

I'm using PHP 7.0.2 with nginx 1.8.1, and running Phabricator at HEAD:

phabricator: d41aaba2a184e0f57c68dfd56c95e628d55d8995 (Mon, Feb 1)
arcanist: 57f6fb59d73994d90cd94143787424ce0fdbf73b (Mon, Jan 25)
phutil: f43291e99d36045bc459e5133454c0d8fd8768ea (Thu, Jan 21)

The result of ip2long:

php > var_dump(ip2long(some_ipv6_address));
bool(false)

FWIW, PHP 7 is not yet supported.

Nevermind me, Google suggests IPv6 a pain in PHP

joshuaspence added a subscriber: joshuaspence.Feb 2 2016, 12:29 PM

ip2long can also return negative values (see rP30473549).

I'm going to replace this with a LONGTEXT with a nuanced and flavorful description of the remote address.

epriestley added a revision: D15165: Use large text columns to store IP addresses.Feb 2 2016, 6:09 PM

epriestley closed this task as Resolved by committing rP9d125b459ea8: Use large text columns to store IP addresses.Feb 2 2016, 6:13 PM

epriestley added a commit: rP9d125b459ea8: Use large text columns to store IP addresses.

Tested with rP9d125b459ea8, and it's working properly: thanks for the quick fix!