Page MenuHomePhabricator
Feed Advanced Search

Jul 26 2015

epriestley added a comment to T8969: Allow adding a herald rule based on a phriction document author's projects.

See T7962 and T8054 for previous requests to describe problems.

Jul 26 2015, 8:06 PM · FreeBSD, Phriction, Herald
chad added a comment to T8969: Allow adding a herald rule based on a phriction document author's projects.

We also talked about forcing people to use 'story cards' for requests. So it'd be something like:

Jul 26 2015, 7:42 PM · FreeBSD, Phriction, Herald
chad added a comment to T8969: Allow adding a herald rule based on a phriction document author's projects.

(Reviewing Wiki Pages seems reasonable at some point).

Jul 26 2015, 7:33 PM · FreeBSD, Phriction, Herald
chad added a comment to T8969: Allow adding a herald rule based on a phriction document author's projects.

@eadler the main problem with filing feature request solutions, then trying to justify it with problems is it makes our job significantly harder, that we have to reject multiple things or try to formulate long reasoned answers for each item. When you just file a problem, we're much more easily able to manage and group it with other (similar) problems. The solutions might change, but we're a very small team and when we solve problems, we try to group them to satisfy the most use cases. Just trust us with your problems.

Jul 26 2015, 7:32 PM · FreeBSD, Phriction, Herald
chad merged task T8969: Allow adding a herald rule based on a phriction document author's projects into T4099: Add CC: to Phriction Documents.
Jul 26 2015, 7:27 PM · FreeBSD, Phriction, Herald
eadler added a comment to T8969: Allow adding a herald rule based on a phriction document author's projects.

I updated the task description hopefully better describing the problem

Jul 26 2015, 7:15 PM · FreeBSD, Phriction, Herald
eadler updated the task description for T8969: Allow adding a herald rule based on a phriction document author's projects.
Jul 26 2015, 7:15 PM · FreeBSD, Phriction, Herald
chad added a comment to T8969: Allow adding a herald rule based on a phriction document author's projects.

Please file feature requests only describing your problem, not your solution.

Jul 26 2015, 7:11 PM · FreeBSD, Phriction, Herald
eadler moved T8969: Allow adding a herald rule based on a phriction document author's projects from Backlog to Nice To Have on the FreeBSD board.
Jul 26 2015, 6:50 PM · FreeBSD, Phriction, Herald
eadler added a project to T8969: Allow adding a herald rule based on a phriction document author's projects: FreeBSD.
Jul 26 2015, 6:50 PM · FreeBSD, Phriction, Herald
eadler created T8969: Allow adding a herald rule based on a phriction document author's projects.
Jul 26 2015, 6:49 PM · FreeBSD, Phriction, Herald
rene added a comment to T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist).

I worked around the update issue by using

git fetch
git reset --hard 6be53bd9160807fb7c829b72b23025d233f7072c

(as suggested on the IRC)

Jul 26 2015, 1:17 PM · Mailing Lists, Herald, Installing & Upgrading
joshuaspence added projects to T8958: Unable to Migrate Herald conditions which use mailing lists.. fails (Table 'phabricator_herald.herald_actionrecord' doesn't exist): Herald, Mailing Lists.
Jul 26 2015, 9:58 AM · Mailing Lists, Herald, Installing & Upgrading

Jul 25 2015

epriestley created T8957: Upgrading: HeraldCustomAction is now HeraldAction.
Jul 25 2015, 11:42 AM · Installing & Upgrading, Herald

Jul 24 2015

epriestley closed T8822: Unhandled Exception ("InvalidArgumentException") when try to edit Herald rule. as Resolved.

Pretty sure this is fixed now, let me know if you're still seeing it at HEAD.

Jul 24 2015, 11:22 PM · Herald
chad updated subscribers of T8952: Hide "Herald added subscribers..." stories from feed completely.
Jul 24 2015, 10:26 PM · Feed, Herald
chad added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

Oh, yes the "Herald" as the actor is incorrect.

Jul 24 2015, 10:26 PM · Feed, Herald
chad added a comment to T8952: Hide "Herald added subscribers..." stories from feed completely.

This is displaying as intended. That is, if there is no image available, we still outline the actor space for consistency.

Jul 24 2015, 10:25 PM · Feed, Herald
• sshannin created T8952: Hide "Herald added subscribers..." stories from feed completely.
Jul 24 2015, 9:45 PM · Feed, Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Restricted Differential Revision.
Jul 24 2015, 8:03 PM · Herald
thoughtpolice created T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them.
Jul 24 2015, 7:26 PM · Restricted Project, Diffusion, Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Restricted Differential Revision.
Jul 24 2015, 7:26 PM · Herald
epriestley closed T8920: 'Another Herald rule matches' is being displayed as a raw PHID as Resolved by committing Restricted Diffusion Commit.
Jul 24 2015, 5:57 PM · Herald
epriestley closed T8920: 'Another Herald rule matches' is being displayed as a raw PHID, a subtask of T8726: Modularize Herald fields and actions, as Resolved.
Jul 24 2015, 5:57 PM · Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Restricted Differential Revision.
Jul 24 2015, 3:37 PM · Herald
epriestley renamed T8726: Modularize Herald fields and actions from Modularize Herald fields to Modularize Herald fields and actions.
Jul 24 2015, 3:35 PM · Herald
jpoehls added a comment to T4887: Extend the blocking reviewers functionality universally.

It sounds like you actually want T731.

Jul 24 2015, 3:15 PM · Restricted Project, Differential, Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Restricted Differential Revision.
Jul 24 2015, 2:54 PM · Herald
epriestley added a comment to T4887: Extend the blocking reviewers functionality universally.

It sounds like you actually want T731.

Jul 24 2015, 2:16 PM · Restricted Project, Differential, Herald
jpoehls added a comment to T4887: Extend the blocking reviewers functionality universally.

Our team would greatly benefit from this feature.

Jul 24 2015, 2:10 PM · Restricted Project, Differential, Herald

Jul 23 2015

epriestley added a revision to T8920: 'Another Herald rule matches' is being displayed as a raw PHID: Restricted Differential Revision.
Jul 23 2015, 8:28 PM · Herald
epriestley claimed T8920: 'Another Herald rule matches' is being displayed as a raw PHID.
Jul 23 2015, 8:24 PM · Herald
joshuaspence claimed T8635: Show history of changes to Herald rules.
Jul 23 2015, 8:55 AM · Restricted Project, Herald

Jul 22 2015

chad added a comment to T8138: Creating Herald rule on mobile is difficult.

Was it easier if you turned your phone to landscape?

Jul 22 2015, 5:30 PM · Mobile, Herald
chad closed T8923: add the ability to watch new users (especially to Herald) as Wontfix.

We don't have plans to build onboarding tools for the foreseeable future. Our expectation is installs will handle these needs on their own through documentation and other means (programatic enforcement, code review via owners, direct mentorship, IRC, Conpherence, etc).

Jul 22 2015, 12:48 AM · Herald
eadler created T8923: add the ability to watch new users (especially to Herald).
Jul 22 2015, 12:37 AM · Herald

Jul 21 2015

epriestley added a comment to T8920: 'Another Herald rule matches' is being displayed as a raw PHID.

This one is a bit magical and needs some adjustments after changes from T8726.

Jul 21 2015, 6:43 PM · Herald
epriestley added a parent task for T8920: 'Another Herald rule matches' is being displayed as a raw PHID: T8726: Modularize Herald fields and actions.
Jul 21 2015, 6:42 PM · Herald
epriestley added a subtask for T8726: Modularize Herald fields and actions: T8920: 'Another Herald rule matches' is being displayed as a raw PHID.
Jul 21 2015, 6:42 PM · Herald
cburroughs created T8920: 'Another Herald rule matches' is being displayed as a raw PHID.
Jul 21 2015, 6:41 PM · Herald
chad closed T8906: Allow Herald to add comments to tasks as Wontfix.

Those problems can be solved with general documentation, it's not something that needs to exist in Herald.

Jul 21 2015, 3:57 PM · Maniphest, Herald
eadler triaged T8906: Allow Herald to add comments to tasks as Wishlist priority.

there are other use cases that we'd like to use it for. For example

Jul 21 2015, 3:53 PM · Maniphest, Herald
eadler reopened T8906: Allow Herald to add comments to tasks as "Open".
Jul 21 2015, 3:52 PM · Maniphest, Herald
epriestley merged task T8905: Allow Herald to assign a task back to original author into T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Jul 21 2015, 11:09 AM · Maniphest, Herald
epriestley added a comment to T8905: Allow Herald to assign a task back to original author.

Based on context (in T8906) and previous discussion, my guess is that you're trying to make the "Projects" field required. I'm going to merge this into T6030, which discusses solving that root issue (among other related issues).

Jul 21 2015, 11:08 AM · Maniphest, Herald
epriestley merged task T8906: Allow Herald to add comments to tasks into T6030: Allow CustomFields to specify additional options (like "required") configurable in `<application>.fields`.
Jul 21 2015, 11:03 AM · Maniphest, Herald
epriestley added a comment to T8906: Allow Herald to add comments to tasks.

We'd prefer to solve this by letting you make the "Projects" field required, since that's the actual root issue. I'm going to merge this into T6030, which is the general blocker for that.

Jul 21 2015, 11:02 AM · Maniphest, Herald
epriestley reopened T8905: Allow Herald to assign a task back to original author as "Open".

This isn't quite the same as T7804, see T7804#127310 for discussion.

Jul 21 2015, 10:12 AM · Maniphest, Herald
epriestley added a comment to T7804: Implement an "Acting User" Herald condition.

These aren't quite the same. One is a new condition/field, which would let you write rules like this ("mail me about all zebra stuff, except if I took the action"):

Jul 21 2015, 10:11 AM · Restricted Project, Herald, Mail
chad added a comment to T8906: Allow Herald to add comments to tasks.

Probably T5162 is what you're thinking of, you've mentioned both these features before.

Jul 21 2015, 7:38 AM · Maniphest, Herald
chad added a comment to T7804: Implement an "Acting User" Herald condition.

I think this is the correct merge, but maybe I am misreading this. Unmerge if wrong @epriestley.

Jul 21 2015, 7:35 AM · Restricted Project, Herald, Mail
chad updated subscribers of T7804: Implement an "Acting User" Herald condition.
Jul 21 2015, 7:33 AM · Restricted Project, Herald, Mail
chad merged task T8905: Allow Herald to assign a task back to original author into T7804: Implement an "Acting User" Herald condition.
Jul 21 2015, 7:33 AM · Maniphest, Herald
swisspol added a comment to T8905: Allow Herald to assign a task back to original author.

Unfortunately we are on Phacility so that would not be an option.

Jul 21 2015, 5:28 AM · Maniphest, Herald
Mnkras added a comment to T8905: Allow Herald to assign a task back to original author.

I think FreeBSD made an extension for this: https://github.com/freebsd/phabricator/commit/8e442fc85d733ed6ec2890857ac245d86a61f1c0

Jul 21 2015, 5:04 AM · Maniphest, Herald
eadler added a comment to T8906: Allow Herald to add comments to tasks.

FWIW I'd find this generally useful: allow Herald to add comments to any object. One use case I'd really love to use it for is to "welcome and inform" new users on their first diff letting them know that someone will look at it, common issues, etc.

Jul 21 2015, 4:37 AM · Maniphest, Herald
eadler added projects to T8905: Allow Herald to assign a task back to original author: Herald, Maniphest.
Jul 21 2015, 4:19 AM · Maniphest, Herald
eadler added projects to T8906: Allow Herald to add comments to tasks: Herald, Maniphest.
Jul 21 2015, 4:19 AM · Maniphest, Herald

Jul 20 2015

OCram added a comment to T8812: Herald Rule does not send mails.

Tested it again with c3e16e26c9fd7acdfa5c6a12d8c591ac46d7a85

Jul 20 2015, 6:58 AM · Herald

Jul 18 2015

andypuettmann added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

still occurring when you have a field of type "user"
save anything in it.
Then edit again and clear the field, will result in this error, on ANY action after this.
(Workboard move, comment, status change, in fact anything that triggers herald to evaluate this again.)

Jul 18 2015, 7:09 PM · Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Restricted Differential Revision.
Jul 18 2015, 1:07 PM · Herald

Jul 17 2015

epriestley added a revision to T8726: Modularize Herald fields and actions: Restricted Differential Revision.
Jul 17 2015, 5:31 PM · Herald
nickz added a comment to T8812: Herald Rule does not send mails.

Cool, thanks!

Jul 17 2015, 5:06 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

I'll try to make this more clear after T8726.

Jul 17 2015, 5:03 PM · Herald
nickz added a comment to T8812: Herald Rule does not send mails.

Ah, yeah, I believe that's the issue, I thought the mailing list user doesn't have to be given the read permission specifically. Thanks a lot for looking!

Jul 17 2015, 5:01 PM · Herald
epriestley added a revision to T8726: Modularize Herald fields and actions: Restricted Differential Revision.
Jul 17 2015, 3:19 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

Note that in this case and in the T8863 case, mail recipients must now be able to see objects (e.g., revisions and repositories) to receive email about them. It's possible that that's the source of this issue.

Jul 17 2015, 2:34 PM · Herald
epriestley added a comment to T8812: Herald Rule does not send mails.

I can't reproduce this. Here's a rule I wrote:

Jul 17 2015, 2:32 PM · Herald
andypuettmann added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

For reference:
T8866 reported the PhutilJSONParserException

Jul 17 2015, 9:58 AM · Herald
andypuettmann added a revision to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause): Restricted Differential Revision.
Jul 17 2015, 9:56 AM · Herald
andypuettmann added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

Finally found the cause in our system.
Looks like there is an error related to the "field-type" users.

Jul 17 2015, 12:55 AM · Herald
chad updated subscribers of T8812: Herald Rule does not send mails.
Jul 17 2015, 12:24 AM · Herald
chad merged task T8863: Herald "Send an Email" action doesn't work into T8812: Herald Rule does not send mails.
Jul 17 2015, 12:24 AM · Herald

Jul 16 2015

nickz created T8863: Herald "Send an Email" action doesn't work.
Jul 16 2015, 9:17 PM · Herald
epriestley closed T5016: Allow Herald rules for Maniphest to act on custom task fields as Resolved by committing Restricted Diffusion Commit.
Jul 16 2015, 9:12 PM · Herald, Custom Fields
eadler added projects to T8853: Allow "Administrator" to be used in Herald rules for "pusher": Herald, Diffusion.
Jul 16 2015, 2:40 AM · Diffusion, Herald

Jul 14 2015

aljungberg added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

I wish I had saved the logs, but alas.

Jul 14 2015, 4:28 PM · Herald, Mailing Lists, Restricted Project
andypuettmann added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

Do we have any way to avoid this error?
It seems to have started with latest update,
is this any combination of rules/permissions we can avoid or is this a general problem with one of the hooks inside herald?
(Its currently disabling almost any herald function in our installation, however a few of them still seem to work, but cant see a pattern that we have to avoid.)

Jul 14 2015, 3:00 PM · Herald
epriestley added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Do you still happen to have the original error message? That was unexpected, and the migration specifically accounted for the case of email collisions and I recall testing that case locally in detail, so I'm curious what I missed. The expected behavior is that that list wouldn't migrate (and would emit a message), but other lists would:

Jul 14 2015, 2:43 PM · Herald, Mailing Lists, Restricted Project
andypuettmann added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

Glad to hear this.
Will keep an eye on this then. =)

Jul 14 2015, 2:34 PM · Herald
andypuettmann removed projects from T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause): Maniphest, Workboards.
Jul 14 2015, 2:34 PM · Herald
epriestley added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

This is almost certainly fixed by outstanding changes to Herald which are awaiting review. See also T8822.

Jul 14 2015, 2:23 PM · Herald
aljungberg added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Not sure the migration works as intended.

Jul 14 2015, 1:03 PM · Herald, Mailing Lists, Restricted Project
andypuettmann added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

may be related to a combination of rules.

Jul 14 2015, 9:38 AM · Herald
andypuettmann added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

For easier use:

Jul 14 2015, 12:30 AM · Herald

Jul 13 2015

chad added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

There are also a number of outstanding Herald Diffs awaiting review, so it's likely some of this is fallout from moderinzing Herald.

Jul 13 2015, 10:45 PM · Herald
andypuettmann added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

Yes, just made a fresh git-pull on it before sending this ticket.
Will PM you.

Jul 13 2015, 10:44 PM · Herald
chad added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

And maybe more specifics on how I can reproduce the issue, thanks!

Jul 13 2015, 10:39 PM · Herald
chad added a comment to T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).

I can't immediately reproduce this issue. Can you confirm you're at HEAD?

Jul 13 2015, 10:38 PM · Herald
andypuettmann created T8836: Unhandled Exception when dragging a card on workboards (not affecting all projects, may need help to investigate the cause).
Jul 13 2015, 9:40 PM · Herald
sicnervo added a comment to T8822: Unhandled Exception ("InvalidArgumentException") when try to edit Herald rule..

Additional information about the rule from MySQL;

Jul 13 2015, 8:26 AM · Herald

Jul 10 2015

avivey added a comment to T8804: Replacing a Herald rule with a Doorkeeper extension.

AFAIK, DoorKeeper is a way to represent foreign objects and to interact with them; Here the remote object-like thing would be the chat channel?
This might be better served by:

  • Fixing/improving chat-bot, or
  • Use hipchat's write-only api with the feed.http-hooks (Might require extra steps), or
  • A feed worker, like DoorkeeperFeedWorker, sans the Doorkeeper part.
Jul 10 2015, 8:22 PM · Restricted Project, Herald, Doorkeeper
epriestley added a comment to T8822: Unhandled Exception ("InvalidArgumentException") when try to edit Herald rule..

This is likely fixed by further changes connected to T8726, which are currently out for review. I'll keep an eye on it.

Jul 10 2015, 12:40 PM · Herald
sicnervo added a project to T8822: Unhandled Exception ("InvalidArgumentException") when try to edit Herald rule.: Herald.
Jul 10 2015, 11:59 AM · Herald
OCram added a comment to T8812: Herald Rule does not send mails.
  • Here the transcript of the last test:
  • I also tried to swap the actions.

pasted_file (418×822 px, 54 KB)

pasted_file (546×318 px, 37 KB)

Jul 10 2015, 5:47 AM · Herald
OCram added a comment to T8812: Herald Rule does not send mails.

Ok I updated to 26faa8f1f6b4872be3cf889551cb4a480dbb2678. Still the same situation.

Jul 10 2015, 5:44 AM · Herald

Jul 9 2015

epriestley added a revision to T8726: Modularize Herald fields and actions: Restricted Differential Revision.
Jul 9 2015, 11:27 PM · Herald
joshuaspence added a comment to T8804: Replacing a Herald rule with a Doorkeeper extension.

I know you don't provide support for writing third party extensions, but is it possible to do what I am trying to do with Doorkeeper currently? Basically I guess I need to define conditions which define what is published and where it is published to.

Jul 9 2015, 10:20 PM · Restricted Project, Herald, Doorkeeper
epriestley added a revision to T655: Integrate CustomField into Herald: Restricted Differential Revision.
Jul 9 2015, 10:07 PM · Custom Fields, Herald
epriestley added a revision to T5016: Allow Herald rules for Maniphest to act on custom task fields: Restricted Differential Revision.
Jul 9 2015, 10:07 PM · Herald, Custom Fields