Page MenuHomePhabricator
Feed Advanced Search

Mar 4 2015

epriestley moved T6695: Differential view for adding an empty file looks wrong from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:11 PM · Differential
epriestley moved T6816: In diffs, when a file is both generated code and no changes were made, "Show File Contents" does not behave as expected from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:11 PM · Restricted Project, Differential
epriestley moved T6857: Moved file is showing incorrectly in Differential from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:11 PM · Differential
epriestley moved T3626: Detection of language for some file types isn't good from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:11 PM · Customer Impact, Restricted Project, Differential
epriestley moved T4105: Undefined index in DifferentialHunkParser from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:11 PM · Differential
epriestley moved T7377: Project reviewer not getting diff notification from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:11 PM · Notifications, Differential
epriestley moved T3669: Make it easier to remember to submit inline comments when updating a diff from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:11 PM · Design, Differential
epriestley moved T7446: When a revision requires a CLA, hide the text of the diff from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:11 PM · Differential
epriestley moved T5000: Using Differential with plain Git, without requiring Arc from v2 (UI/Mobile) to Future Work on the Differential board.
Mar 4 2015, 5:09 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley moved T182: Commit into repository directly from differential from v2 (UI/Mobile) to Future Work on the Differential board.
Mar 4 2015, 5:09 PM · Haskell.org, Restricted Project, Differential
epriestley closed T7456: Syntax highlighting for VHDL files not working as Resolved by committing Restricted Diffusion Commit.
Mar 4 2015, 4:51 PM · Diffusion
epriestley added a comment to T3626: Detection of language for some file types isn't good.

Parser diff: https://secure.phabricator.com/differential/diff/28809/

Mar 4 2015, 3:49 PM · Customer Impact, Restricted Project, Differential
epriestley added a comment to T3626: Detection of language for some file types isn't good.

We already have major parts of this map in getPygmentsLexerNameFromLanguageName().

Mar 4 2015, 3:49 PM · Customer Impact, Restricted Project, Differential
epriestley added a comment to T7456: Syntax highlighting for VHDL files not working.
  • You can use syntax.filemap to configure how files are highlighted.
  • The attached diff adds support for VHDL by default.
Mar 4 2015, 3:41 PM · Diffusion
epriestley added a revision to T7456: Syntax highlighting for VHDL files not working: Unknown Object (Differential Revision).
Mar 4 2015, 3:37 PM · Diffusion
epriestley added a comment to T7454: Longer Maniphest tasks not fully displayed (as Phabricator defines a result set limit as 100 rows).

You must not have previously interacted with the object.

Mar 4 2015, 2:33 PM · Transactions, Wikimedia, Maniphest
epriestley triaged T7448: WebSocket error occurs when navigating phabricator pages as Wishlist priority.
Mar 4 2015, 2:31 PM · Firefox, Notifications
epriestley added a comment to T6887: Emails sent for historical commits when importing repo to Diffusion.

See additional discussion in T6516. This is not fixed until D11964. The root issue is a discrepancy between the web and Conduit workflows which I missed until it did bad things.

Mar 4 2015, 2:27 PM · Wikimedia, Audit, Diffusion
epriestley added a comment to T6516: Diffusion pings accidentally tasks because the same task numbers are mentioned in cloned commit messages .

Those two patches should generally prevent problems here. With those applied, the behavior would have been:

Mar 4 2015, 2:24 PM · Wikimedia, Diffusion
epriestley added a revision to T6516: Diffusion pings accidentally tasks because the same task numbers are mentioned in cloned commit messages : Unknown Object (Differential Revision).
Mar 4 2015, 2:16 PM · Wikimedia, Diffusion
epriestley closed T7455: Add DifferentialDiffTransactionQuery class as Wontfix.

Sorry, we don't build features which are only useful for application development right now because we don't support third-party application development.

Mar 4 2015, 1:00 PM · Differential
epriestley triaged T7454: Longer Maniphest tasks not fully displayed (as Phabricator defines a result set limit as 100 rows) as High priority.
Mar 4 2015, 12:59 PM · Transactions, Wikimedia, Maniphest
epriestley added a revision to T4214: Allow installs to change or supplement the "Phabricator" icon: Unknown Object (Differential Revision).
Mar 4 2015, 12:58 PM · Design
epriestley added a comment to T4214: Allow installs to change or supplement the "Phabricator" icon.

Ah, right, we're using the immutable cache, which is DB-backed. You should be able to clear it with:

Mar 4 2015, 12:55 PM · Design
epriestley added a revision to T6516: Diffusion pings accidentally tasks because the same task numbers are mentioned in cloned commit messages : Unknown Object (Differential Revision).
Mar 4 2015, 12:53 PM · Wikimedia, Diffusion
epriestley added a comment to T6516: Diffusion pings accidentally tasks because the same task numbers are mentioned in cloned commit messages .

Some related discussion in T6887.

Mar 4 2015, 12:46 PM · Wikimedia, Diffusion
epriestley added a comment to T4214: Allow installs to change or supplement the "Phabricator" icon.

cleared php cache

Mar 4 2015, 12:22 PM · Design
epriestley added a revision to T7454: Longer Maniphest tasks not fully displayed (as Phabricator defines a result set limit as 100 rows): Unknown Object (Differential Revision).
Mar 4 2015, 12:19 PM · Transactions, Wikimedia, Maniphest
epriestley added a comment to T7454: Longer Maniphest tasks not fully displayed (as Phabricator defines a result set limit as 100 rows).

Specifically, the repro is:

Mar 4 2015, 12:17 PM · Transactions, Wikimedia, Maniphest
epriestley added a comment to T7449: Support ANSI escaped color sequences in Paste.

Cool, that makes sense. I think the way forward here is:

Mar 4 2015, 3:07 AM · Paste
epriestley renamed T7449: Support ANSI escaped color sequences in Paste from Support ANSI escaped color sequences in diffusion to Support ANSI escaped color sequences in Paste.
Mar 4 2015, 3:04 AM · Paste
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

One general note here is that we (the upstream) are unsure how valuable this is as a feature. In particular, although we use Differential heavily, it isn't a feature which any of us have ever felt much of a desire for, which is part of the reason why it hasn't been built yet. (I also did not feel much need for this feature at Facebook.) Speaking broadly, we haven't experienced very much difficulty tracking inlines across updates.

Mar 4 2015, 1:26 AM · Prioritized, Differential

Mar 3 2015

epriestley renamed T7449: Support ANSI escaped color sequences in Paste from [feature request] Support ANSI escaped color sequences in diffusion to Support ANSI escaped color sequences in diffusion.
Mar 3 2015, 11:50 PM · Paste
epriestley added a comment to T7449: Support ANSI escaped color sequences in Paste.

To clarify, you're checking files which contain ANSI color sequences into a repository, and then viewing them in the repository browser in Diffusion?

Mar 3 2015, 11:50 PM · Paste
epriestley added a comment to T7448: WebSocket error occurs when navigating phabricator pages.

At least at one point in time, registering anything on beforeunload would disable the "bfcache":

Mar 3 2015, 11:46 PM · Firefox, Notifications
epriestley added a parent task for T1460: Add "Done" link to an inline comment: T7447: Bring inline comments forward across revision updates.
Mar 3 2015, 10:31 PM · User Delight, Differential
epriestley added subtasks for T7447: Bring inline comments forward across revision updates: T1460: Add "Done" link to an inline comment, T4999: Inline comments say they are "Not Visible" when they are., T3669: Make it easier to remember to submit inline comments when updating a diff, T6464: Deleting a pending inline comment from the preview at the bottom doesn't remove it inline, T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Mar 3 2015, 10:31 PM · Prioritized, Differential
epriestley added a parent task for T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity: T7447: Bring inline comments forward across revision updates.
Mar 3 2015, 10:31 PM · Differential
epriestley added a parent task for T4999: Inline comments say they are "Not Visible" when they are.: T7447: Bring inline comments forward across revision updates.
Mar 3 2015, 10:31 PM · Differential
epriestley added a parent task for T3669: Make it easier to remember to submit inline comments when updating a diff: T7447: Bring inline comments forward across revision updates.
Mar 3 2015, 10:31 PM · Design, Differential
epriestley added a parent task for T6464: Deleting a pending inline comment from the preview at the bottom doesn't remove it inline: T7447: Bring inline comments forward across revision updates.
Mar 3 2015, 10:31 PM · Differential
epriestley created T7447: Bring inline comments forward across revision updates.
Mar 3 2015, 10:30 PM · Prioritized, Differential
epriestley added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

Ah, that's helpful. I think we explicitly set the response code to 500, so the 200 is the surprising/unexpected behavior. That should be enough for me to figure out what's going on here, thanks!

Mar 3 2015, 9:31 PM · Maniphest
epriestley added a comment to T7446: When a revision requires a CLA, hide the text of the diff.

The other reason not to hide the revision as a whole is to avoid dead-ending the revision: it's desirable for us to be able to discuss the change and the need for the CLA with the author.

Mar 3 2015, 9:12 PM · Differential
epriestley created T7446: When a revision requires a CLA, hide the text of the diff.
Mar 3 2015, 9:11 PM · Differential
epriestley edited the content of Roadmap.
Mar 3 2015, 8:56 PM
epriestley edited the content of Phacility Cluster Repositories.
Mar 3 2015, 8:54 PM
epriestley added a comment to T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed.

(Or @joshuaspence, I suppose.)

Mar 3 2015, 8:49 PM · Maniphest
epriestley reassigned T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed from joshuaspence to btrahan.

@btrahan, @mpalmer isn't comfortable signing the CLA, and I've looked at D11949. In the interest of propriety, can you fix this without looking at D11949 when you have a chance?

Mar 3 2015, 8:44 PM · Maniphest
epriestley added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

If it's not too hard, it would likely be helpful.

Mar 3 2015, 8:35 PM · Maniphest
epriestley added a comment to T7443: Include full link to Maniphest tasks in commit messages.

I think that's the one.

Mar 3 2015, 8:31 PM · Diffusion, Arcanist
epriestley added a parent task for T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does): T7443: Include full link to Maniphest tasks in commit messages.
Mar 3 2015, 8:31 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Wikimedia, Remarkup
epriestley added a subtask for T7443: Include full link to Maniphest tasks in commit messages: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
Mar 3 2015, 8:31 PM · Diffusion, Arcanist
epriestley added a comment to T7444: Code block header styling.

I had similar feedback on the original diff I think -- I think this one looks a lot better, but we did lose the sense that the title is visually tied to the code block and is a label for the block content.

Mar 3 2015, 8:07 PM · Design, Remarkup
epriestley added a comment to T7443: Include full link to Maniphest tasks in commit messages.

One minor note, but we've also seen feedback in the other direction, where users want to drop the URL.

Mar 3 2015, 8:02 PM · Diffusion, Arcanist
epriestley added a comment to T7444: Code block header styling.
asdf
qwer
Mar 3 2015, 8:01 PM · Design, Remarkup
qgil awarded T7436: Editing project description should leave a diff of the change made a Yellow Medal token.
Mar 3 2015, 7:28 PM · Custom Fields, Projects
epriestley updated the task description for T7441: Support OAuth providers in the cluster.
Mar 3 2015, 7:25 PM · Auth, Phacility
epriestley created T7441: Support OAuth providers in the cluster.
Mar 3 2015, 7:10 PM · Auth, Phacility
epriestley closed T7438: Move Conpherence threads to the "Z" monogram to free up "E" for events, a subtask of T5364: Conpherence v2 (Original Discussion), as Resolved.
Mar 3 2015, 6:40 PM · Conpherence
epriestley closed T7438: Move Conpherence threads to the "Z" monogram to free up "E" for events as Resolved by committing Restricted Diffusion Commit.
Mar 3 2015, 6:40 PM · Conpherence
epriestley closed T6724: Conduit allows non-users to be added to Conpherences as Resolved by committing Restricted Diffusion Commit.
Mar 3 2015, 6:40 PM · Conpherence
epriestley closed T6724: Conduit allows non-users to be added to Conpherences, a subtask of T5364: Conpherence v2 (Original Discussion), as Resolved.
Mar 3 2015, 6:40 PM · Conpherence
epriestley closed T6818: Don't match ")" in hashtags in Remarkup as Resolved by committing Restricted Diffusion Commit.
Mar 3 2015, 6:39 PM · Guides, Remarkup
epriestley closed T7102: Dashboards mishandle Phortune Charges as Resolved by committing Restricted Diffusion Commit.
Mar 3 2015, 6:39 PM · Dashboards, Phortune
epriestley closed T7436: Editing project description should leave a diff of the change made as Resolved by committing Restricted Diffusion Commit.
Mar 3 2015, 6:39 PM · Custom Fields, Projects
epriestley added a revision to T7439: Remove "E" backward compatibility from Conpherence once Calendar is closer to launch: Unknown Object (Differential Revision).
Mar 3 2015, 1:03 PM · Calendar, Conpherence
epriestley added a revision to T7438: Move Conpherence threads to the "Z" monogram to free up "E" for events: Unknown Object (Differential Revision).
Mar 3 2015, 1:03 PM · Conpherence
epriestley created T7439: Remove "E" backward compatibility from Conpherence once Calendar is closer to launch.
Mar 3 2015, 1:02 PM · Calendar, Conpherence
epriestley created T7438: Move Conpherence threads to the "Z" monogram to free up "E" for events.
Mar 3 2015, 12:57 PM · Conpherence
epriestley edited the content of Object Name Prefixes / Monograms.
Mar 3 2015, 12:50 PM
epriestley added a revision to T6724: Conduit allows non-users to be added to Conpherences: Unknown Object (Differential Revision).
Mar 3 2015, 12:42 PM · Conpherence
epriestley added a comment to T6453: MySQL warnings after storage adjustment.

I think this warning is incorrect (i.e., the statement is not actually unsafe, because the autoincrement primary key can never collide).

Mar 3 2015, 12:16 PM · Database
epriestley added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

Hrrm, I'm having a hard time reproducing this and don't immediately see anything in the code which could cause us to drop the dialog.

Mar 3 2015, 12:03 PM · Maniphest
epriestley added a subtask for T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog: T7437: Test Dependency.
Mar 3 2015, 12:01 PM · Maniphest
epriestley added a parent task for T7437: Test Dependency: T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.
Mar 3 2015, 12:01 PM · Maniphest
epriestley created T7437: Test Dependency.
Mar 3 2015, 12:01 PM · Maniphest
epriestley added a revision to T6818: Don't match ")" in hashtags in Remarkup: Unknown Object (Differential Revision).
Mar 3 2015, 11:55 AM · Guides, Remarkup
epriestley closed T6887: Emails sent for historical commits when importing repo to Diffusion as Resolved.

I believe this was fixed by rP8599145 and rPf6915a7. Specifically:

Mar 3 2015, 11:44 AM · Wikimedia, Audit, Diffusion
epriestley added a comment to T7412: Allow a project to have multiple `arclint` files.

I merged T7037 and T6908 here because they both deal (approximately) with templating .arclint files, and we're definitely not doing the magic approaches in T6908 where some linters get to ignore global excludes.

Mar 3 2015, 11:35 AM · Lint
epriestley merged task T6908: Run chmod linter on global excludes into T7412: Allow a project to have multiple `arclint` files.
Mar 3 2015, 11:30 AM · Lint
epriestley updated subscribers of T7412: Allow a project to have multiple `arclint` files.
Mar 3 2015, 11:30 AM · Lint
epriestley merged task T7037: Allow `.arclint` files to be templated into T7412: Allow a project to have multiple `arclint` files.
Mar 3 2015, 11:30 AM · Lint
epriestley closed T6990: Filenames downloaded get mangled when not latin based as Resolved by committing Restricted Diffusion Commit.
Mar 3 2015, 11:27 AM · Files
epriestley added a comment to T7005: Find somewhat simple way to have Phriction be a part of new Projects layout.

Assuming things don't change up too much, maybe something like:

Mar 3 2015, 11:26 AM · FreeBSD, Phriction, Projects
epriestley added a comment to T7004: Don't send email whilst online.

Technically speaking:

Mar 3 2015, 11:23 AM · Notifications, Mail
epriestley added a parent task for T5791: Write Herald rules for outbound mail: T7004: Don't send email whilst online.
Mar 3 2015, 11:15 AM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley added a subtask for T7004: Don't send email whilst online: T5791: Write Herald rules for outbound mail.
Mar 3 2015, 11:15 AM · Notifications, Mail
epriestley added a parent task for T6868: Show when users are online or offline in Conpherence: T7004: Don't send email whilst online.
Mar 3 2015, 11:15 AM · Conpherence
epriestley added a subtask for T7004: Don't send email whilst online: T6868: Show when users are online or offline in Conpherence.
Mar 3 2015, 11:15 AM · Notifications, Mail
epriestley renamed T6868: Show when users are online or offline in Conpherence from Add Connection information to Participants to Show when users are online or offline.
Mar 3 2015, 11:15 AM · Conpherence
epriestley closed T7044: Discrepancy between 'bin/storage databases' and 'bin/storage destroy' as Invalid.

We can't reproduce this.

Mar 3 2015, 11:09 AM · Database
epriestley added a comment to T7053: Restart daemons automagically.

This is more possible after the centralization of the overseer and the introduction of phd reload and the SIGHUP handling. Specifically, we could do this:

Mar 3 2015, 11:05 AM · Daemons
epriestley added a revision to T7102: Dashboards mishandle Phortune Charges: Unknown Object (Differential Revision).
Mar 3 2015, 10:54 AM · Dashboards, Phortune
epriestley claimed T7436: Editing project description should leave a diff of the change made.
Mar 3 2015, 10:39 AM · Custom Fields, Projects
epriestley added a revision to T7436: Editing project description should leave a diff of the change made: Unknown Object (Differential Revision).
Mar 3 2015, 10:39 AM · Custom Fields, Projects
qgil awarded T6940: Write a blog post a Like token.
Mar 3 2015, 6:56 AM · Phacility
epriestley closed T6965: Disambiguate and provide better examples for "NOTE:" syntax in Remarkup documentation as Resolved by committing Restricted Diffusion Commit.
Mar 3 2015, 2:17 AM · Documentation, Remarkup
epriestley closed T6272: Unable to edit comment in Differential when Inlines are attached as Resolved.

Doesn't reproduce at HEAD.

Mar 3 2015, 2:07 AM · Transactions, Differential
epriestley closed T6402: {Fxxx, layout=inline} doesn't actually layout inline with an image as Resolved.

This was resolved by D11706.

Mar 3 2015, 2:03 AM · Remarkup