Maniphest T4105

Undefined index in DifferentialHunkParser
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	lifeihuang
	Nov 15 2013, 1:24 AM

Tags

Referenced Files

None

Subscribers

View All 9 Subscribers

Description

We started seeing these recently.

ERROR 8: Undefined index: 50 at [/var/devtools/phabricator/src/applications/differential/parser/DifferentialHunkParser.php:120]

#0 DifferentialHunkParser::setNewLineTypeMap(Array of size 49 starting with: { 1 => null }) called at [/var/devtools/phabricator/src/applications/differential/parser/DifferentialChangesetParser.php:543]

ERROR 8: Undefined index: 51 at [/var/devtools/phabricator/src/applications/differential/parser/DifferentialHunkParser.php:99]

#0 DifferentialHunkParser::setOldLineTypeMap(Array of size 50 starting with: { 1 => null }) called at [/var/devtools/phabricator/src/applications/differential/parser/DifferentialChangesetParser.php:542]

Revisions and Commits

rP Phabricator
	D11970	rPc82066408d1b Expand Differential test coverage to include moves, shields, and more

Related Objects

Duplicates Merged Here: T5163: User hitting undefined index in changeset rendering

Event Timeline

lifeihuang created this task.Nov 15 2013, 1:24 AM

lifeihuang assigned this task to epriestley.

lifeihuang raised the priority of this task from to Needs Triage.

lifeihuang updated the task description. (Show Details)

lifeihuang added a project: Facebook.

lifeihuang changed the visibility from "Public (No Login Required)" to "Custom Policy".

lifeihuang added a subscriber: lifeihuang.

Those lines don't correspond to anything index-ish at HEAD. What commit are those lines against?

(I set the policy on this back to "Public" since I think you locked yourself out of it.)

Closing for lack of feedback.

@hach-que hit this near HEAD, P1198 has a trace.

chad edited projects, added Differential; removed Facebook.Nov 2 2014, 11:03 PM

epriestley moved this task from Backlog to v2 (UI/Mobile) on the Differential board.Mar 4 2015, 5:11 PM

epriestley added a revision: D11970: Expand Differential test coverage to include moves, shields, and more.Mar 5 2015, 2:06 AM

epriestley merged a task: T5163: User hitting undefined index in changeset rendering.

epriestley added subscribers: staticshock, turadg, cburroughs and 2 others.

epriestley closed this task as Resolved by committing rPc82066408d1b: Expand Differential test coverage to include moves, shields, and more.Mar 5 2015, 10:00 PM

epriestley added a commit: rPc82066408d1b: Expand Differential test coverage to include moves, shields, and more.