Page MenuHomePhabricator

{Fxxx, layout=inline} doesn't actually layout inline with an image
Closed, ResolvedPublic

Description

Text after the image is laid out on the same line, but text before gets its own <p>.

e.g.:

> one two {F226257, size=full, layout=inline} three four

produces:

one two black_mage.gif (80×80 px, 2 KB) three four

Event Timeline

nornagon raised the priority of this task from to Needs Triage.
nornagon updated the task description. (Show Details)
nornagon updated the task description. (Show Details)
nornagon added a subscriber: nornagon.
btrahan added a project: Remarkup.

This reproduces with something as simple as

one two black_mage.gif (80×80 px, 2 KB) three four

also worth noting this shows the error too:

one two black_mage.gif (80×80 px, 2 KB) three four

Took a quick look in case it was a simple fix but this is a bit hairy; the "one two" is sort of part of the problem, as for this to work the whole line needs to be inside the <p> tag and in this code path it ends. PhabricatorEmbedFileRemarkupRule is the pertinent class name and renderImageFile is the method that's going to need some work, plus whatever higher level stuff for the "one two" bit.

epriestley claimed this task.
epriestley added a subscriber: epriestley.

This was resolved by D11706.