Page MenuHomePhabricator

mpalmer (Matt Palmer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 26 2015, 10:59 PM (216 w, 2 d)
Availability
Available

Recent Activity

Mar 30 2015

mpalmer created T7704: Rejecting then accepting a revision with blocking reviewers doesn't correctly change state.
Mar 30 2015, 10:56 PM · Restricted Project, Differential
mpalmer abandoned D11949: Correctly detect tasks which are blocked or not.
Mar 30 2015, 10:49 PM · Maniphest

Mar 3 2015

mpalmer added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

The caffeine's finally kicked in, and I realised I could just ask Chrome to show me what both sites were doing differently...

Mar 3 2015, 9:29 PM · Maniphest
mpalmer added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

If it's not too hard, it would likely be helpful.

Mar 3 2015, 8:49 PM · Maniphest
mpalmer added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

I get the dialog on this installation. However, try as I might, I can't get it to pop up on ours. Same browser, settings, etc. Would a capture of the HTTP traffic on my install help to narrow down whether the problem is in the PHP code not reporting the error correctly, or the client-side JS not handling it correctly?

Mar 3 2015, 8:22 PM · Maniphest
mpalmer added a comment to D11949: Correctly detect tasks which are blocked or not.

I'm sorry, I don't sign CLAs.

Mar 3 2015, 8:11 PM · Maniphest
mpalmer reopened T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed as "Open".

I dug in, and the attached diff is what I came up with. The problem was that by left joining with the IN ('open','inprogress') condition, you're not excluding any rows from the result set, you're just leaving all the values NULL. It's the WHERE that has to be modified, so that the rows don't get end up in the result set. I could have modified the join (to not filter on status) and then change the WHERE to check status IN ('open','inprogress'), but this seemed like the least invasive change.

Mar 3 2015, 9:00 AM · Maniphest
mpalmer added a revision to T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed: D11949: Correctly detect tasks which are blocked or not.
Mar 3 2015, 8:55 AM · Maniphest
mpalmer added a task to D11949: Correctly detect tasks which are blocked or not: T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed.
Mar 3 2015, 8:55 AM · Maniphest
mpalmer retitled D11949: Correctly detect tasks which are blocked or not from to Correctly detect tasks which are blocked or not.
Mar 3 2015, 8:55 AM · Maniphest
mpalmer added a comment to T7434: "Show Tasks Not Blocked By Other Tasks" now never returns any results.

Things are definitely looking better! I'm getting some of my all-closed-blocking-tasks tasks in my "Show Tasks Not Blocked By Other Tasks" search results. However, at least one task that I think should be found isn't being found (it's being shown in the "Show Tasks Blocked By Other Tasks" search, instead) even though all of the blocking tasks look done. Since I've got no idea what the difference is yet, I don't have a reproduction case for you. I'm going to dig into the query and debug what's going wrong. I'll let you know what I find.

Mar 3 2015, 5:20 AM
mpalmer reopened T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog as "Open".

I'm still getting the blank, greyed-over screen, running on d866af3. The exception message is improved, but it's still only showing up in the logs:

Mar 3 2015, 3:20 AM · Maniphest
mpalmer created T7434: "Show Tasks Not Blocked By Other Tasks" now never returns any results.
Mar 3 2015, 12:52 AM
mpalmer added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

Just upgraded to e5e3eb3 and the problem still persists. Same UI, and the log message looks much the same to me:

Mar 3 2015, 12:36 AM · Maniphest

Mar 2 2015

mpalmer added a comment to T6815: Creating a cyclic task dependency in Maniphest no longer produces a nice error dialog.

Running on 18340d9 here; I'll be upgrading in the next couple of hours to master to fix T7421 if you'd like a retest. Looking at T6692, though, it looks like that was fixed back in Jan.

Mar 2 2015, 11:16 PM · Maniphest
mpalmer created T7433: Creating tasks with circular dependencies does not produce a useful error message.
Mar 2 2015, 10:52 PM · Maniphest
mpalmer created T7421: "Column 'status' in where clause is ambiguous" error when attempting to search for unblocked tasks.
Mar 2 2015, 8:26 AM · Maniphest

Feb 27 2015

mpalmer added a comment to T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed.

@chad, yes, I've just confirmed that the maniphest "Advanced Search" form also behaves in the same manner.

Feb 27 2015, 2:39 AM · Maniphest
mpalmer updated the task description for T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed.
Feb 27 2015, 12:43 AM · Maniphest
mpalmer added a comment to T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed.

Oh balls. All that care and attention to get the description right, and then I go and make a n00b mistake. Thanks for the catch, @hach-que.

Feb 27 2015, 12:42 AM · Maniphest
mpalmer updated the task description for T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed.
Feb 27 2015, 12:42 AM · Maniphest

Feb 26 2015

mpalmer created T7392: Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed.
Feb 26 2015, 11:05 PM · Maniphest