Page MenuHomePhabricator
Create Task
Maniphest T7392

Custom filter condition "Show Tasks Not Blocked By Other Tasks" does not show tasks whose blocked tasks are all completed
Closed, ResolvedPublic
Actions

Description

(Report as requested by @epriestley on IRC)

I have a workboard which contains three open tasks:

  • T1 has no tasks listed under "Blocked By";
  • T2 has an open task listed under "Blocked By";
  • T3 has a resolved task listed under "Blocked By".

I select "Custom Filter", and choose "Show Tasks Not Blocked By Other Tasks" from the "Blocked" select box.

The workboard now only shows T1.

I expect the workboard to show T1, because that task cannot be blocked, and I also expect the workboard to show T3, because that task's blocking task has been closed, and hence T3 is no longer blocked from completion.

Revisions and Commits

rP Phabricator
AbandonedD11949 Correctly detect tasks which are blocked or not
D11962rP05510aa41f44 Maniphest - fix blocking / blocked task queries
D11911rP130aa755bb0e Exclude closed tasks from blocked/blocking filter

Related Objects

Event Timeline

mpalmer created this task.Feb 26 2015, 11:05 PM
mpalmer raised the priority of this task from to Needs Triage.
mpalmer updated the task description. (Show Details)
mpalmer added a project: Maniphest.
mpalmer added subscribers: mpalmer, epriestley.
hach-que added a subscriber: hach-que.Feb 27 2015, 12:09 AM

You mean T3 right? T2 has an open task under Blocked By according to the scenario you stated.

joshuaspence added a subscriber: joshuaspence.Feb 27 2015, 12:24 AM
mpalmer updated the task description. (Show Details)Feb 27 2015, 12:42 AM

Oh balls. All that care and attention to get the description right, and then I go and make a n00b mistake. Thanks for the catch, @hach-que.

mpalmer updated the task description. (Show Details)Feb 27 2015, 12:43 AM
chad added a subscriber: chad.Feb 27 2015, 1:14 AM

I assume that ApplicationSearch in Maniphest also gets this wrong?

mpalmer added a comment.Feb 27 2015, 2:39 AM

@chad, yes, I've just confirmed that the maniphest "Advanced Search" form also behaves in the same manner.

joshuaspence claimed this task.Feb 28 2015, 12:02 PM
joshuaspence added a revision: D11911: Exclude closed tasks from blocked/blocking filter.Feb 28 2015, 12:05 PM
joshuaspence closed this task as Resolved by committing rP130aa755bb0e: Exclude closed tasks from blocked/blocking filter.Feb 28 2015, 10:41 PM
joshuaspence added a commit: rP130aa755bb0e: Exclude closed tasks from blocked/blocking filter.
mpalmer mentioned this in T7421: "Column 'status' in where clause is ambiguous" error when attempting to search for unblocked tasks.Mar 2 2015, 8:26 AM
mpalmer mentioned this in T7434: "Show Tasks Not Blocked By Other Tasks" now never returns any results.Mar 3 2015, 12:52 AM
mpalmer added a revision: D11949: Correctly detect tasks which are blocked or not.Mar 3 2015, 8:55 AM
mpalmer reopened this task as Open.Mar 3 2015, 9:00 AM

I dug in, and the attached diff is what I came up with. The problem was that by left joining with the IN ('open','inprogress') condition, you're not excluding any rows from the result set, you're just leaving all the values NULL. It's the WHERE that has to be modified, so that the rows don't get end up in the result set. I could have modified the join (to not filter on status) and then change the WHERE to check status IN ('open','inprogress'), but this seemed like the least invasive change.

epriestley reassigned this task from joshuaspence to btrahan.Mar 3 2015, 8:44 PM
epriestley added a subscriber: btrahan.

@btrahan, @mpalmer isn't comfortable signing the CLA, and I've looked at D11949. In the interest of propriety, can you fix this without looking at D11949 when you have a chance?

epriestley added a comment.Mar 3 2015, 8:49 PM

(Or @joshuaspence, I suppose.)

joshuaspence added a comment.Mar 3 2015, 8:51 PM

I have also looked at D11949.

epriestley mentioned this in T7446: When a revision requires a CLA, hide the text of the diff.Mar 3 2015, 9:11 PM
btrahan added a revision: D11962: Maniphest - fix blocking / blocked task queries.Mar 3 2015, 11:14 PM
btrahan closed this task as Resolved by committing rP05510aa41f44: Maniphest - fix blocking / blocked task queries.Mar 3 2015, 11:53 PM
btrahan added a commit: rP05510aa41f44: Maniphest - fix blocking / blocked task queries.
Phabricator · Built by Phacility