Page MenuHomePhabricator
Feed Advanced Search

Aug 30 2017

epriestley added a comment to T9846: Diff on `arc lint` misleading when the replacement has newlines.

See also PHI48.

Aug 30 2017, 8:27 PM · Restricted Project, Arcanist, Lint
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

A prototype of this is now available on this server (secure.phabricator.com). You can access it in Maniphest by using the Query (Prototype) field instead of the Contains Words field.

Aug 30 2017, 7:49 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 30 2017, 5:13 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 30 2017, 4:55 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 30 2017, 4:29 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 30 2017, 3:40 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 30 2017, 2:40 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 30 2017, 2:11 PM · Restricted Project, Search
cguenther awarded T4721: Improve user-facing documentation for Passphrase a Like token.
Aug 30 2017, 6:43 AM · Documentation, Passphrase

Aug 29 2017

epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 29 2017, 7:45 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 29 2017, 6:40 PM · Restricted Project, Search
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Aug 29 2017, 4:55 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Aug 28 2017

epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 28 2017, 10:41 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Aug 28 2017, 9:35 PM · Restricted Project, Search
epriestley added a revision to T12443: Applying fulltext limits first causes missing results: Unknown Object (Differential Revision).
Aug 28 2017, 9:35 PM · Restricted Project, Search, Bug Report
epriestley closed T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes, a subtask of T12101: Phabricator PHP 7 Compatibility, as Resolved.
Aug 28 2017, 7:25 PM · Infrastructure, Guides
epriestley closed T12855: In PHP7, "Throwable" and "Error" are exciting new exception classes as Resolved.

I think there will be a trickle of these for a while, but we seem to have found the most common cases.

Aug 28 2017, 7:25 PM · Infrastructure
epriestley closed T12891: Phacility does not currently offer instances in the Sydney region as Invalid.

We'll consider offering instances in the Sydney region in the future, but this isn't really a valid feature request or bug report. Feel free to continue discussion on Discourse.

Aug 28 2017, 7:24 PM · Feature Request
epriestley closed T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu as Resolved.

This is now in the wild, and nothing seems to have cropped up yet.

Aug 28 2017, 7:21 PM · ApplicationSearch

Aug 27 2017

avivey awarded T12963: Aggregate similar stories in Feed, Notifications and Timelines a 100 token.
Aug 27 2017, 8:03 PM · Transactions
epriestley added a comment to T12972: Ignoring missing version information on binaries doesn't seem to work.

The behavior may have changed, but the change is from "we sometimes silently do the wrong thing" to "we explicitly refuse to do the wrong thing".

Aug 27 2017, 5:26 PM · Mercurial, Diffusion
epriestley added a comment to T12972: Ignoring missing version information on binaries doesn't seem to work.

That is, specifically, it expected that hg commands do not work in Phabricator if it can not determine the version of hg, so this is not a bug. Ignoring the setup warning might mean "we used to do Mercurial stuff but don't anymore, leaving us with some archived Mercurial repositories which we don't really need to look at, so it's okay that hg commands won't be able to run".

Aug 27 2017, 4:03 PM · Mercurial, Diffusion
epriestley added a comment to T12972: Ignoring missing version information on binaries doesn't seem to work.

The version is strictly required because different versions of hg use different command syntax. If we can not determine which version of hg is installed, we can not run hg commands.

Aug 27 2017, 4:01 PM · Mercurial, Diffusion

Aug 25 2017

epriestley edited the content of Changelog.
Aug 25 2017, 6:28 PM
epriestley renamed 2017 Week 33 (Later Mid August) from 2017 Week 33 (Mid August) to 2017 Week 33 (Later Mid August).
Aug 25 2017, 6:28 PM
epriestley created 2017 Week 34 (Late August).
Aug 25 2017, 6:27 PM
epriestley closed T6338: Use default ca path of curl if not defined otherwise as Wontfix.

We haven't seen other users encounter this issue in several years.

Aug 25 2017, 2:46 PM · libphutil
epriestley closed T5976: Handle the awful CLIXML output from Powershell on Windows as Wontfix.

No current plans to ever pursue this.

Aug 25 2017, 2:45 PM · libphutil, Harbormaster
epriestley closed T5656: Add "Create Similar Rule..." to Herald as Wontfix.

Herald rules are now always public, which possibly addresses the original issue.

Aug 25 2017, 2:42 PM · Restricted Project, Herald
epriestley closed T3999: Support Harvest integration for Phrequent via Doorkeeper as Wontfix.

We haven't seen more interest in this in several years.

Aug 25 2017, 2:41 PM · Doorkeeper, Phrequent
epriestley closed T4598: Arcanist Asterisk Display with PuTTY as Invalid.

This doesn't sound like a Phabricator problem.

Aug 25 2017, 2:39 PM · Arcanist
epriestley closed T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges as Resolved.

I'm going to call this effectively resolved:

Aug 25 2017, 2:30 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley closed T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges, a subtask of T1394: Support creating audits with inline comments through the API, as Resolved.
Aug 25 2017, 2:29 PM · Conduit, Harbormaster, Audit
shandor awarded T7930: Let Calendar provide date services to other applications a Party Time token.
Aug 25 2017, 11:24 AM · Calendar

Aug 24 2017

epriestley added a comment to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.

I'm pushing this here, yell if all your queries explode or what-have-ye.

Aug 24 2017, 10:29 PM · ApplicationSearch
epriestley closed T12970: Differential HTML document anchors for changesets and comments may collide as Resolved by committing Restricted Diffusion Commit.
Aug 24 2017, 10:25 PM · Differential
epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Unknown Object (Differential Revision).
Aug 24 2017, 10:19 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Unknown Object (Differential Revision).
Aug 24 2017, 9:51 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: Unknown Object (Differential Revision).
Aug 24 2017, 9:20 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T12970: Differential HTML document anchors for changesets and comments may collide: Unknown Object (Differential Revision).
Aug 24 2017, 8:40 PM · Differential
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: Unknown Object (Differential Revision).
Aug 24 2017, 8:19 PM · ApplicationSearch
epriestley added a comment to T823: Add image support to Diviner.

I'd guess it's several days of work.

Aug 24 2017, 2:21 PM · Diviner
epriestley added a comment to T7789: Support Git Large File Storage.

See Planning for information on planning and timelines.

Aug 24 2017, 12:41 PM · Customer Impact, Restricted Project, Files, Diffusion

Aug 23 2017

epriestley added a comment to T12970: Differential HTML document anchors for changesets and comments may collide.

One caveat about this is that it gets dicey if we implement T4280, since user-specified anchors could look like anything and could collide with anything. But we can cross that bridge when we come to it. This is an issue in general anyway, since two users can make comments with the exact same anchor in them.

Aug 23 2017, 9:52 PM · Differential
epriestley added a revision to T12970: Differential HTML document anchors for changesets and comments may collide: Unknown Object (Differential Revision).
Aug 23 2017, 9:48 PM · Differential
epriestley created T12970: Differential HTML document anchors for changesets and comments may collide.
Aug 23 2017, 9:43 PM · Differential
epriestley added a comment to T11030: Cannot clone public repository over HTTP anonymously..

If you believe you've found a bug in Phabricator, please follow the instructions in Contributing Bug Reports to file a report.

Aug 23 2017, 6:01 PM · Diffusion, Bug Report

Aug 22 2017

epriestley edited the content of Changelog.
Aug 22 2017, 10:32 PM
epriestley created 2017 Week 33 (Later Mid August).
Aug 22 2017, 10:31 PM
epriestley added a comment to T12011: Support builds with Travis CI.

See also PHI41.

Aug 22 2017, 4:50 PM · Harbormaster, Feature Request

Aug 21 2017

robertos awarded T6703: Allow multiple copies of the same auth provider type a Like token.
Aug 21 2017, 10:08 PM · Auth
epriestley added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Did you consider increasing the "tablet" breakpoint above the size of an 11" macbook instead?

Aug 21 2017, 8:45 PM · Diffusion, Design

Aug 17 2017

epriestley added a revision to T12966: Phabricator should survive a restart and setup checks with an unreachable master: Unknown Object (Differential Revision).
Aug 17 2017, 6:35 PM · Clusters
epriestley updated the task description for T12966: Phabricator should survive a restart and setup checks with an unreachable master.
Aug 17 2017, 6:17 PM · Clusters
epriestley added a parent task for T12966: Phabricator should survive a restart and setup checks with an unreachable master: T10769: Read-Only Mode Errata.
Aug 17 2017, 6:15 PM · Clusters
epriestley added a subtask for T10769: Read-Only Mode Errata: T12966: Phabricator should survive a restart and setup checks with an unreachable master.
Aug 17 2017, 6:15 PM · Clusters
epriestley created T12966: Phabricator should survive a restart and setup checks with an unreachable master.
Aug 17 2017, 6:15 PM · Clusters
epriestley added a revision to T12965: When no "master" database is configured, the ElasticSearch setup check can fatal: Unknown Object (Differential Revision).
Aug 17 2017, 4:53 PM · Database, Clusters, Search
epriestley created T12965: When no "master" database is configured, the ElasticSearch setup check can fatal.
Aug 17 2017, 4:41 PM · Database, Clusters, Search

Aug 16 2017

epriestley added a comment to T12838: Make sure "state" is in new Branch view.

Yes. In Mercurial, branch heads may be "Open" or "Closed".

Aug 16 2017, 9:14 PM · Design, Diffusion
epriestley updated the task description for T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 7:01 PM · Transactions
epriestley merged T5891: Add button to notification panel to concatenate notifications on the same objects into T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 6:58 PM · Transactions
epriestley merged task T5891: Add button to notification panel to concatenate notifications on the same objects into T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 6:58 PM · Notifications
epriestley added a comment to T5891: Add button to notification panel to concatenate notifications on the same objects.

I'm going to merge this into T12963, which isn't exactly the same but overlaps this substantially. It's possible we'll pursue a more narrow "vacation review" mode eventually, but we'd want to finish T12963 first and make sure it didn't adequately address this problem on its own.

Aug 16 2017, 6:58 PM · Notifications
epriestley created T12963: Aggregate similar stories in Feed, Notifications and Timelines.
Aug 16 2017, 6:55 PM · Transactions
darkwing awarded T10363: Reorient Doorkeeper publishing around transactions instead of feed stories a Like token.
Aug 16 2017, 5:02 PM · Nuance, Restricted Project, Feed, Doorkeeper
MatanUbe awarded T10350: Scripts to migrate old "points" fields and move projects beneath other projects a Party Time token.
Aug 16 2017, 12:05 PM · Projects (v3)
DominicFrei awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Aug 16 2017, 11:19 AM · Calendar

Aug 15 2017

• tomekj2ee awarded T6072: Improve usability of `arc diff` a Like token.
Aug 15 2017, 10:02 PM · Restricted Project, Documentation, Arcanist
epriestley closed T6861: PHP sort function is unpredictable to human minds when dealing with mixed types as Resolved.

Practically, msortv() and PhutilSortVector are now the solution here. They provide high-performance (no usort*()), multi-dimensional, stable, explicitly typed sort.

Aug 15 2017, 6:17 PM · Infrastructure
epriestley removed a project from T9518: In diff summary linting error code shown instead of message, when PHP_CodeSniffer linter was used: Differential.
Aug 15 2017, 5:59 PM · Lint
epriestley closed T10856: Small Revision page enhanchments as Resolved.

Just sweeping this up, rewriting the property display to show +x seems reasonable to me but I think it's self-evident enough that we don't need to keep a task around for it.

Aug 15 2017, 5:58 PM · Restricted Project, Feature Request, Differential
epriestley closed T11218: Differential advanced search: bucket/group by repository, a subtask of T9287: Working with many repositories, as Wontfix.
Aug 15 2017, 5:56 PM · Restricted Project, Restricted Project, Diffusion
epriestley closed T11218: Differential advanced search: bucket/group by repository as Wontfix.

I don't think this meets the high bar required by modern feature requests (see "Upstreamable Feautures" in Planning).

Aug 15 2017, 5:56 PM · Restricted Project, Differential, Feature Request
epriestley closed T11900: Create bot reviewers that do code analysis and post findings as inline comments. as Wontfix.

(This isn't anything upstream-actionable.)

Aug 15 2017, 5:55 PM · Differential, Feature Request
epriestley moved T12534: Differential still appears in "responsible users" query after resigning as a reviewer from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:54 PM · Bug Report (Needs Information), Differential
epriestley moved T12539: Revision with an older "accept" showed up in "waiting on other reviewers" after "request review" from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:54 PM · Differential
epriestley moved T12689: Mail is still received after resigning from a revision from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:53 PM · Mail, Differential, Bug Report
epriestley closed T12733: (2017 Week 20) Inline Comments Errata / Feedback as Resolved.

This seems to have calmed down.

Aug 15 2017, 5:53 PM · Inline Comments, Installing & Upgrading, Differential
epriestley moved T12920: Retracting requested changes can leave revision in "Needs Revision" state from Backlog to Reviewer Rules on the Differential board.
Aug 15 2017, 5:53 PM · Restricted Project, Differential, Bug Report
epriestley closed T10967: Move Differential reviewers back to a dedicated database storage table as Resolved.

We appear to have survived this. D18398 removed the double writes. There's a bit more cleanup (we could remove the edge type and actually destroy the older data) but that can happen whenever we get around to it.

Aug 15 2017, 5:51 PM · Restricted Project, Infrastructure, Differential
epriestley closed T1084: Preview what's new in a diff when attaching it to an existing revision as Wontfix.

This is five years old, and doesn't meet the requirements of a modern feature request. If you're still interested in this, feel free to start a new discussion on Discourse.

Aug 15 2017, 5:49 PM · Restricted Project, Differential, Arcanist
epriestley closed T8134: There should be a way to quickly navigate between new comments as Wontfix.

This doesn't meet the criteria of a modern feature request and predates significant changes to the inline comment UI. If this is still an issue, feel free to start a new discussion on Discourse.

Aug 15 2017, 5:46 PM · Restricted Project, Differential
epriestley closed T12548: Unable to initialize database with invalid credentials in configuration file as Invalid.

Closing this for lack of feedback, feel free to resurrect it if you get back to it.

Aug 15 2017, 5:34 PM · Database, Bug Report
epriestley closed T12602: Assignees of tasks don't count as subscribers in maniphest search as Invalid.

This isn't a bug; they aren't subscribers, and aren't listed in "Subscribers" in the right-hand column or in "Subscribers" in "Edit Task".

Aug 15 2017, 5:32 PM · Maniphest, Bug Report
epriestley closed T10890: Less chatty Maniphest feed rendering as Wontfix.

I don't think this clearly describes a root problem. PHI33 touches on similar issues, and I'll file something vaguely in this realm if anything comes of that.

Aug 15 2017, 5:19 PM · Maniphest, Feature Request

Aug 14 2017

epriestley added a comment to T12962: Unable to review instance billing information on `admin.phacility.com`.

I just clicked through it, I don't think there's any reason for staff to be there normally.

Aug 14 2017, 10:39 PM · Phacility
epriestley assigned T12962: Unable to review instance billing information on `admin.phacility.com` to chad.
Aug 14 2017, 10:03 PM · Phacility
epriestley created T12962: Unable to review instance billing information on `admin.phacility.com`.
Aug 14 2017, 10:01 PM · Phacility
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: Unknown Object (Differential Revision).
Aug 14 2017, 8:15 PM · ApplicationSearch
epriestley closed T12961: [CVE-2017-1000117, et al] Git, Mercurial and Subversion could all execute arbitrary commands when interacting with malicious SSH URIs (`ssh://-...`) as Resolved.

There doesn't seem to be anything actionable remaining on our end.

Aug 14 2017, 8:07 PM · Subversion, Mercurial, Git, Security
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: Unknown Object (Differential Revision).
Aug 14 2017, 6:13 PM · ApplicationSearch
epriestley added a comment to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.

We still get a tiny mess where administrators clicking "pin" might mean "pin by default for all users" or "pin by default for just me" but that's reasonable to clarify in the workflow.

Aug 14 2017, 4:58 PM · ApplicationSearch
epriestley added a comment to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu.

Currently, users may hide or reorder builtin queries. With the simplest version of the plan above, users will lose that ability: builtin queries will always be visible (unless hidden by an administrator) and always at the bottom of the list.

Aug 14 2017, 4:30 PM · ApplicationSearch
epriestley added a comment to T5963: Hosted repos could set default branch in HEAD to help new clones.

@aubort, please use the community forum (see: Discourse) if you'd like to discuss this issue.

Aug 14 2017, 4:05 PM · Diffusion
epriestley added a comment to T12742: `arc land` shows only part of the error that causes the final squash to fail.

@aleb, if you like to continue discussion of this please use the appropriate channels, as @chad suggested above (at the time, they were Conpherence and Ponder, but the appropriate channel is now the community forum -- see: Discourse).

Aug 14 2017, 4:04 PM · Bug Report
epriestley added a revision to T12956: Upgrade saved queries in ApplicationSearch to use a "personal" + "global/default" model, like the home menu: Unknown Object (Differential Revision).
Aug 14 2017, 4:01 PM · ApplicationSearch

Aug 12 2017

epriestley added a comment to T9408: Upgrading: `dot` (Graphviz) support removed, changes to `figlet` and `cowsay`.

In https://hackerone.com/reports/259246 (not currently disclosed) a researcher found an actual issue with figlet. Although it would probably be hard to develop into a practical attack, it does make me feel better about the decision to pull all this stuff into PHP (not just dot) when the dot issue was originally identified.

Aug 12 2017, 11:02 PM · Remarkup, Security, Installing & Upgrading
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

I've landed the two scary migration changes (D18418, D18419) and deployed them here without any obvious issues arising. The actual effects here are:

Aug 12 2017, 11:17 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a parent task for T929: Allow two arbitrary revisions to be compared in Diffusion: T12824: Redesign Diffusion.
Aug 12 2017, 10:52 AM · Diffusion (v3), Restricted Project