Page MenuHomePhabricator
Create Task
Maniphest T4598

Arcanist Asterisk Display with PuTTY
Closed, InvalidPublic
Actions

Description

When a unit test takes less than 1ms to execute, arc unit outputs "<1ms*". Using putty on windows to ssh to a linux box displays the asterisk character as an "a" with a hat followed by a newline! Commenting out the if check here: https://secure.phabricator.com/diffusion/ARC/browse/master/src/unit/renderer/ArcanistUnitConsoleRenderer.php;67239a08a58f6e199e9f939628ad74f94bb0a67b$58 make arc unit correctly display an *.

Can this be fixed, or even removed, as there is no indication what the * is supposed to represent? Thanks!

Event Timeline

• test1212 created this task.Mar 13 2014, 2:43 PM
• test1212 assigned this task to epriestley.
• test1212 raised the priority of this task from to Normal.
• test1212 updated the task description. (Show Details)
• test1212 added a project: Arcanist.
• test1212 added a subscriber: • test1212.
asherkin added a subscriber: asherkin.Mar 13 2014, 5:13 PM

If you enable UTF-8 support in PuTTY (which'll be required for a huge number of things to display correctly, PuTTY's default character encoding is awfully broken), it should fix this.

• test1212 lowered the priority of this task from Normal to Low.Mar 14 2014, 10:15 AM

Thanks, that does stop a newline from appearing (I still only get half a star, but I'm not bothered about that!). However, without setting LANG any xterm windows still cause newlines. I understand this isn't Arcanist's fault, so feel free to close the task.

However, from a "works out of the box" perspective, it might be nice for Arcanist to check $LANG, or just use colours (background?) instead of special characters for the "gold" rating. Up to you guys though!

epriestley closed this task as Invalid.Aug 25 2017, 2:39 PM

This doesn't sound like a Phabricator problem.

Phabricator · Built by Phacility