Page MenuHomePhabricator

Small Revision page enhanchments
Closed, ResolvedPublic

Description

A bunch of small things I think will make revision pages better:

Files TOC:

  • Split "line count" into added/remove (Because removing a 1000 line is nice, but adding 1000 lines is headache).
  • Show some more details for "property changed": I think showing +x right in the TOC is more friendly than M; Under git, there's a total of maybe 4 things that can be there, so we have a chance).
  • Changed Binary files:

    We currently show nothing. We can show file-size , maybe a hash of the file (On both sides). This has actually got a bad commit to truncate a couple of font files recently.

(I'll be diffing this soonish, unless you're totally against it or don't want to review the code now).

Event Timeline

eadler added a project: Restricted Project.Jul 7 2016, 5:18 PM
epriestley added a subscriber: epriestley.

Just sweeping this up, rewriting the property display to show +x seems reasonable to me but I think it's self-evident enough that we don't need to keep a task around for it.