Page MenuHomePhabricator
Create Task
Maniphest T10856

Small Revision page enhanchments
Closed, ResolvedPublic
Actions

Description

A bunch of small things I think will make revision pages better:

Files TOC:

  • Split "line count" into added/remove (Because removing a 1000 line is nice, but adding 1000 lines is headache).
  • Show some more details for "property changed": I think showing +x right in the TOC is more friendly than M; Under git, there's a total of maybe 4 things that can be there, so we have a chance).
  • Changed Binary files:

    We currently show nothing. We can show file-size , maybe a hash of the file (On both sides). This has actually got a bad commit to truncate a couple of font files recently.

(I'll be diffing this soonish, unless you're totally against it or don't want to review the code now).

Revisions and Commits

Restricted Differential Revision
Restricted Differential RevisionRestricted Diffusion Commit

Event Timeline

avivey created this task.Apr 22 2016, 6:02 PM
Herald added a subscriber: eadler. · View Herald TranscriptApr 22 2016, 6:02 PM
joshuaspence added a subscriber: joshuaspence.Apr 24 2016, 12:52 AM
avivey added a revision: Restricted Differential Revision.May 1 2016, 3:47 AM
avivey added a commit: Restricted Diffusion Commit.Jun 6 2016, 7:58 PM
Herald added a subscriber: faulconbridge. · View Herald TranscriptJun 6 2016, 7:58 PM
eadler added a project: Restricted Project.Jul 7 2016, 5:18 PM
avivey added a revision: Restricted Differential Revision.Jul 22 2016, 10:11 PM
avivey updated the task description. (Show Details)Aug 4 2016, 12:55 AM
epriestley closed this task as Resolved.Aug 15 2017, 5:58 PM
epriestley added a subscriber: epriestley.

Just sweeping this up, rewriting the property display to show +x seems reasonable to me but I think it's self-evident enough that we don't need to keep a task around for it.

• GoogleLegacy added a subscriber: • GoogleLegacy.Sep 10 2018, 8:43 AM
Phabricator · Built by Phacility