Page MenuHomePhabricator
Feed Advanced Search

Sep 14 2016

maxie created T11636: Herald condition: count of project tags.
Sep 14 2016, 2:39 PM · Herald, Feature Request

Sep 12 2016

avivey added a comment to T8635: Show history of changes to Herald rules.

Does this mean "render them nicely", or is this a very old ticket? because we technically show something now, although it's mostly useless.

Sep 12 2016, 7:00 PM · Restricted Project, Herald

Sep 11 2016

jonathanrseawright added a comment to T5462: How do I publish Phabricator events into remote systems?.

I'm having some issues using the feed.http-hooks with the system I'm interacting with. My endpoint (trac) requires a CSRF token. I assume there aren't plans to add any sort of (even low-level support) for that? That's totally fine, this is kind of an edge case anyway.

Sep 11 2016, 2:14 AM · Guides, Doorkeeper, Feed, Herald

Sep 9 2016

epriestley closed T11610: Call to a member function getCommitDetail() on a non-object as Resolved by committing rP8d048f06ab51: Fix a Herald issue where testing commits against rules with revision-related….
Sep 9 2016, 12:16 AM · Diffusion, Herald

Sep 8 2016

epriestley claimed T11610: Call to a member function getCommitDetail() on a non-object.
Sep 8 2016, 11:24 PM · Diffusion, Herald
epriestley added a revision to T11610: Call to a member function getCommitDetail() on a non-object: D16522: Fix a Herald issue where testing commits against rules with revision-related conditions would fail.
Sep 8 2016, 11:21 PM · Diffusion, Herald
joshuaspence added a comment to T11610: Call to a member function getCommitDetail() on a non-object.

I was able to reproduce on this install by passing rPf712ae718ccc1c94d882c626ca8626b77346026b to the Herald test console.

Sep 8 2016, 10:46 PM · Diffusion, Herald
joshuaspence created T11610: Call to a member function getCommitDetail() on a non-object.
Sep 8 2016, 10:46 PM · Diffusion, Herald
avivey added a comment to T11118: Herald Rule to assign Owners to an Audit.

We're looking for a similar concept for Reviewers:
Even if the Author of a review is one of the Owners, we still want to automatically add that package.
This is mostly just T1125 - we want to make it easier to assign reviewers, and Owners has good UI for selecting paths.

Sep 8 2016, 6:44 PM · Restricted Project, Audit, Herald, Owners, Feature Request

Sep 7 2016

MattSeen added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

Sorry for the late reply. What an incredibly well written and thoughtful response! Thanks!

Sep 7 2016, 2:47 PM · Herald, Documentation

Sep 2 2016

epriestley closed T11530: Conduit query for Differential revisions mentioning a project as Wontfix.

Broadly, this isn't a use case we intend to support specifically. See T5873, T10363, T11330, T11563#192717 for some related discussion.

Sep 2 2016, 10:26 PM · Herald, Conduit, Differential, Feature Request

Sep 1 2016

venky added a comment to T11530: Conduit query for Differential revisions mentioning a project.
In T11530#192966, @chad wrote:

Maybe create a bot user called @shipit to trigger herald? Mentioning users CCs them to the object, but mentioning projects does nothing currently.

Sep 1 2016, 8:29 PM · Herald, Conduit, Differential, Feature Request
chad added a comment to T11530: Conduit query for Differential revisions mentioning a project.

Maybe create a bot user called @shipit to trigger herald? Mentioning users CCs them to the object, but mentioning projects does nothing currently.

Sep 1 2016, 3:44 PM · Herald, Conduit, Differential, Feature Request
epriestley renamed T11566: Provide more complete guidance on using regular expressions in Herald from Herald docs require better information around how to use contains, matches regexp, matches regexp pairs...etc to Provide more complete guidance on using regular expressions in Herald.
Sep 1 2016, 2:26 PM · Herald, Documentation

Aug 31 2016

epriestley added a parent task for T11566: Provide more complete guidance on using regular expressions in Herald: T8644: Herald template / recipe book / examples / quick-create tool.
Aug 31 2016, 2:32 PM · Herald, Documentation
epriestley added a subtask for T8644: Herald template / recipe book / examples / quick-create tool: T11566: Provide more complete guidance on using regular expressions in Herald.
Aug 31 2016, 2:32 PM · Restricted Project, Herald
epriestley triaged T11566: Provide more complete guidance on using regular expressions in Herald as Low priority.
Aug 31 2016, 2:32 PM · Herald, Documentation

Aug 29 2016

epriestley added a subtask for T5462: How do I publish Phabricator events into remote systems?: T11330: Allow Herald to "Queue Call to Webhook: ...".
Aug 29 2016, 3:02 PM · Guides, Doorkeeper, Feed, Herald

Aug 25 2016

venky added a comment to T11530: Conduit query for Differential revisions mentioning a project.

Herald firing on other things: T10109

Aug 25 2016, 9:48 AM · Herald, Conduit, Differential, Feature Request
venky updated the task description for T11530: Conduit query for Differential revisions mentioning a project.
Aug 25 2016, 9:21 AM · Herald, Conduit, Differential, Feature Request
venky added projects to T11530: Conduit query for Differential revisions mentioning a project: Conduit, Herald.
Aug 25 2016, 9:20 AM · Herald, Conduit, Differential, Feature Request

Aug 22 2016

epriestley reopened T8952: Hide "Herald added subscribers..." stories from feed completely as "Open".

Just reopening this so I don't forget about it since I agree about that last change.

Aug 22 2016, 5:55 PM · Feed, Herald

Aug 18 2016

avivey edited P2001 AddSubscribersFromJIRAIssuesHeraldCustomAction.php.
Aug 18 2016, 2:09 AM · Herald

Aug 17 2016

epriestley added a comment to T11488: Herald Test thinks commits are not objects.

Thanks for the report! This should be fixed in HEAD of master, and promote to stable in a few days. Let me know if I missed anything or you're seeing other issues.

Aug 17 2016, 4:03 PM · Herald, Bug Report
epriestley closed T11488: Herald Test thinks commits are not objects as Resolved by committing rPf659b8743a01: Fix Herald test adapter for commits.
Aug 17 2016, 4:03 PM · Herald, Bug Report
epriestley added a revision to T11488: Herald Test thinks commits are not objects: D16413: Fix Herald test adapter for commits.
Aug 17 2016, 3:37 PM · Herald, Bug Report
epriestley added a comment to T11488: Herald Test thinks commits are not objects.

I broke this in D16360, on August 1.

Aug 17 2016, 3:34 PM · Herald, Bug Report
epriestley claimed T11488: Herald Test thinks commits are not objects.
Aug 17 2016, 3:34 PM · Herald, Bug Report
jasonrumney created T11488: Herald Test thinks commits are not objects.
Aug 17 2016, 2:47 PM · Herald, Bug Report

Aug 14 2016

epriestley closed T11428: Upcoming: Personal Herald Rules No Longer Semi-Private as Resolved.

This has promoted to stable and doesn't seem like a contentious change so I don't currently anticipate any need to keep this open or revisit it.

Aug 14 2016, 12:19 PM · Policy, Installing & Upgrading, Herald
epriestley added a comment to T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.

Personal Herald rules do not run for disabled users, so disabling a user will disable all of their personal rules.

Aug 14 2016, 12:18 PM · Policy, Installing & Upgrading, Herald

Aug 10 2016

Danny_B added a comment to T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.

Thank you for exhaustive description. One more question:

Aug 10 2016, 10:00 PM · Policy, Installing & Upgrading, Herald
epriestley closed T11407: Make is possible to react to commits being parsed as Resolved.

You could also do this with no custom code by using Herald to trigger a Harbormaster build and having that make an HTTP request to something which runs the logic, or theoretically by using feed.http-hooks or Doorkeeper (although these are probably better after T10363).

Aug 10 2016, 9:06 PM · Herald, Diffusion, Feature Request
epriestley moved T11428: Upcoming: Personal Herald Rules No Longer Semi-Private from Backlog to Next on the Herald board.
Aug 10 2016, 4:41 PM · Policy, Installing & Upgrading, Herald
epriestley closed T9410: Policy behavior for Herald rules is murky and inconsistent as Resolved by committing rP7de2fae15611: Link Herald rules to rule detail pages in Herald transcripts.
Aug 10 2016, 3:53 PM · Restricted Project, Herald, Restricted Project
epriestley closed T9410: Policy behavior for Herald rules is murky and inconsistent, a subtask of T11428: Upcoming: Personal Herald Rules No Longer Semi-Private, as Resolved.
Aug 10 2016, 3:53 PM · Policy, Installing & Upgrading, Herald
epriestley added a revision to T11428: Upcoming: Personal Herald Rules No Longer Semi-Private: D16384: Update Herald documentation for modern policies and beahvior.
Aug 10 2016, 1:52 PM · Policy, Installing & Upgrading, Herald
dgoldstein added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

Yay

Aug 10 2016, 1:25 AM · Restricted Project, Herald, Restricted Project
epriestley added a revision to T9410: Policy behavior for Herald rules is murky and inconsistent: D16383: Link Herald rules to rule detail pages in Herald transcripts.
Aug 10 2016, 1:25 AM · Restricted Project, Herald, Restricted Project
epriestley added a revision to T9410: Policy behavior for Herald rules is murky and inconsistent: D16382: Let everyone view Herald rules.
Aug 10 2016, 1:20 AM · Restricted Project, Herald, Restricted Project
epriestley added a comment to T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.

Primarily, global rules bypass access control policies. They can also apply different actions.

Aug 10 2016, 1:13 AM · Policy, Installing & Upgrading, Herald
Danny_B added a comment to T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.

Great and very helpful change, thank you!

Aug 10 2016, 12:35 AM · Policy, Installing & Upgrading, Herald

Aug 9 2016

avivey added a project to T10109: Differental does not trigger Herald for mundane updates: Differential.
Aug 9 2016, 5:57 PM · Differential, Restricted Project, Herald, Bug Report

Aug 7 2016

eadler added a project to T4971: Add support for "Added filenames" and "Removed filenames" in Herald: Restricted Project.
Aug 7 2016, 8:02 PM · Restricted Project, Herald

Aug 6 2016

epriestley closed T7939: Support Herald rules for Calendar events as Resolved by committing rP87f663ef77b4: Add basic Herald support to Calendar.
Aug 6 2016, 9:37 PM · Herald, Calendar

Aug 5 2016

eadler added a project to T920: Provide SMS Support: Restricted Project.
Aug 5 2016, 5:24 PM · Restricted Project, Herald
eadler added a project to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches: Restricted Project.
Aug 5 2016, 5:23 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald

Aug 4 2016

epriestley added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

T11428 puts the corporate communication wheels in motion to make this change.

Aug 4 2016, 3:23 PM · Restricted Project, Herald, Restricted Project
epriestley added a subtask for T11428: Upcoming: Personal Herald Rules No Longer Semi-Private: T9410: Policy behavior for Herald rules is murky and inconsistent.
Aug 4 2016, 3:20 PM · Policy, Installing & Upgrading, Herald
epriestley added a parent task for T9410: Policy behavior for Herald rules is murky and inconsistent: T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.
Aug 4 2016, 3:20 PM · Restricted Project, Herald, Restricted Project
epriestley created T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.
Aug 4 2016, 3:16 PM · Policy, Installing & Upgrading, Herald
epriestley moved T9410: Policy behavior for Herald rules is murky and inconsistent from Backlog to Next on the Herald board.
Aug 4 2016, 2:59 PM · Restricted Project, Herald, Restricted Project

Aug 3 2016

epriestley added a revision to T7939: Support Herald rules for Calendar events: D16368: Add basic Herald support to Calendar.
Aug 3 2016, 11:46 PM · Herald, Calendar
epriestley closed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess as Resolved by committing rP4d68c0ae044c: Make Herald test workflow modular and more clear.
Aug 3 2016, 11:12 PM · Documentation, Herald
epriestley closed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess, a subtask of T7939: Support Herald rules for Calendar events, as Resolved.
Aug 3 2016, 11:12 PM · Herald, Calendar

Aug 2 2016

chad added projects to T11407: Make is possible to react to commits being parsed: Diffusion, Herald.
Aug 2 2016, 4:49 PM · Herald, Diffusion, Feature Request
epriestley added a revision to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: D16360: Make Herald test workflow modular and more clear.
Aug 2 2016, 3:32 PM · Documentation, Herald

Aug 1 2016

epriestley added a revision to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: D15028: Add PHIDType for HeraldTransaction.
Aug 1 2016, 6:31 PM · Documentation, Herald
epriestley placed T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules up for grabs.
Aug 1 2016, 6:30 PM · Applications, Herald
epriestley removed a subtask for T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.
Aug 1 2016, 6:30 PM · Documentation, Herald
epriestley removed a parent task for T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Aug 1 2016, 6:30 PM · Applications, Herald
epriestley added a comment to T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.

Oh, I think I made up point (1) above -- that's already the behavior.

Aug 1 2016, 6:30 PM · Applications, Herald
epriestley claimed T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.
Aug 1 2016, 6:26 PM · Applications, Herald
dereckson updated the task description for T5462: How do I publish Phabricator events into remote systems?.
Aug 1 2016, 12:16 AM · Guides, Doorkeeper, Feed, Herald

Jul 31 2016

aklapper added a comment to T11312: Watch / Subscribe project Herald action needed.

there is no (preferably customizable) real feed (Atom, RSS). [...] there was some task here about it but I can't find it now.

Jul 31 2016, 2:35 PM · Herald, Feature Request
Danny_B added a comment to T11312: Watch / Subscribe project Herald action needed.

A small (partially off-topic) note about feed - in such a high traffic Phabricator instance like ours (WMF), it is nearly unusable. Fortiori if there is no (preferably customizable) real feed (Atom, RSS). Lack of feed support in Phabricator is one of its biggest disadvantages. I know there was some task here about it but I can't find it now.

Jul 31 2016, 2:33 PM · Herald, Feature Request
aklapper added a comment to T11312: Watch / Subscribe project Herald action needed.

As I was asked to provide some input here:

  • Why aren't they using "Send me an email" rules?

That is what I am currently doing via Herald in our Maniphest installation. :)

  • Why aren't they using Feed?

As a bugmaster, my workflow is primarily email-based (describing a fact here that likely could be challenged). I receive notifications on Maniphest task changes which interest me and filter / process them. I abuse the "Unread" status of certain emails to mark stuff I'd like to follow up on later. I have not played with Feed (or an application to consume feeds) to be able to judge whether that would also suit my needs on processing large amounts of information and acting on some of that.

  • Why do they want all of this information in the first place?

As a bugmaster, I'd like to get informed of most / nearly all changes on tasks, to allow me clarifying task descriptions (steps to reproduce etc), escalate issues that seem important, manage expectations, etc., to support our many stakeholders.

Jul 31 2016, 2:28 PM · Herald, Feature Request

Jul 30 2016

epriestley moved T7939: Support Herald rules for Calendar events from Backlog to Next on the Herald board.
Jul 30 2016, 12:28 PM · Herald, Calendar
epriestley merged task T9305: "A task is moved between columns on a workboard." email preference not respected into T10448: Modularize mail tags.
Jul 30 2016, 12:27 PM · Herald
epriestley added a comment to T9305: "A task is moved between columns on a workboard." email preference not respected.

I'm going to close this in favor of T10448, which discusses fixing "other" tags and generally improving how tags work.

Jul 30 2016, 12:27 PM · Herald
epriestley closed T10966: Let Herald move objects between Spaces as Wontfix.

I think custom forms (today), workboard support for custom forms (likely, in the future), and T8442 are the most promising ways forward here.

Jul 30 2016, 12:24 PM · Herald, Feature Request
epriestley closed T11312: Watch / Subscribe project Herald action needed as Invalid.

It's still not really clear to me what this issue is describing. Here are my best guesses at how to fix various things which might be problems?

Jul 30 2016, 12:17 PM · Herald, Feature Request
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

T7961 is probably worth fixing while I'm in here.

Jul 30 2016, 11:50 AM · Documentation, Herald
epriestley added a subtask for T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules.
Jul 30 2016, 11:50 AM · Documentation, Herald
epriestley added a parent task for T7961: In Herald, don't offer Fields and Actions from uninstalled applications to users writing rules: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:50 AM · Applications, Herald
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

I'm going to at least fix the instanceof mess before adding a Calendar adapter in T7939.

Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley claimed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley added a subtask for T7939: Support Herald rules for Calendar events: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.
Jul 30 2016, 11:48 AM · Herald, Calendar
epriestley added a parent task for T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: T7939: Support Herald rules for Calendar events.
Jul 30 2016, 11:48 AM · Documentation, Herald
epriestley claimed T7939: Support Herald rules for Calendar events.
Jul 30 2016, 11:45 AM · Herald, Calendar

Jul 24 2016

witrin updated the question details for Q453: Sequentialization and parallelization of Harbormaster builds.
Jul 24 2016, 12:18 AM · Herald, Harbormaster

Jul 23 2016

witrin updated Q453: Sequentialization and parallelization of Harbormaster builds from to Sequentialization and parallelization of Harbormaster builds.
Jul 23 2016, 2:53 PM · Herald, Harbormaster

Jul 21 2016

avivey edited P2001 AddSubscribersFromJIRAIssuesHeraldCustomAction.php.
Jul 21 2016, 9:54 PM · Herald
st_we updated the question details for Q451: Add subscriber to task with herald rules if there is "no" subscriber on creation.
Jul 21 2016, 8:47 PM · Maniphest, Herald
st_we updated Q451: Add subscriber to task with herald rules if there is "no" subscriber on creation from to Add subscriber to task with herald rules if there is "no" subscriber on creation.
Jul 21 2016, 8:40 PM · Maniphest, Herald

Jul 20 2016

jsturgeon added a comment to T10109: Differental does not trigger Herald for mundane updates.

I'm curious, is there any other way to trigger Herald to process a Differential review *other* than uploading a new diff?

Jul 20 2016, 6:09 PM · Differential, Restricted Project, Herald, Bug Report
jsturgeon updated the answer wiki for Q447: Herald rules don't trigger on differential 'update'.
Jul 20 2016, 4:56 PM · Herald
jsturgeon closed Q447: Herald rules don't trigger on differential 'update' as resolved.
Jul 20 2016, 4:55 PM · Herald
jsturgeon added a comment to Q447: Herald rules don't trigger on differential 'update'.

Yes, nothing is in the transcript, in other words, no job was triggered

Jul 20 2016, 2:15 PM · Herald
benjumanji added a comment to Q447: Herald rules don't trigger on differential 'update'.

I won't comment on the specifics, but have you looked at the herald transcript? I normally find the answer hiding in there.

Jul 20 2016, 10:10 AM · Herald
jsturgeon added a comment to T11349: Herald has the wrong list of "Author's Projects".

no.. they've been a part of that project since the beginning

Jul 20 2016, 12:21 AM · Restricted Project, Herald, Bug Report

Jul 19 2016

avivey added a comment to T11349: Herald has the wrong list of "Author's Projects".

If you're not allowed to see PHID-PROJ-rwnekrajar5m6diprobx, it will not be returned from project.query. Herald should be seeing all projects though, so PHID-PROJ-quo7cpreceuh6hnor3pw missing is strange.

Jul 19 2016, 11:03 PM · Restricted Project, Herald, Bug Report
jsturgeon added a comment to T11349: Herald has the wrong list of "Author's Projects".

yes... they're secret :)

Jul 19 2016, 10:56 PM · Restricted Project, Herald, Bug Report
avivey renamed T11349: Herald has the wrong list of "Author's Projects" from Herald has the wrong list of project authors to Herald has the wrong list of "Author's Projects".
Jul 19 2016, 10:17 PM · Restricted Project, Herald, Bug Report
avivey added a comment to T11349: Herald has the wrong list of "Author's Projects".

Is there anything special about the projects PHID-PROJ-rwnekrajar5m6diprobx and PHID-PROJ-quo7cpreceuh6hnor3pw? Is any of them secret?

Jul 19 2016, 10:17 PM · Restricted Project, Herald, Bug Report
jsturgeon created T11349: Herald has the wrong list of "Author's Projects".
Jul 19 2016, 9:07 PM · Restricted Project, Herald, Bug Report
jsturgeon added a project to Q447: Herald rules don't trigger on differential 'update': Herald.
Jul 19 2016, 6:28 PM · Herald
jsturgeon closed Q446: Are harbormaster builds cancellable? as resolved.
Jul 19 2016, 6:24 PM · Herald, Harbormaster
jsturgeon added a project to Q446: Are harbormaster builds cancellable?: Herald.
Jul 19 2016, 6:02 PM · Herald, Harbormaster
20after4 added a comment to T11312: Watch / Subscribe project Herald action needed.

I think the root problem here is that "Herald added a subscriber: $user" is seen as email-spammy yet people are unwilling to edit their preferences to disable notifications for subscription-changes.

Jul 19 2016, 6:42 AM · Herald, Feature Request