Page MenuHomePhabricator
Feed Advanced Search

May 25 2016

epriestley added a project to T5267: Localize Phabricator: Prioritized.
May 25 2016, 4:20 PM · Prioritized, Localization
epriestley added a comment to Q400: How can I generate Tables of Contents on Phriction pages? (Answer 381).

iiam

May 25 2016, 4:19 PM
epriestley added a comment to T11030: Cannot clone public repository over HTTP anonymously..

This should be fixed in HEAD of master. Thanks for the report! Let us know if you run into anything else.

May 25 2016, 4:11 PM · Diffusion, Bug Report
epriestley added a comment to Q400: How can I generate Tables of Contents on Phriction pages? (Answer 381).

Can you create a document on this install which you believe should have a table of contents but doesn't?

May 25 2016, 4:10 PM
epriestley added a comment to T11032: Repository URL missing port if phabricator is installed on non-80 port.

This should be fixed in HEAD of master. Thanks for the report! Let us know if you run into anything else.

May 25 2016, 4:09 PM · Diffusion, Bug Report
epriestley closed T11030: Cannot clone public repository over HTTP anonymously. as Resolved by committing Restricted Diffusion Commit.
May 25 2016, 4:07 PM · Diffusion, Bug Report
epriestley closed T11032: Repository URL missing port if phabricator is installed on non-80 port as Resolved by committing Restricted Diffusion Commit.
May 25 2016, 4:07 PM · Diffusion, Bug Report
epriestley added Q400: How can I generate Tables of Contents on Phriction pages? (Answer 381).
May 25 2016, 4:06 PM
epriestley added a project to T11030: Cannot clone public repository over HTTP anonymously.: Diffusion.
May 25 2016, 3:13 PM · Diffusion, Bug Report
epriestley claimed T11030: Cannot clone public repository over HTTP anonymously..
May 25 2016, 3:13 PM · Diffusion, Bug Report
epriestley claimed T11032: Repository URL missing port if phabricator is installed on non-80 port.
May 25 2016, 3:12 PM · Diffusion, Bug Report
epriestley added a revision to T11030: Cannot clone public repository over HTTP anonymously.: Unknown Object (Differential Revision).
May 25 2016, 3:10 PM · Diffusion, Bug Report
epriestley added a revision to T11032: Repository URL missing port if phabricator is installed on non-80 port: Unknown Object (Differential Revision).
May 25 2016, 3:10 PM · Diffusion, Bug Report
epriestley added a comment to T4768: Phabricator silently overwrites concurrent changes (no conflict detection).

Copying in some context from elsewhere:

May 25 2016, 2:46 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley triaged T11033: Browser/OS plugin to be able to use "Passphrase" as the main password manager as Wishlist priority.

This is conceptually reasonable, but likely years away. We ship no native code right now. Although there are many Phabricator applications which could take advantage of an optional OS client (for example, to make it easier to upload screenshots or access files) the pathway from where we are now to building one is a very long one, and none of these use cases are near the top of our priority list.

May 25 2016, 2:00 PM · Passphrase, Feature Request
epriestley closed T11031: It is possible to create repositories with invalid ssh urls as Invalid.

Please read Contributing Bug Reports carefully and make sure you provide all the required information, particularly reproduction steps (see Providing Reproduction Steps). Thanks!

May 25 2016, 1:29 PM · Bug Report

May 24 2016

epriestley added a comment to T10349: Projects v3 Errata.

Sure, let me split the subproject/workboard piece out and we can walk through it. (I may not get to this tonight because I have had a long day of Business Things.)

May 24 2016, 11:50 PM · Restricted Project, Projects (v3)
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

On the "public preview" use case I do think "--plan-changes + [DRAFT] in title + just let Herald triggers fire, if users configured them they can deal with knowing about your not-quite-perfect-yet changes" is fairly reasonable, which is part of why I've resisted pursuing this until now.

May 24 2016, 10:04 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

to avoid accidentally forgetting to pass an additional option in cases where you did intend it

May 24 2016, 9:28 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

Another possibility is:

May 24 2016, 9:08 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

We've never seen any real interest from other installs in a default preview-before-publish mode, and I'm not aware of any class of mistakes that users routinely make or wish to correct which this mode would aid in (if I was, we'd try to detect/fix them in arc diff so users didn't need to go to the browser). We've also never seen other interest in the annotate-before-publish use case. T949 is the only task in this vein that I was able to dig up, and focused on previewing the diff only. I'm not really sure what problems this mode solves outside easing adoption when coming from another tool which works like this.

May 24 2016, 8:53 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

As a sanity check here before I actually build it, is anyone who is interested in configuring global default settings interested in configuring any settings other than mail-related settings? Or is this just T9161 in an alternate form, practically speaking?

May 24 2016, 7:18 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley moved T4103: Implement "Role Profiles" to provide search, homepage and application defaults from Preflight to The Queue on the Prioritized board.
May 24 2016, 6:55 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a comment to T5267: Localize Phabricator.

Competing translations are waste of resources and choice is not good for users.

May 24 2016, 5:02 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

I do not know what are you main concerns [with direct commit access].

May 24 2016, 3:44 PM · Prioritized, Localization
epriestley closed T11025: Milestones (sprints) need a target end date as Invalid.

I'm not sure how to describe it differently.

May 24 2016, 2:44 PM · Projects, Feature Request
epriestley added a comment to T11023: Branch contains condition in Herald rule not behaving as expected .

Commit objects are not GC'ed in Phabricator?

May 24 2016, 2:38 PM · Bug Report
epriestley merged T11023: Branch contains condition in Herald rule not behaving as expected into T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.
May 24 2016, 2:36 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley merged task T11023: Branch contains condition in Herald rule not behaving as expected into T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.
May 24 2016, 2:36 PM · Bug Report
epriestley added a comment to T11023: Branch contains condition in Herald rule not behaving as expected .

Deleting the branch first won't have any effect, since the commit still exists.

May 24 2016, 2:36 PM · Bug Report
epriestley added a comment to T11019: Improve UX and general awareness of "remote diff" processing.

My general line of thinking is that providing a better idea of a "context" to arc unit (e.g., diff vs build) and letting it make a default decision about which tests to run (possibly including no tests) is probably the most promising way forward here. You could still override this context with some kind of arc diff --run-some-extra-tests flag. I'm not sure if hard-coding a small number of contexts or making them fully user-configurable or something in between is the best way forward. This is probably a longer-term thing.

May 24 2016, 2:31 PM · Restricted Project, Arcanist, Feature Request
epriestley closed T11016: When owner of Owners package is a project, audit triggers even when member of project signs off as Resolved.
May 24 2016, 1:46 PM · Owners, Bug Report
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

We have a somewhat-legitimate technical reason for this behavior: when we compute which-packages-own(list-of-paths), we do so by splitting the paths into components and then querying for the components. a/b/ is the best database representation for this.

May 24 2016, 1:29 PM · Owners, Bug Report
epriestley claimed T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.
May 24 2016, 1:09 PM · Owners, Bug Report
epriestley added a comment to T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.

This was a legitimate upstream bug and I was able to reproduce it by following your steps, thanks for the report. D15971 should resolve it.

May 24 2016, 1:09 PM · Owners, Bug Report
epriestley added a revision to T11016: When owner of Owners package is a project, audit triggers even when member of project signs off: Unknown Object (Differential Revision).
May 24 2016, 1:08 PM · Owners, Bug Report
epriestley added a comment to T11019: Improve UX and general awareness of "remote diff" processing.

If developers generally don't run tests locally, is having arc unit do anything really valuable in your environment? That is, if you solved this by de-configuring arc so that arc unit did nothing, what would you lose?

May 24 2016, 12:51 PM · Restricted Project, Arcanist, Feature Request
epriestley added a comment to T11023: Branch contains condition in Herald rule not behaving as expected .

Is this the same as T6522? I'm not sure where the last screenshot came from, I wouldn't expect an FF-merge + push to trigger another evaluation of Herald rules.

May 24 2016, 12:44 PM · Bug Report
epriestley closed T11028: Can't push/pull into a hosted repository since 2016 Week 20 (Mid May) update as Resolved.

Great, glad things are working. Let us know if you run into anything else.

May 24 2016, 12:41 PM · Diffusion, Bug Report
epriestley closed T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API as Resolved.

This appears to be stable and working properly, at least for the most part.

May 24 2016, 12:38 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley closed T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API, a subtask of T10337: Implement `diffusion.search` and think about `diffusion.edit`, as Resolved.
May 24 2016, 12:38 PM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T11028: Can't push/pull into a hosted repository since 2016 Week 20 (Mid May) update.

Does your configuration satisfy the conditions described in the documentation?

May 24 2016, 12:13 PM · Diffusion, Bug Report
dnm_t awarded T7903: Conduit differential.query search by branches is broken a The World Burns token.
May 24 2016, 11:51 AM · Restricted Project, Differential, Conduit
epriestley closed T11024: Can't create account of Apple Computer Wiki as Invalid.

This service has no relationship to Apple Computer Wiki, and can not help resolve your problem.

May 24 2016, 11:39 AM · Bug Report
epriestley closed T11026: test title as Spite.
May 24 2016, 11:39 AM · Feature Request
epriestley closed T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user as Resolved by committing Restricted Diffusion Commit.
May 24 2016, 12:55 AM · Owners, Bug Report
epriestley closed T11020: Pushing to an unactivated cluster repository can freeze the repository in a locked state? as Resolved by committing Restricted Diffusion Commit.
May 24 2016, 12:55 AM · Clusters, Diffusion
epriestley claimed T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user.
May 24 2016, 12:34 AM · Owners, Bug Report
epriestley added a revision to T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user: Unknown Object (Differential Revision).
May 24 2016, 12:33 AM · Owners, Bug Report
epriestley merged T11018: Restricted credentials show as unknown in Drydock into T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
May 24 2016, 12:20 AM · Policy, Spaces
epriestley merged task T11018: Restricted credentials show as unknown in Drydock into T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
May 24 2016, 12:20 AM · Bug Report, Drydock
epriestley added a comment to T11018: Restricted credentials show as unknown in Drydock .

This is because that credential is in a restricted Space so this is ultimately the same as T9771, I'm just going to merge it there. The actual Query looks to be implemented fine so I think this is purely a Space issue.

May 24 2016, 12:20 AM · Bug Report, Drydock
epriestley closed T11021: Argument 1 passed to DifferentialReviewersField::inflateReviewers() must be of the type array, null given as Resolved by committing Restricted Diffusion Commit.
May 24 2016, 12:16 AM · Differential, Bug Report
epriestley added a revision to T11020: Pushing to an unactivated cluster repository can freeze the repository in a locked state?: Unknown Object (Differential Revision).
May 24 2016, 12:15 AM · Clusters, Diffusion
epriestley added a comment to T11021: Argument 1 passed to DifferentialReviewersField::inflateReviewers() must be of the type array, null given.

Thanks!

May 24 2016, 12:06 AM · Differential, Bug Report
epriestley added a revision to T11021: Argument 1 passed to DifferentialReviewersField::inflateReviewers() must be of the type array, null given: Unknown Object (Differential Revision).
May 24 2016, 12:06 AM · Differential, Bug Report
epriestley claimed T11021: Argument 1 passed to DifferentialReviewersField::inflateReviewers() must be of the type array, null given.
May 24 2016, 12:05 AM · Differential, Bug Report

May 23 2016

epriestley added a comment to T5267: Localize Phabricator.

I think the largest source of concern here is the (1b) and (3) rules: we aren't willing to exclude translations from other sources, and we aren't willing to give anyone direct commit access to the upstream. But Phabricator supports loading translations from external libraries, so we don't actually need to resolve these issues.

May 23 2016, 11:50 PM · Prioritized, Localization
epriestley created T11020: Pushing to an unactivated cluster repository can freeze the repository in a locked state?.
May 23 2016, 10:17 PM · Clusters, Diffusion
epriestley added a comment to T11017: Phabricator sending unexpected email for commits that aren't obviously related to the user.

I think I have a pretty good guess about this one.

May 23 2016, 8:56 PM · Owners, Bug Report
epriestley added a comment to T10939: Support for OWNERS files.

@joshuaspence, see T11010, I think. Not sure why nginx was 502'ing there, but should be fixed in HEAD.

May 23 2016, 7:49 PM · Prioritized, Restricted Project, Owners
epriestley closed T11010: Http502 when submitting or updating a diff as Resolved by committing Restricted Diffusion Commit.
May 23 2016, 7:48 PM · Bug Report
epriestley added a comment to T11016: When owner of Owners package is a project, audit triggers even when member of project signs off.

Before I dig into this, is there any possibility this was a daemon running old code? I don't remember if I tested this explicitly and it could quite reasonably be an upstream bug, but the code at least attempts to check for this, and D15939 theoretically fixed issues with this.

May 23 2016, 7:45 PM · Owners, Bug Report
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

We can also use weird implicit magic to try to resolve this. Here's a ruleset that will make everyone equally confused and unhappy:

May 23 2016, 7:25 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

I think that that creates some tension that I'm not immediately sure how to resolve:

May 23 2016, 7:02 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley moved T4103: Implement "Role Profiles" to provide search, homepage and application defaults from Backlog to Preflight on the Prioritized board.
May 23 2016, 6:35 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a project to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Prioritized.
May 23 2016, 6:34 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley moved T10855: Allow external systems to edit the content of dashboard panels so they can publish information from Backlog to Preflight on the Prioritized board.
May 23 2016, 6:34 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley added a project to T10855: Allow external systems to edit the content of dashboard panels so they can publish information: Prioritized.

We aren't really sold on this as a specific use case, but can give you a modern dashboard.panel.edit which will let you implement it. If there are weird followups arising from this (like difficulty managing the 300,000 transactions on the panel detail a year from now) we may be somewhat less sympathetic to them than we would be to a more on-label use case.

May 23 2016, 6:33 PM · Dashboards, Restricted Project, Conduit, Feature Request
epriestley moved T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust) from Backlog to Preflight on the Prioritized board.
May 23 2016, 6:25 PM · Prioritized, Restricted Project, Feature Request
epriestley added a project to T10227: Provide an extension point for HTTP behaviors (proxies, SSL trust): Prioritized.

This is about two hours of work.

May 23 2016, 6:25 PM · Prioritized, Restricted Project, Feature Request
epriestley moved T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential from Paused to Preflight on the Prioritized board.
May 23 2016, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

There were ultimately two sort of related requests here, although some of the discussion happened off-thread. Let's call them arc diff --draft and arc diff --try:

May 23 2016, 6:23 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T11010: Http502 when submitting or updating a diff: Unknown Object (Differential Revision).
May 23 2016, 5:43 PM · Bug Report
epriestley added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

unfortumately

May 23 2016, 5:36 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

The time zone selected below has been auto-detected based on your browser settings

May 23 2016, 5:36 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them: Unknown Object (Differential Revision).
May 23 2016, 5:28 PM · Prioritized, Restricted Project, User Preferences
epriestley renamed T11015: Owners has perplexing behavior when directory paths are not terminated with a slash from Owners not picking up code reviews, unclear if properly configured to Owners has perplexing behavior when directory paths are not terminated with a slash.
May 23 2016, 4:34 PM · Owners, Bug Report
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Yeah, current behavior is garbage. Not sure if I changed it by accident while doing other changes or we just didn't run into it before, but there's no technical or product reason for it to work like it currently does.

May 23 2016, 4:31 PM · Owners, Bug Report
epriestley added a comment to T11002: permit wildcards in OWNERs paths.

I suspect it isn't going to get very far because we lose our ability to optimize lookups (I wrote this in the general case as "regexp", but mean "regexp/wildcard" -- wildcards aren't as complex but I think the general case still holds).

May 23 2016, 3:31 PM · FreeBSD, Owners, Feature Request
epriestley added a comment to T11015: Owners has perplexing behavior when directory paths are not terminated with a slash.

Try /wsl_root/src/ansible/ (with a trailing slash)?

May 23 2016, 3:09 PM · Owners, Bug Report
epriestley closed T11014: Voluptas soluta ut quod vel vel voluptatem quo provident autem reprehenderit dolorem quibusdam ullamco at reprehenderit natus obcaecati labore debitis as Spite.
May 23 2016, 2:33 PM · Abuse
epriestley added a comment to T11009: owners packages details screen throws exception.

Did you fully restart everything (see Restarting Phabricator) after upgrading? I can't reproduce this and it looks like the kind of thing that could happen if Phabricator was not fully restarted.

May 23 2016, 12:13 AM · Bug Report

May 22 2016

epriestley closed T10381: Tweak linebreak preservation behavior of PHUIRemarkupView as Resolved by committing Restricted Diffusion Commit.
May 22 2016, 7:23 PM · Remarkup
epriestley closed T992: Send rich HTML mail bodies without impacting reply handling functionality as Resolved.

We now send HTML mail by default.

May 22 2016, 7:20 PM · Differential, Mail
epriestley moved T3837: Support updating JIRA custom field when revisions change status from Backlog to Preflight on the Prioritized board.
May 22 2016, 6:40 PM · Restricted Project, Doorkeeper, Differential
epriestley added a project to T3837: Support updating JIRA custom field when revisions change status: Prioritized.
May 22 2016, 6:40 PM · Restricted Project, Doorkeeper, Differential
epriestley moved T4631: Allow Differential to raise warnings on the server side via Conduit from Backlog to Preflight on the Prioritized board.
May 22 2016, 6:34 PM · Restricted Project, Differential, Arcanist
epriestley added a project to T4631: Allow Differential to raise warnings on the server side via Conduit: Prioritized.
May 22 2016, 6:34 PM · Restricted Project, Differential, Arcanist
epriestley moved T10512: Implement `user.search` Conduit API method from Preflight to Paused on the Prioritized board.

These changes are live on this install:

May 22 2016, 5:20 PM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley moved T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them from Preflight to Paused on the Prioritized board.

These changes are now live on this install.

May 22 2016, 5:16 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T10381: Tweak linebreak preservation behavior of PHUIRemarkupView: Unknown Object (Differential Revision).
May 22 2016, 4:59 PM · Remarkup
epriestley added a comment to T10903: Customize "open in new window" link behavior for RemarkupEngine.

I made some headway on this but I'm feeling really icky about it and I think I may want to try making PHUIRemarkupView more powerful and moving away from PhabricatorMarkupInterface first.

May 22 2016, 4:13 PM · Phacility, Remarkup
epriestley changed the status of T7171: Periodically email saved queries from Duplicate to Wontfix.

Fair enough. I don't plan to pursue this, as written. We've seen very little interest in this, and it's not clear to me that it's the best solution to any problem.

May 22 2016, 4:09 PM
epriestley added a comment to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them.

D15962 attempts to guess the user's timezone by using the Intl API. This appears to be very accurate in Chrome on OSX, but useless in Safari/Firefox.

May 22 2016, 2:04 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T3025: Detect when browser and account timezone settings differ and prompt user to reconcile them: Unknown Object (Differential Revision).
May 22 2016, 1:57 PM · Prioritized, Restricted Project, User Preferences
epriestley closed T1279: Show per-reviewer status in Differential revision reviewer list, a subtask of T731: Allow revisions to have alternate acceptance conditions, as Resolved.
May 22 2016, 1:43 PM · Restricted Project, Restricted Project, Differential
epriestley closed T1279: Show per-reviewer status in Differential revision reviewer list as Resolved.

I'm going to close this as resolved, since I think we've substantially addressed all of the followups or there are now more narrow tasks with more focused problem descriptions available. In particular, from above:

May 22 2016, 1:43 PM · Restricted Project, Differential
epriestley closed T1279: Show per-reviewer status in Differential revision reviewer list, a subtask of T8080: Differential shown as "Blocking Others", as Resolved.
May 22 2016, 1:43 PM · Differential
epriestley closed T10716: Differential Checklist Feature Request as Wontfix.

I'm going to close this since I don't think there's anything we plan to act on here.

May 22 2016, 1:15 PM · Differential, Feature Request