If I have accepted a diff, but it has not yet been reviewed by a blocking reviewer, then it is shown as "Blocking Others" in the main Differential view. I find this misleading because there is nothing further that I can do to unblock this diff.
Description
Description
Related Objects
Related Objects
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Duplicate | None | T8080 Differential shown as "Blocking Others" | ||
| Resolved | epriestley | T1279 Show per-reviewer status in Differential revision reviewer list | ||
| Restricted Maniphest Task |
- Mentioned In
- T10939: Support for OWNERS files
T10417: Active Differentials are wrongly indicated as blocking when "request changes" is used
T9311: Marking a diff as Requires Changes no longer removes it from Blocking Others
T9263: Provide ability to query for all revisions currently blocked by a specific project reviewer
T7076: Show status of linked revisions for tasks
T8173: Red "X" for requesting changes on code reviews is rather harsh - Mentioned Here
- T6596: Blocking reviewers continue appearing as blocking even after they accept a revision
T731: Allow revisions to have alternate acceptance conditions
T1279: Show per-reviewer status in Differential revision reviewer list
Event Timeline
Comment Actions
This is part of the work on T731, T1279. T1279#42118 as the original list of not yet finished work. T6596 is a duplicate. This keeps coming up enough I'm fine leaving a task open for people to subscribe to since the original isn't easy to find.
chad mentioned this in T10417: Active Differentials are wrongly indicated as blocking when "request changes" is used.Feb 22 2016, 8:15 PM2016-02-22 20:15:12 (UTC+0)
chad closed this task as a duplicate of T4144: Users disagree on what "Blocking Others", "Action Required" and "Waiting on Others" mean, and/or which groups should exist.
Herald added a subscriber: eadler. · View Herald TranscriptMay 22 2016, 1:43 PM2016-05-22 13:43:09 (UTC+0)