Page MenuHomePhabricator
Feed Advanced Search

May 21 2016

benmarten added a comment to T11001: Unrecognized lint message code "I003"..

Yes, but I is also reported by jsHint: https://github.com/jshint/jshint/blob/2.1.4/src/shared/messages.js#L195

May 21 2016, 7:12 PM · Lint, Bug Report
avivey added a comment to T11001: Unrecognized lint message code "I003"..

jshint linter only allow W and E prefixes - https://secure.phabricator.com/diffusion/ARC/browse/master/src/lint/linter/ArcanistJSHintLinter.php;2234c8cacc21ce61c9c10e8e5918b6a63cc38fc8$145

May 21 2016, 7:05 PM · Lint, Bug Report
chad added a project to T11001: Unrecognized lint message code "I003".: Lint.
May 21 2016, 6:52 PM · Lint, Bug Report
benmarten added a comment to T11001: Unrecognized lint message code "I003"..

jshint version is the latest: jshint v2.9.2. I'll add more infos to this ticket soon...

May 21 2016, 6:46 PM · Lint, Bug Report
davidism added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

I disabled the APC extension but still had the same issue. I'll try deploying on CentOS 7 when I have some time.

May 21 2016, 4:16 PM · Bug Report
chad added a comment to T11001: Unrecognized lint message code "I003"..

Specifically, what version of JSHint are you using would be most helpful.

May 21 2016, 3:19 PM · Lint, Bug Report
chad added a comment to T11001: Unrecognized lint message code "I003"..

Software versions and steps to reproduce are required information for us on bug reports. Do you mind filling this out please? See Contributing Bug Reports.

May 21 2016, 3:15 PM · Lint, Bug Report
eadler added a project to T11004: git URI normalization is not reliable: Diffusion.
May 21 2016, 1:57 PM · Diffusion, Bug Report
hach-que added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

Try disabling php-apcu and other performance related extensions. Some of them (like APC) are known to cause segfaults or other issues, so unless you actually need to have them installed, I'd suggest disabling them and see if the issue still occurs.

May 21 2016, 6:17 AM · Bug Report
hach-que updated subscribers of T10982: Harbormaster builds fail to allocate resource.

This sounds like an issue with either git clone or the SSH client installed on the build machine itself, and not Phabricator. I don't believe upstream offers support for configuring build agents (they don't offer support for envionment issues on machines that host Phabricator, let alone environment issues on machines that Phabricator uses for builds).

May 21 2016, 6:16 AM · Harbormaster, Bug Report
epriestley added a comment to T11004: git URI normalization is not reliable.

Ugh.

May 21 2016, 12:55 AM · Diffusion, Bug Report
jboning created T11004: git URI normalization is not reliable.
May 21 2016, 12:39 AM · Diffusion, Bug Report

May 20 2016

volker_e added a comment to T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard.

Great, thanks! (And with clarity I meant instant visual clarity for people who haven't been involved in designing them)

May 20 2016, 9:20 PM · Wikimedia, Pholio, Bug Report
chad added a comment to T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard.

I went with checkered for now.

May 20 2016, 9:18 PM · Wikimedia, Pholio, Bug Report
volker_e added a comment to T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard.

@chad Do I understand you correctly, there would be just outright white background for transparent areas with your patch?
The checker background gives clarity as we have to make sure that many of our interface elements shown in Pholio mocks are working on dark and white backgrounds.

May 20 2016, 9:01 PM · Wikimedia, Pholio, Bug Report
chad closed T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard as Resolved.
May 20 2016, 8:42 PM · Wikimedia, Pholio, Bug Report
chad added a revision to T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard: Restricted Differential Revision.
May 20 2016, 8:38 PM · Wikimedia, Pholio, Bug Report
chad added a comment to T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard.

I'm more inclined to remove the checkerboard outright from view. The main concern here is if it's confusing on the edit page, then it's also confusing on the thumb and embed views. The only place we use checkerboard is on the full view page itself.

May 20 2016, 8:33 PM · Wikimedia, Pholio, Bug Report
benmarten created T11001: Unrecognized lint message code "I003"..
May 20 2016, 6:58 PM · Lint, Bug Report
zhiyuchen created T11000: Ability to mark maniphest fields are required in custom form.
May 20 2016, 6:54 PM · EditEngine, Feature Request
epriestley closed T10995: 首页页码条显示错误 as Spite.
May 20 2016, 12:32 PM · Calendar, Bug Report
epriestley closed T10996: https://phabricator.wikimedia.org/ as Invalid.

Not sure if this was just a test or not, but it's doesn't look like a bug report. See Contributing Bug Reports for help writing good bug reports.

May 20 2016, 12:32 PM · Wikimedia, Bug Report
qgil added a comment to T10996: https://phabricator.wikimedia.org/.

This is an invalid task here, but in any case https://phabricator.wikimedia.org/ does work, also for anonymous users.

May 20 2016, 11:05 AM · Wikimedia, Bug Report
• mtherjs created T10996: https://phabricator.wikimedia.org/.
May 20 2016, 10:45 AM · Wikimedia, Bug Report
• bugfucker created T10995: 首页页码条显示错误.
May 20 2016, 10:23 AM · Calendar, Bug Report
epriestley closed T10993: `arc diff` uploads an update to the dependent Diff instead of creating a new diff as Resolved.
May 20 2016, 4:47 AM · Bug Report
Arcank added a comment to T10993: `arc diff` uploads an update to the dependent Diff instead of creating a new diff.
REPOSITORY
To identify the repository associated with this working copy, arc followed this process:
May 20 2016, 3:00 AM · Bug Report
epriestley added a comment to T10993: `arc diff` uploads an update to the dependent Diff instead of creating a new diff.

What does arc which say before you run the final arc diff?

May 20 2016, 1:31 AM · Bug Report
Arcank created T10993: `arc diff` uploads an update to the dependent Diff instead of creating a new diff.
May 20 2016, 12:25 AM · Bug Report

May 19 2016

epriestley closed T10991: Clustering Introduction links to non-existent Drydock Security documentation as Resolved by committing Restricted Diffusion Commit.
May 19 2016, 9:59 PM · Documentation, Bug Report
epriestley added a revision to T10991: Clustering Introduction links to non-existent Drydock Security documentation: Restricted Differential Revision.
May 19 2016, 7:35 PM · Documentation, Bug Report
epriestley claimed T10991: Clustering Introduction links to non-existent Drydock Security documentation.
May 19 2016, 7:34 PM · Documentation, Bug Report
kebe added a comment to T10378: Custom text field does not show up in Advanced Search.

Same here. I've created customfield "Requirement" to identify external Requirement ID. Searching using Contains Words is inadequate cause it search all fields containing similar string.

May 19 2016, 6:11 PM · Restricted Project, Custom Fields, Bug Report
chad added a project to T10991: Clustering Introduction links to non-existent Drydock Security documentation: Documentation.
May 19 2016, 5:08 PM · Documentation, Bug Report
chad added projects to T10931: Changing mysql.implementation setting doesn't work: Database, Setup.
May 19 2016, 5:08 PM · Setup, Database, Bug Report
urzds created T10991: Clustering Introduction links to non-existent Drydock Security documentation.
May 19 2016, 5:07 PM · Documentation, Bug Report
chad added a project to T10811: `phd-daemon` crash after automatic restart following config change: Daemons.
May 19 2016, 5:07 PM · Daemons, Bug Report
chad added a comment to T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter.".

Can you list out a complete set of reproducible steps to follow? Is this a Dashboard you're building and installing on other people homepages, for example?

May 19 2016, 4:51 PM · Audit, Bug Report
chad added a project to T10965: [Needs Audit] shows "Query Errors : This query specifies an invalid parameter.": Audit.
May 19 2016, 4:50 PM · Audit, Bug Report
chad added a project to T10982: Harbormaster builds fail to allocate resource: Harbormaster.
May 19 2016, 4:49 PM · Harbormaster, Bug Report
chad added a subtask for T10987: /config/issue/ causes coredump in PHP-FPM: T9640: Make Phabricator compatible with PHP7.
May 19 2016, 4:49 PM · Bug Report
epriestley added a comment to T10989: Moving task in the same column of the workboard causes its update.

Third-party applications which assume dateModified means "last 'meaningful' update" are written incorrectly. It does not mean that, it is not documented to mean that anywhere, and it is clear from the code that it doesn't have this behavior. It is unreasonable to assume that the only possible purpose of this field is metric extraction. This field is a low-level field which serves a different set of goals. It explicitly does not serve metric extraction goals.

May 19 2016, 1:46 PM · Workboards, Bug Report
eadler added a comment to T10989: Moving task in the same column of the workboard causes its update.

It's logical - you can not build reasonably working application on wrong dataset. One would assume, that maybe in future, Phabricator (either directly or via an extension) will have support for such stats too (as it currently already has some stats such as burnout charts or so...)

May 19 2016, 1:30 PM · Workboards, Bug Report
Danny_B added a comment to T10989: Moving task in the same column of the workboard causes its update.

These are third-party extensions, not other upstream applications, right?

Yes.

Why do you consider this to be a bug in Phabricator rather than in those extensions? Does the documentation say "this field is updated only when a 'meaningful' update is made to an object, and you can and should rely on it to have this behavior when extracting data from Phabricator" somewhere?

It's logical - you can not build reasonably working application on wrong dataset. One would assume, that maybe in future, Phabricator (either directly or via an extension) will have support for such stats too (as it currently already has some stats such as burnout charts or so...)
Inability to do such stats due to unreasonable dataset below makes Phabricator (otherwise good application) useless for teams which are trying to improve (read: shorten in this particular case) the task life-cycle - and that's pretty much every team since noone wants to have long time untouched tasks without any action taken... ;-)

May 19 2016, 1:28 PM · Workboards, Bug Report
epriestley added a comment to T10989: Moving task in the same column of the workboard causes its update.

In fact it breaks various monitoring/statistics depending on last update

May 19 2016, 12:55 PM · Workboards, Bug Report
Danny_B added a comment to T10989: Moving task in the same column of the workboard causes its update.

But moving on the workboard is no update at all... It is null action.

May 19 2016, 12:48 PM · Workboards, Bug Report
epriestley closed T10988: Unable to Import an Existing External Repository as Invalid.

https://secure.phabricator.com/book/phabricator/article/diffusion_uris/#observe-a-repository

May 19 2016, 12:24 PM · Bug Report
epriestley closed T10989: Moving task in the same column of the workboard causes its update as Invalid.

"Last Update" is low level, and includes some actions which do not appear in the task history. This is expected.

May 19 2016, 12:22 PM · Workboards, Bug Report
Danny_B created T10989: Moving task in the same column of the workboard causes its update.
May 19 2016, 9:23 AM · Workboards, Bug Report
adelabreteche updated the task description for T10988: Unable to Import an Existing External Repository .
May 19 2016, 8:00 AM · Bug Report
adelabreteche created T10988: Unable to Import an Existing External Repository .
May 19 2016, 7:58 AM · Bug Report
chad added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

D14566 might fix this? See also T9640.

May 19 2016, 2:48 AM · Bug Report
chad added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

PHP7 is currently unsupported, I would start there and move to 5.6 or whatever you prefer.

May 19 2016, 2:46 AM · Bug Report
davidism added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

Yes, I tried it on my work computer (same versions and configuration), and then on my home computer.

May 19 2016, 2:41 AM · Bug Report
chad added a comment to T10987: /config/issue/ causes coredump in PHP-FPM.

Can you reproduce this on another machine?

May 19 2016, 2:39 AM · Bug Report
davidism renamed T10987: /config/issue/ causes coredump in PHP-FPM from /config/issue/ causes core in PHP-FPM to /config/issue/ causes coredump in PHP-FPM.
May 19 2016, 2:27 AM · Bug Report
davidism created T10987: /config/issue/ causes coredump in PHP-FPM.
May 19 2016, 2:27 AM · Bug Report

May 18 2016

Luke081515.2 added a project to T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard: Wikimedia.
May 18 2016, 11:54 PM · Wikimedia, Pholio, Bug Report
volker_e created T10986: Pholio Mockup edit dialog shows transparent image background white, while in mockups it is transparency checkerboard.
May 18 2016, 10:51 PM · Wikimedia, Pholio, Bug Report
epriestley closed T10980: Code coverage details on Phab as Invalid.
May 18 2016, 7:38 PM · Bug Report
abeer added a comment to T10980: Code coverage details on Phab.

I have been unable to repro on a clean install. Its probably appropriate to close the bug. I apologize for being unclear.

May 18 2016, 7:11 PM · Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

D15942 restores the project tag transaction to the first mail about an object:

May 18 2016, 2:12 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley closed T10493: Task creation no longer lists projects added (neither the UI nor mail notifications) as Resolved by committing Restricted Diffusion Commit.
May 18 2016, 2:09 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

I guess this originally had several different parts. My thinking on the parts are:

May 18 2016, 2:07 PM · Wikimedia, Notifications, Projects (v3), Bug Report
chad added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

or that

May 18 2016, 2:05 PM · Wikimedia, Notifications, Projects (v3), Bug Report
chad added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

Better to do the header tags in the body text thing?

May 18 2016, 1:59 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a revision to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications): Restricted Differential Revision.
May 18 2016, 1:59 PM · Wikimedia, Notifications, Projects (v3), Bug Report
epriestley added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

I think we're mostly unsure what we want to do here.

May 18 2016, 1:51 PM · Wikimedia, Notifications, Projects (v3), Bug Report
qgil added a comment to T10493: Task creation no longer lists projects added (neither the UI nor mail notifications).

Is this task open to be Prioritized? Wikimedia is discussing the possibility to fund it at https://phabricator.wikimedia.org/T135327

May 18 2016, 1:18 PM · Wikimedia, Notifications, Projects (v3), Bug Report
fanis created T10982: Harbormaster builds fail to allocate resource.
May 18 2016, 1:06 PM · Harbormaster, Bug Report
epriestley closed T10977: Unknown Object (User) in Conpherence as Invalid.

These tattered edges are an expected consquence of destroying objects, and the Phabricator upstream will not help you fix them. We strongly recomend disabling or archiving objects instead.

May 18 2016, 12:26 PM · Conpherence, Bug Report
kebe added a comment to T10977: Unknown Object (User) in Conpherence.

Ok. I assume you know about such issue so you prefer not to report it in future?

May 18 2016, 10:07 AM · Conpherence, Bug Report
bcooksley added a comment to T10975: Unable to edit applications in OAuth Server - edge table missing.

Thanks for the quick fix.
I realise now I was always trying to change the access policies....

May 18 2016, 6:51 AM · OAuthServer, Bug Report
joshuaspence added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.

Yep, works now. Thanks

May 18 2016, 2:35 AM · Conduit, Bug Report
epriestley added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.

Thanks, try HEAD?

May 18 2016, 12:45 AM · Conduit, Bug Report
epriestley closed T10981: Expected a scalar or null for %Ls conversion. Query: user.phid as Resolved by committing Restricted Diffusion Commit.
May 18 2016, 12:44 AM · Conduit, Bug Report
avivey added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.

D15934? looks like it introduced "suffixes" for reviewers.

May 18 2016, 12:41 AM · Conduit, Bug Report
joshuaspence added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.

I'm not sure if this change is correct, but it seems to fix the issue for me: https://secure.phabricator.com/differential/diff/38381/

May 18 2016, 12:29 AM · Conduit, Bug Report
epriestley added a comment to T10980: Code coverage details on Phab.

arc diff is not expected to upload coverage information without additional configuration.

May 18 2016, 12:27 AM · Bug Report
joshuaspence added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.

I think the output format from differential.parsecommitmessage has changed:

May 18 2016, 12:25 AM · Conduit, Bug Report
avivey added a comment to T10980: Code coverage details on Phab.

Whatever's generating your coverage information (A unit-test engine) needs to provide file names relative to the root of the repository; The snippet you have is showing the filenames are absolute.

May 18 2016, 12:21 AM · Bug Report
joshuaspence added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.
> arc diff --trace
 ARGV  '/home/REDACTED/phabricator/arcanist/bin/../scripts/arcanist.php' 'diff' '--trace'
 LOAD  Loaded "phutil" from "/home/REDACTED/phabricator/libphutil/src".
 LOAD  Loaded "arcanist" from "/home/REDACTED/phabricator/arcanist/src".
Config: Reading user configuration file "/home/REDACTED/.arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: Reading .arcconfig from "/home/REDACTED/Documents/repos/REDACTED/.arcconfig".
Working Copy: Path "/home/REDACTED/Documents/repos/REDACTED" is part of `git` working copy "/home/REDACTED/Documents/repos/REDACTED".
Working Copy: Project root is at "/home/REDACTED/Documents/repos/REDACTED".
Config: Did not find local configuration at "/home/REDACTED/Documents/repos/REDACTED/.git/arc/config".
Loading phutil library from '/home/REDACTED/Documents/repos/REDACTED/support/flarc/src'...
>>> [0] <conduit> user.whoami() <bytes = 117>
>>> [1] <http> https://phabricator.REDACTED.com/api/user.whoami
<<< [1] <http> 1,117,794 us
<<< [0] <conduit> 1,118,567 us
>>> [2] <exec> $ git diff --no-ext-diff --no-textconv --raw 'HEAD' --
>>> [3] <exec> $ git ls-files --others --exclude-standard
<<< [3] <exec> 125,537 us
<<< [2] <exec> 177,610 us
>>> [4] <exec> $ git diff-files --name-only
<<< [4] <exec> 60,686 us
You have untracked files in this working copy.
May 18 2016, 12:08 AM · Conduit, Bug Report
joshuaspence added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.

Oh, this is probably the correct error log:

May 18 2016, 12:04 AM · Conduit, Bug Report
joshuaspence added a comment to T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.

Server-side, I have the following commits deployed:

May 18 2016, 12:03 AM · Conduit, Bug Report
abeer added a comment to T10980: Code coverage details on Phab.

Updated version information:

May 18 2016, 12:02 AM · Bug Report
joshuaspence created T10981: Expected a scalar or null for %Ls conversion. Query: user.phid.
May 18 2016, 12:00 AM · Conduit, Bug Report

May 17 2016

epriestley added a comment to T10980: Code coverage details on Phab.

You're also two months out of date, see Contributing Bug Reports.

May 17 2016, 11:33 PM · Bug Report
epriestley added a comment to T10980: Code coverage details on Phab.

Please include reproduction steps when filing a bug report. See Providing Reproduction Steps for help.

May 17 2016, 11:32 PM · Bug Report
abeer created T10980: Code coverage details on Phab.
May 17 2016, 11:12 PM · Bug Report
epriestley closed T10174: Adding a owner package to an audit when package auditing is disable leads to a "not applicable" commit review as Resolved by committing Restricted Diffusion Commit.
May 17 2016, 8:47 PM · Restricted Project, Herald, Owners, Bug Report
epriestley added a revision to T10174: Adding a owner package to an audit when package auditing is disable leads to a "not applicable" commit review: Restricted Differential Revision.
May 17 2016, 7:01 PM · Restricted Project, Herald, Owners, Bug Report
epriestley closed T10975: Unable to edit applications in OAuth Server - edge table missing as Resolved by committing Restricted Diffusion Commit.
May 17 2016, 3:50 PM · OAuthServer, Bug Report
epriestley merged T10979: editing panels in right column of dashboard duplicates them into the left column into T10612: Editing a panel causes it to duplicate in dashboard.
May 17 2016, 3:47 PM · Dashboards (v2), Bug Report
epriestley merged task T10979: editing panels in right column of dashboard duplicates them into the left column into T10612: Editing a panel causes it to duplicate in dashboard.
May 17 2016, 3:47 PM · Bug Report
allixsenos created T10979: editing panels in right column of dashboard duplicates them into the left column.
May 17 2016, 3:47 PM · Bug Report
epriestley claimed T10975: Unable to edit applications in OAuth Server - edge table missing.
May 17 2016, 1:51 PM · OAuthServer, Bug Report
epriestley added a comment to T10977: Unknown Object (User) in Conpherence.

When you deleted the user, did you see this prompt?

May 17 2016, 1:48 PM · Conpherence, Bug Report
kebe renamed T10977: Unknown Object (User) in Conpherence from Unknown Object (User) in Conherence to Unknown Object (User) in Conpherence.
May 17 2016, 1:33 PM · Conpherence, Bug Report
kebe created T10977: Unknown Object (User) in Conpherence.
May 17 2016, 1:33 PM · Conpherence, Bug Report
epriestley added a comment to T10645: Accepting a closed diff causes diff to be re-opened.

Ah, thanks for following up. That's interesting and a little perplexing, although just fixing this stuff via T10967 is probably still the best way forward. I'll keep an eye out for similar reports, though. That does tend to make me think it might be a real race.

May 17 2016, 1:14 PM · Differential, Bug Report