Page MenuHomePhabricator
Feed Advanced Search

Nov 2 2015

Mnkras created T9695: Have the ability to have an interstitial page for outbound Phurl links..
Nov 2 2015, 11:35 PM · Phurl
Mnkras added a comment to D14344: Re-order remarkup rule blocks to pass tests on PHP7.

I guess the question is:

Nov 2 2015, 7:35 PM
Mnkras awarded T9683: Support `@throws` annotation a Piece of Eight token.
Nov 2 2015, 2:14 AM · Diviner
Mnkras added a comment to T9683: Support `@throws` annotation.

+1, especially with all the new types in PHP7 this would be awesome.

Nov 2 2015, 2:14 AM · Diviner

Oct 30 2015

Mnkras added a comment to D14369: Allow any {icon} to spin.

I really hoped that this allowed the ability to spin memes, but I was disappointed

Oct 30 2015, 11:38 PM

Oct 29 2015

Mnkras added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

You can find info on authorizations here: https://secure.phabricator.com/book/phabricator/article/drydock_blueprints/ and here: https://secure.phabricator.com/book/phabricator/article/drydock_security/

Oct 29 2015, 9:00 PM · Harbormaster, Drydock
Mnkras added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

That commit is from October 8th, have you tried updating to HEAD?

Oct 29 2015, 8:52 PM · Harbormaster, Drydock

Oct 27 2015

Mnkras closed T9638: Partner Did Not Generate Pay Statement for 19th through 26th Payment Page https://toolshed.uberinternal.com/t2/partners/229f5edd-a6ff-4ade-802f-f0744469dd8b/payments as Spite.
Oct 27 2015, 2:30 AM
Mnkras added inline comments to D14348: Don't show error operations after a successful land operation.
Oct 27 2015, 12:07 AM
Mnkras added inline comments to D14348: Don't show error operations after a successful land operation.
Oct 27 2015, 12:02 AM

Oct 26 2015

Mnkras accepted D14348: Don't show error operations after a successful land operation.
Oct 26 2015, 9:25 PM
Mnkras committed rP6e7ceb996bb3: Set a property so that unit tests run on PHP7 (authored by Mnkras).
Set a property so that unit tests run on PHP7
Oct 26 2015, 9:15 PM
Mnkras closed D14345: Set a property so that unit tests run on PHP7 by committing rP6e7ceb996bb3: Set a property so that unit tests run on PHP7.
Oct 26 2015, 9:15 PM
Mnkras added a comment to D14347: Provide a username and email when running `git merge --squash`.

I feel like a bug should be posted to git about this...

Oct 26 2015, 9:11 PM
Mnkras accepted D14347: Provide a username and email when running `git merge --squash`.
Oct 26 2015, 9:11 PM
Mnkras accepted D14346: Don't use --ff-only inside "Land Revision".
Oct 26 2015, 8:26 PM
Mnkras retitled D14345: Set a property so that unit tests run on PHP7 from to Set a property so that unit tests run on PHP7.
Oct 26 2015, 7:34 PM
Mnkras added a comment to D14344: Re-order remarkup rule blocks to pass tests on PHP7.

Yea, I copied out the regex that is used in the code block rule, the weird thing is, that PHP7 and PHP5 outputs don't differ

Oct 26 2015, 7:19 PM
Mnkras retitled D14344: Re-order remarkup rule blocks to pass tests on PHP7 from to Re-order remarkup rule blocks to pass tests on PHP7.
Oct 26 2015, 7:07 PM
Mnkras edited P1877 (An Untitled Masterwork).
Oct 26 2015, 6:45 PM · Arcanist
Mnkras committed rPHUd5b4421792e5: Remove Exception typehint to fix T9637 (authored by Mnkras).
Remove Exception typehint to fix T9637
Oct 26 2015, 6:34 PM
Mnkras closed D14342: Remove Exception typehint to fix T9637 by committing rPHUd5b4421792e5: Remove Exception typehint to fix T9637.
Oct 26 2015, 6:34 PM
Mnkras closed T9637: Unable to execute arc unit --everything on PHP7 as Resolved by committing rPHUd5b4421792e5: Remove Exception typehint to fix T9637.
Oct 26 2015, 6:34 PM · Arcanist
Mnkras updated the diff for D14342: Remove Exception typehint to fix T9637.

Reform my TODO: markup

Oct 26 2015, 6:25 PM
Mnkras updated the diff for D14342: Remove Exception typehint to fix T9637.

Add a TODO on a test that should have failed in <PHP7 but didn't

Oct 26 2015, 6:23 PM
Mnkras added a comment to D14342: Remove Exception typehint to fix T9637.

Well, maybe this approach is fine, since Throwable seems to pretty much be exactly equivalent to Exception except that the equivalence is done in a PHP way so it's a huge mess.

But we should probably rename all of these from Exception -> Throwable to make it clear, I guess?

Oct 26 2015, 6:17 PM
Mnkras added a comment to D14342: Remove Exception typehint to fix T9637.

I think this is generally correct, but that handleException() should be pretty much unchanged. We should introduce a new handleThrowable() instead, probably, and set_exception_handler() to handleThrowable(), then have that pass the exception to handleException if it is really an Exception.

If it isn't, we should do "something else", but I don't know exactly what that something else is.

Oct 26 2015, 6:16 PM
Mnkras added inline comments to D14342: Remove Exception typehint to fix T9637.
Oct 26 2015, 6:14 PM
Mnkras updated the diff for D14342: Remove Exception typehint to fix T9637.

Remove extra typehint

Oct 26 2015, 6:13 PM
Mnkras added a task to D14342: Remove Exception typehint to fix T9637: T9637: Unable to execute arc unit --everything on PHP7.
Oct 26 2015, 6:12 PM
Mnkras added a revision to T9637: Unable to execute arc unit --everything on PHP7: D14342: Remove Exception typehint to fix T9637.
Oct 26 2015, 6:12 PM · Arcanist
Mnkras retitled D14342: Remove Exception typehint to fix T9637 from to Remove Exception typehint to fix T9637.
Oct 26 2015, 6:11 PM
Mnkras added a comment to T9637: Unable to execute arc unit --everything on PHP7.

Or we could remove the type hint entirely, that may be the easiest and cleanest solution.

Oct 26 2015, 6:03 PM · Arcanist
Mnkras updated the task description for T9637: Unable to execute arc unit --everything on PHP7.
Oct 26 2015, 6:00 PM · Arcanist
Mnkras created T9637: Unable to execute arc unit --everything on PHP7.
Oct 26 2015, 5:53 PM · Arcanist
Mnkras created T9636: arc unit should skip SVN tests if svn binary is not present.
Oct 26 2015, 5:49 PM · Arcanist
Mnkras added a revision to T9635: arc unit throws when there are no tests to run on PHP7: D14340: Fix T9635 by initializing the property.
Oct 26 2015, 4:48 PM · Arcanist
Mnkras retitled D14340: Fix T9635 by initializing the property from to Fix T9635 by initializing the property.
Oct 26 2015, 4:48 PM
Mnkras created T9635: arc unit throws when there are no tests to run on PHP7.
Oct 26 2015, 4:41 PM · Arcanist

Sep 30 2015

Mnkras added a comment to T9485: Fail to execute "arc diff" with exception .

Might also want to check how much memory is available

Sep 30 2015, 3:04 PM · Arcanist

Sep 16 2015

Mnkras added a comment to D14117: Implement a rough AlmanacService blueprint in Drydock.

ab46adf2862c.gif (281×500 px, 745 KB)

Sep 16 2015, 4:03 PM

Sep 1 2015

Mnkras closed T9313: Prueba as Spite.
Sep 1 2015, 9:24 PM · Audit

Jul 29 2015

Mnkras added a comment to T8991: Creating a Phurl URL should validate a URL.

Not sure that is needed, on intranets you can have sites like "http://someserver/some_folder/and.file" which isn't a valid public URL but is valid.

Jul 29 2015, 1:49 AM · Phurl

Jul 26 2015

Mnkras closed T8966: Test 1 as Spite.
Jul 26 2015, 10:45 AM · Space Test Users
Mnkras closed T8967: sub 1, a subtask of T8966: Test 1, as Spite.
Jul 26 2015, 10:45 AM · Space Test Users
Mnkras closed T8967: sub 1 as Spite.
Jul 26 2015, 10:45 AM · Space Test Users
Mnkras closed T8968: sub 2, a subtask of T8966: Test 1, as Spite.
Jul 26 2015, 10:45 AM · Space Test Users
Mnkras closed T8968: sub 2 as Spite.
Jul 26 2015, 10:45 AM · Space Test Users

Jul 24 2015

Mnkras added a comment to T8943: Participant Badge Requests.

Im hungry... I want waffles... and a badge

Jul 24 2015, 1:27 AM · Badges

Jul 21 2015

Mnkras added a comment to T8905: Allow Herald to assign a task back to original author.

I think FreeBSD made an extension for this: https://github.com/freebsd/phabricator/commit/8e442fc85d733ed6ec2890857ac245d86a61f1c0

Jul 21 2015, 5:04 AM · Maniphest, Herald

Jun 27 2015

Mnkras added a comment to T8685: Move secure.phabriactor.com halfway into the cluster.

I had the same thing as @ftdysa but its fine now...

Jun 27 2015, 11:29 PM · Ops

Jun 21 2015

Mnkras closed T8627: Submit button hidden on mobile version of Wikipedia as Invalid.

Hi Mirela,

Jun 21 2015, 3:30 AM

Jun 19 2015

Mnkras added a comment to T8549: Feedback on 2015 Redesign.

This is my personal opinion, but its really bright.

Jun 19 2015, 5:30 AM · Design

Jun 16 2015

Mnkras added a comment to T8549: Feedback on 2015 Redesign.

When I mouse over the [Triangle !] icon they get a bit flashy:

Jun 16 2015, 2:07 AM · Design

Jun 13 2015

Mnkras added a member for Space Test Users: Mnkras.
Jun 13 2015, 7:09 AM

Jun 11 2015

Mnkras updated the task description for T8505: Extending testing functionality.
Jun 11 2015, 3:05 AM · libphutil, Infrastructure

Jun 1 2015

Mnkras added a comment to T8365: Initialization Error .

And the credential was assigned to the repo?

Jun 1 2015, 5:39 AM · Diffusion
Mnkras added a comment to T8365: Initialization Error .

When you setup the import there is a screen that has you add credentials. That would be the ssh key or the password, if you go to the repo in Diffusion you can add the credentials there as well.

Jun 1 2015, 4:56 AM · Diffusion
Mnkras added a comment to T8365: Initialization Error .

Is the repo you are cloning public? or does it require authentication, if it requires authentication, you need to make sure that you have uploaded/generated/added the credentials to phabricator so that it can connect.

Jun 1 2015, 4:34 AM · Diffusion

May 30 2015

Mnkras added a comment to T8365: Initialization Error .

Please make sure you have the correct access rights
and the repository exists.

May 30 2015, 5:51 PM · Diffusion

May 28 2015

Mnkras created T8335: Email verification link doesn't let you verify on first click.
May 28 2015, 3:44 AM · FreeBSD, Auth

May 25 2015

Mnkras added a comment to T8305: Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio.

Im curious if there is any way to edit the inline comment/attachments...

May 25 2015, 1:58 AM · Pholio
Mnkras added a comment to M1435: Brokens?.

Waffles

May 25 2015, 1:56 AM
Mnkras added a comment to T8305: Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio.

Even if it isn't the first transaction the arrow shows and you can't click it, I added a second "inline comment" and as you can see it has an unclickable arrow.

May 25 2015, 1:45 AM · Pholio
Mnkras added an inline comment to M1435: Brokens?.
May 25 2015, 1:44 AM

May 24 2015

Mnkras created T8305: Clicking disclosure triangle next to transactions which only add inline comments has no effect in Pholio.
May 24 2015, 10:56 PM · Pholio
Mnkras added an inline comment to M1435: Brokens?.
May 24 2015, 10:54 PM
Mnkras created M1435: Brokens?.
May 24 2015, 10:53 PM

May 20 2015

Mnkras added a comment to T8263: Orientation bug.

I see the same issue on my nexus 5 on 5.1 chrome beta 43

May 20 2015, 3:00 PM · Mobile

May 18 2015

Mnkras created T8244: Multiple Differential Reticles hide content.
May 18 2015, 5:58 PM · Differential, Quicksand

May 17 2015

Mnkras added a comment to T8121: JS errors when browsing commits in Diffusion.

I just had it happen again, but for some reason the only JS errors I see are these: T8202

May 17 2015, 5:46 AM · Diffusion, Quicksand

May 14 2015

Mnkras created T8202: Comment Preview JS error.
May 14 2015, 10:22 PM · Quicksand
Mnkras added a comment to T8121: JS errors when browsing commits in Diffusion.

@btrahan Iv been busy lately so I haven't been playing with phab :(

May 14 2015, 10:14 PM · Diffusion, Quicksand

May 8 2015

Mnkras added a comment to T8123: Wierd scroll area in header only in Conpherence.

I am on a trackpad :)

May 8 2015, 12:11 AM · Conpherence

May 7 2015

Mnkras added a comment to T8123: Wierd scroll area in header only in Conpherence.

I don't see this on secure or my personal install:

May 7 2015, 11:51 PM · Conpherence
Mnkras added a comment to T8124: Construction of "default" file resources may lose a race with itself.

Im curious if its something cache related, I think I normally notice this after restarting php5-fpm... not sure

May 7 2015, 11:49 PM · Files
Mnkras added a comment to T8124: Construction of "default" file resources may lose a race with itself.

Yea with a refresh it goes away.

May 7 2015, 11:35 PM · Files
Mnkras created T8124: Construction of "default" file resources may lose a race with itself.
May 7 2015, 11:16 PM · Files
Mnkras added a comment to T8122: Unable to scroll on mobile if horizontal scroll is available.

Yea... I don't see it anywhere

May 7 2015, 9:19 PM · Google Chrome, PHUI, Mobile
Mnkras added a comment to T8122: Unable to scroll on mobile if horizontal scroll is available.

But in the other task is there a fancy video? :D

May 7 2015, 9:15 PM · Google Chrome, PHUI, Mobile
Mnkras created T8122: Unable to scroll on mobile if horizontal scroll is available.
May 7 2015, 9:11 PM · Google Chrome, PHUI, Mobile
Mnkras created T8121: JS errors when browsing commits in Diffusion.
May 7 2015, 9:07 PM · Diffusion, Quicksand
Mnkras added a comment to T8117: Choose the most straightforward possible name for a package management application.

whoops posted these in the wrong task:

May 7 2015, 8:58 PM
Mnkras added a comment to T8116: Prototype a package management application.
May 7 2015, 8:56 PM

May 6 2015

chad awarded P1771 (An Untitled Masterwork) a Piece of Eight token.
May 6 2015, 7:51 PM
Mnkras accepted rP597566823e55: Fix a bad Calendar query (missing space in "...event.phidAND...").
May 6 2015, 7:43 PM
Mnkras edited P1771 (An Untitled Masterwork).
May 6 2015, 7:39 PM

May 3 2015

Mnkras created T8047: Differential inline reticle can persist across Quicksand navigations.
May 3 2015, 11:28 PM · Inline Comments, Quicksand

Apr 25 2015

Mnkras added a comment to T7917: Better Duplicate Icon?.

I vote for #1 also

Apr 25 2015, 4:27 AM · Maniphest

Apr 22 2015

Mnkras created T7883: Can't open search items (from header search) in a new window.
Apr 22 2015, 3:16 AM · Search
Mnkras added a comment to T7882: Fatal when viewing commit or searching.

Damn you and your psychic powers!

Apr 22 2015, 3:07 AM · Search, Diffusion
Mnkras changed the status of T7882: Fatal when viewing commit or searching from Resolved to Invalid.

whoops

Apr 22 2015, 3:02 AM · Search, Diffusion
Mnkras closed T7882: Fatal when viewing commit or searching as Resolved.

It did :/ thats random (would not have thought of that)

Apr 22 2015, 3:01 AM · Search, Diffusion
Mnkras added a comment to T7880: Notifications are broken.

He uses Doge because of my awesome translations, right @epriestley ;)

Apr 22 2015, 2:58 AM · Aphlict
Mnkras created T7882: Fatal when viewing commit or searching.
Apr 22 2015, 2:56 AM · Search, Diffusion

Apr 19 2015

Mnkras created T7857: Conpherence participants are sorted by alpha, but with capital letters first.
Apr 19 2015, 4:01 PM · Conpherence

Apr 12 2015

Mnkras created T7808: Guests can create a workboard for a project.
Apr 12 2015, 7:42 PM · Policy, Projects
Mnkras created T7806: Viewing diff with anchor in url makes page jumpy.
Apr 12 2015, 1:03 AM · Google Chrome, Diffusion

Apr 9 2015

Mnkras accepted D12337: Fix bad rendering for custom policy descriptions.
Apr 9 2015, 8:10 PM

Apr 7 2015

Mnkras updated the diff for D12312: Wowify translations.

Spacing?

Apr 7 2015, 10:53 PM