Page MenuHomePhabricator

Notifications are broken
Closed, InvalidPublic

Description

It seems that notifications are broken at HEAD (I just updated this morning). I can reproduce this by going to https://secure.phabricator.com/notification/status/ and clicking the "Send Test Notification" button... no notification is generated.

Running the Aphlict server in debug mode and it seems that the Aphlict client isn't connecting to the server:

josh@ip-10-154-233-161:/usr/src/phabricator$ sudo -u aphlict ./bin/aphlict debug
Starting Aphlict server in foreground...
Launching server:

    $ 'nodejs' '/usr/src/phabricator/support/aphlict/server/aphlict_server.js' '--client-port=' '--admin-port=22281' '--admin-host=notifications.phabricator.example.com' '--log=/mnt/logs/phd/aphlict.log'

[Tue Apr 21 2015 21:10:42 GMT-0400 (EDT)] Started Server (PID 25585)
[Tue Apr 21 2015 21:10:50 GMT-0400 (EDT)] Received notification (/ws/): {"key":"6140364635350858376","type":"notification","subscribers":["PHID-USER-abzwhc667osh5mwd4gk7"]}
[Tue Apr 21 2015 21:11:10 GMT-0400 (EDT)] Received notification (/ws/): {"key":"6140364722522583513","type":"notification","subscribers":["PHID-USER-abzwhc667osh5mwd4gk7","PHID-USER-inwz7rtaiuxgmjduhmmq","PHID-USER-bz6h6qr3rnvduuvt2dfa","PHID-USER-mw6ockgrrgytq3d3yywa","PHID-USER-zalu2g5i2e3tpp62so6r","PHID-USER-3u5vybbidp7ael5ebh6z","PHID-USER-fe5ogccly4vh32ncsr3g"]}
[Tue Apr 21 2015 21:11:11 GMT-0400 (EDT)] Received notification (/ws/): {"key":"6140364726029263184","type":"notification","subscribers":["PHID-USER-abzwhc667osh5mwd4gk7","PHID-USER-inwz7rtaiuxgmjduhmmq","PHID-USER-mw6ockgrrgytq3d3yywa","PHID-USER-3u5vybbidp7ael5ebh6z"]}
[Tue Apr 21 2015 21:11:11 GMT-0400 (EDT)] Received notification (/ws/): {"key":"6140364726786271339","type":"notification","subscribers":["PHID-USER-abzwhc667osh5mwd4gk7","PHID-USER-inwz7rtaiuxgmjduhmmq","PHID-USER-mw6ockgrrgytq3d3yywa","PHID-USER-3u5vybbidp7ael5ebh6z"]}
[Tue Apr 21 2015 21:11:14 GMT-0400 (EDT)] Received notification (/ws/): {"key":"6140364740738710091","type":"notification","subscribers":[]}
[Tue Apr 21 2015 21:12:58 GMT-0400 (EDT)] Received notification (/ws/): {"key":"6140365187631354850","type":"notification","subscribers":["PHID-USER-abzwhc667osh5mwd4gk7","PHID-USER-inwz7rtaiuxgmjduhmmq","PHID-USER-bz6h6qr3rnvduuvt2dfa","PHID-USER-mw6ockgrrgytq3d3yywa","PHID-USER-zalu2g5i2e3tpp62so6r","PHID-USER-hfenohlvucsbthy2su73","PHID-USER-fe5ogccly4vh32ncsr3g"]}
[Tue Apr 21 2015 21:13:01 GMT-0400 (EDT)] Received notification (/ws/): {"key":"6140365194686820164","type":"notification","subscribers":[]}

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Aphlict.
joshuaspence added a subscriber: joshuaspence.

I can't immediately reproduce this (see lower left corner):

Screen_Shot_2015-04-21_at_6.15.24_PM.png (1×1 px, 378 KB)

I have no idea what "this morning" means time wise in NZ to CA, haha

In T7880#108085, @chad wrote:

I have no idea what "this morning" means time wise in NZ to CA, haha

NZ? I'm insulted. I'm from AUS.

khaaaan

Actually, our firewall might be blocking port 22280... that's one of the reasons that I run Aphlict over port 443.

Actually, our firewall might be blocking port 22280... that's one of the reasons that I run Aphlict over port 443.

Hm, nope. I tried it outside of the firewall and still received no notification.

Do you have the durable chat column open?

Do you have a setup warning?

Hmm, looking in the network tab in Chrome and I can't actually see a websocket connection.

Do you have the durable chat column open?

Nope.

In T7880#108100, @chad wrote:

Do you have a setup warning?

Nope.

Weird, the notifications did come through on my phone.

He uses Doge because of my awesome translations, right @epriestley ;)

Hi

I just set up notifications fine here on d8ab5f594c7f9cd05e333f507f2ae26e55c6b411

One thing I had to do was manually feed to aphlict --client-port=22280 otherwise it would not listen on that port, according to netstat. Is this a misconfiguration?

The notifications area says "Connected" and test notifications come across fine so I don't think so. If I remove the argument, things stop working. I see in the output above that '--client-port='.

Here's my PHP -v:

PHP 5.4.39-0+deb7u2

Here's my node -v:

v0.12.2

This is on Debian Wheezy with nginx/wheezy-backports after I made the stupid mistake of trying things over and over with nginx 1.2.1 then re-reading the documentation. PHP is from the stable repositories, nodejs is from a git clone of the version tag above.

joshuaspence claimed this task.

This has magically fixed itself.