Paths

Table of Contentst

Allow any {icon} to spin
ClosedPublic
Actions

Authored by epriestley on Oct 30 2015, 4:00 PM.

Tags

None

Referenced Files

	F14061424: D14369.diff
	Mon, Nov 18, 6:34 AM

	F14034018: D14369.diff
	Sat, Nov 9, 9:30 PM

	F14026482: D14369.id34694.diff
	Fri, Nov 8, 1:21 AM

	F14026481: D14369.id34692.diff
	Fri, Nov 8, 1:21 AM

	F14026480: D14369.id.diff
	Fri, Nov 8, 1:21 AM

	F14026479: D14369.diff
	Fri, Nov 8, 1:21 AM

	F14020112: D14369.diff
	Tue, Nov 5, 11:59 PM

	F14004136: D14369.id34692.diff
	Sat, Oct 26, 3:59 PM

Subscribers

Tokens

"Manufacturing Defect?" token, awarded by avivey.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP096117aacded: Allow any {icon} to spin

Summary

We are greedily hoarding this for ourselves, when we could enrich the world.

Test Plan

Used {icon cog spin}.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34692.Oct 30 2015, 4:00 PM

epriestley retitled this revision from to Allow any {icon} to spin.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Oct 30 2015, 4:00 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 30 2015, 4:00 PM

Closed by commit rP096117aacded: Allow any {icon} to spin (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2015, 4:02 PM

This revision was automatically updated to reflect the committed changes.

My favorite commit of 2015.

I think we need a theyseemerolling macro for the occasion

I really hoped that this allowed the ability to spin memes, but I was disappointed

avivey awarded a token.Oct 30 2015, 11:45 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

markup/

PhabricatorIconRemarkupRule.php

11 lines

docs/

user/

userguide/

remarkup.diviner

6 lines

Diff 34694

View Options

src/applications/macro/markup/PhabricatorIconRemarkupRule.php