Page MenuHomePhabricator
Differential D14369

Allow any {icon} to spin
ClosedPublic
Actions

Authored by epriestley on Oct 30 2015, 4:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 12:01 AM
Unknown Object (File)
Tue, Nov 26, 1:49 PM
Unknown Object (File)
Fri, Nov 22, 10:16 PM
Unknown Object (File)
Tue, Nov 19, 5:17 PM
Unknown Object (File)
Nov 18 2024, 6:34 AM
Unknown Object (File)
Nov 9 2024, 9:30 PM
Unknown Object (File)
Nov 8 2024, 1:21 AM
Unknown Object (File)
Nov 8 2024, 1:21 AM
View All Files
Subscribers
joshuaspence
Mnkras
talshiri
tycho.tatitscheff
Tokens
"Manufacturing Defect?" token, awarded by avivey.

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rP096117aacded: Allow any {icon} to spin
Summary

We are greedily hoarding this for ourselves, when we could enrich the world.

Test Plan

Used {icon cog spin}.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34692.Oct 30 2015, 4:00 PM
epriestley retitled this revision from to Allow any {icon} to spin.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Oct 30 2015, 4:00 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 30 2015, 4:00 PM
Closed by commit rP096117aacded: Allow any {icon} to spin (authored by epriestley, committed by epriestley). · Explain WhyOct 30 2015, 4:02 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence added a subscriber: joshuaspence.Oct 30 2015, 9:21 PM

talshiri added a subscriber: talshiri.Oct 30 2015, 10:09 PM

My favorite commit of 2015.

tycho.tatitscheff added a subscriber: tycho.tatitscheff.Oct 30 2015, 10:28 PM

I think we need a theyseemerolling macro for the occasion

Mnkras added a subscriber: Mnkras.Oct 30 2015, 11:38 PM

I really hoped that this allowed the ability to spin memes, but I was disappointed

avivey awarded a token.Oct 30 2015, 11:45 PM

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
markup/
11 lines
docs/
user/
userguide/
6 lines

Diff 34694

View Options

src/applications/macro/markup/PhabricatorIconRemarkupRule.php

Loading...
View Options

src/docs/user/userguide/remarkup.diviner

Loading...
Phabricator · Built by Phacility