Page MenuHomePhabricator

Set a property so that unit tests run on PHP7
ClosedPublic

Authored by Mnkras on Oct 26 2015, 7:34 PM.

Details

Summary

Without this change PHP throws because idx() is passed null as the property is not intialzied

Test Plan

arc unit --everything

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Mnkras updated this revision to Diff 34618.Oct 26 2015, 7:34 PM
Mnkras retitled this revision from to Set a property so that unit tests run on PHP7.
Mnkras updated this object.
Mnkras edited the test plan for this revision. (Show Details)
epriestley accepted this revision.Oct 26 2015, 7:37 PM
epriestley added a reviewer: epriestley.

If you hold this for a bit you can try "Land Revision".

This revision is now accepted and ready to land.Oct 26 2015, 7:38 PM
This revision was automatically updated to reflect the committed changes.