Page MenuHomePhabricator

Set a property so that unit tests run on PHP7
ClosedPublic

Authored by Mnkras on Oct 26 2015, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 25, 6:33 AM
Unknown Object (File)
Sun, May 18, 12:28 PM
Unknown Object (File)
Thu, May 15, 6:14 PM
Unknown Object (File)
Apr 29 2025, 12:29 PM
Unknown Object (File)
Apr 27 2025, 7:15 PM
Unknown Object (File)
Apr 26 2025, 8:10 PM
Unknown Object (File)
Apr 23 2025, 10:41 PM
Unknown Object (File)
Apr 20 2025, 6:04 PM
Subscribers

Details

Summary

Without this change PHP throws because idx() is passed null as the property is not intialzied

Test Plan

arc unit --everything

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Mnkras retitled this revision from to Set a property so that unit tests run on PHP7.
Mnkras updated this object.
Mnkras edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

If you hold this for a bit you can try "Land Revision".

This revision is now accepted and ready to land.Oct 26 2015, 7:38 PM
This revision was automatically updated to reflect the committed changes.