This is also a notable backward-incompatible change to projects which define their own lint engines; all places which generate their own ArcanistLintExceptions by hand need to be checked to ensure that they call setName. This upgrading note likely bears documenting somewhere.

Yep, thanks much for your assistance. I appreciate the product!

Presuming resolved since D13931 is in HEAD. Thanks for the report!

It's been a while since I've worked on this, but IIRC, it was with some of the rules that look at the entire project; e.g., FC011. Nothing that can't be fixed or configured to work.

I think this change is correct and the analysis backing it up looks accurate.

See http://www.phpwtf.org/poor-parser-easily-confused

It's default configuration on CentOS to use same php.ini (which defines memory limit) for both FCGI PHP module (for Nginx), Mod_Php for Apache and CLI. Actually it's 1st time I hear, that PHP in CLI should have no memory limit by default. It doesn't have time limit, because it's not web request, but it surely always had memory limits.

Why do you have a memory limit configured on the CLI? Do you legitimately want scripts to exit after consuming 128MB of RAM, or is this just a default you haven't changed?

Yeah, basically strncmp has worst-case runtime O(length(needle)) while strpos has worst-case runtime O(length(haystack) * length(needle)).

Interesting... okay, thanks for clarifying.

Try with a 10MB haystack.

Will leave it open for now if anyone passing by has additional thoughts. If you can list the exact steps to reproduce, that would be helpful too (like which shells specifically have been tested).

Sorry, this is just in "fishing expedition" land, and we're not staffed to help you further. Nothing sounds like an issue with Phabricator.

normal shell has the same problem.

(These questions are way better suited for Stack Overflow or Google).

Try a normal shell?

I check the code, find that arcanist try to execute "where php" and "where phpcs" to find the path of them.
But the Git Bash doesn't have "where" command, only has "which" command. I copy which to where, but it still doesn't work.

Do you have any suggestions about it? In the Win8 Git Bash shell, I can run phpcs and php, But arc lint still tells me that it can not find them.

We haven't had other reports, unfortunately, and nothing specific comes to mind.

any feedback about this issue?

This might be sort of a copy of T7617.

Sorry, I didn't create this task so I have no idea about whats happening here much. The actual concrete tasks were discussed in the one on one with Phacility.

@devd, I want to make sure I understand this correctly -- the task seems to be about making one specific use case of lint easier (not linting in general) but is vague about what that use case is.

Foodcritic has a few quirks in its interaction with Arcanist

The discovery map is something that looks like this:

Not sure where this is going but I believe it's still on hold. I've release https://github.com/kalbasit/arcanist-go that I'm using personally and also at work. @joshuaspence and @chad please let me know when the Phabricator team is ready to accept these patches and I'll update all of my differentials.

Another issue, if I lint this file twice, I get extra indentation unintentionally:

+1 I just encountered the same experience

I think that the warnings generate by Diviner (I don't believe these are surfaced in the UI currently) should be moved to a Diviner linter.

Also looks like the output format for cpplint has changed due to 4330b27

I started working on this in D13094, but it's nowhere near finished.