Page MenuHomePhabricator

cpplint no longer works
Closed, DuplicatePublic

Description

Couple things:

  • Looks like the name changed from cpplint.py to cpplint. This is I just fixed with a symlink
  • Looks like the arc diff invocation process bails out if the linter exits with a non-0 status
Linting...
Exception
Some linters failed:
    - CommandException: Command failed with error #1!
      COMMAND
      'cpplint' '/home/seth/p3/jit.h'
      
      STDOUT
      (empty)
      
      STDERR
      /home/seth/p3/jit.h:10:  Do not indent within a namespace  [runtime/indentation_namespace] [4]
      ...
(Run with `--trace` for a full exception trace.)

If I manually set the exit status to 0, it seems like it decides that there are no linter errors:

Linting...
 LINT OKAY  No lint problems.
Running unit tests...
No unit test engine is configured for this project.
 SKIP STAGING  Unable to determine repository for this change.
Created a new Differential revision:

Event Timeline

sshannin raised the priority of this task from to Needs Triage.
sshannin updated the task description. (Show Details)
sshannin added a project: Lint.
sshannin added a subscriber: sshannin.