Page MenuHomePhabricator
Create Task
Maniphest T2077

Write CSS Linter
Open, NormalPublic
Actions

Description

See D3955. We should develop a CSS style guide and enforce it with lint, similar to the JS and PHP guides.

Proposed rules:

  • Write colors using lowercase ("#a12345", not "#A12345").
  • Write colors in the most compact form (if @chad wants -- this happens in minification anyway).
  • No rule alphabetization -- see https://secure.phabricator.com/D3223#comment-15 for my rationale. I'm fine with alphabetizing or enforcing some other order if you guys prefer.
  • Omit quotes for url() (this gets rewritten in minification anyway).
  • Single space after :; do not align rule bodies.

Flexible on any of this, but we should pick some set of rules and then apply it to the whole codebase.

Related Objects
Search...

StatusAssignedTask
Restricted Maniphest Task
 OpenepriestleyT2077 Write CSS Linter

Event Timeline

epriestley claimed this task.Nov 15 2012, 10:02 PM
epriestley triaged this task as Normal priority.
epriestley added a project: Arcanist.
epriestley added subscribers: epriestley, chad, btrahan, vrana.
vrana added a comment.Nov 15 2012, 10:56 PM

I personally use all of these and I agree with them. We should probably also have some rule for indenting.

epriestley added a comment.Dec 30 2012, 10:02 PM

See also T2253 -- I moved all the z-index rules to "z-index.css" to make them easier to keep track of. We should detect new z-index rules not in the z-index.css file, so long as we're keeping our z-indexes in a single file.

epriestley edited this Maniphest Task.Jun 26 2013, 1:28 PM
joshuaspence added a subscriber: joshuaspence.Jan 3 2014, 1:55 PM
chad added a project: Lint.Dec 15 2014, 4:23 AM
chad changed the visibility from "All Users" to "Public (No Login Required)".Jul 3 2015, 4:07 AM
chad removed a project: Arcanist.Jan 30 2016, 4:46 AM
Phabricator · Built by Phacility