Page MenuHomePhabricator

eMxyzptlk (Wael M. Nasreddine)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 22 2015, 11:42 PM (293 w, 2 d)
Availability
Available

Recent Activity

May 3 2017

jcox awarded D12620: Add GoFmt linter a Like token.
May 3 2017, 3:18 PM
jcox awarded D12120: Add GoVet Linter a Like token.
May 3 2017, 3:17 PM

Aug 20 2016

rayzyar awarded D12120: Add GoVet Linter a Party Time token.
Aug 20 2016, 6:16 PM

Sep 14 2015

jra3 awarded D9858: JIRA Integration: Link and/or Comment a Mountain of Wealth token.
Sep 14 2015, 9:02 PM · Doorkeeper
eMxyzptlk updated the diff for D9858: JIRA Integration: Link and/or Comment.
  • Merge branch 'master' into arcpatch-D9858
Sep 14 2015, 8:44 PM · Doorkeeper

Aug 12 2015

eMxyzptlk added a comment to D12120: Add GoVet Linter.

@ryansking it looks like this is going to have to wait Blessed Reviewers planning. In the meantime you can use this and all of my Go stuff from https://github.com/kalbasit/arcanist-go

Aug 12 2015, 10:13 PM
eMxyzptlk updated the diff for D9858: JIRA Integration: Link and/or Comment.
  • Merge remote-tracking branch 'origin/master' into arcpatch-D9858
  • Merge remote-tracking branch 'origin/master' into arcpatch-D9858
Aug 12 2015, 10:10 PM · Doorkeeper

Jul 16 2015

eMxyzptlk added a comment to T6867: Add linter and unit test engine for Go(lang).

Not sure where this is going but I believe it's still on hold. I've release https://github.com/kalbasit/arcanist-go that I'm using personally and also at work. @joshuaspence and @chad please let me know when the Phabricator team is ready to accept these patches and I'll update all of my differentials.

Jul 16 2015, 7:26 AM · Lint

Jul 14 2015

eMxyzptlk updated the diff for D9858: JIRA Integration: Link and/or Comment.
  • Merge branch 'master' into arcpatch-D9858
  • getGroup is an abstract function of PhabricatorApplicationConfigOptions that must be implemented
  • render a locally hosted icon 16x16
  • Merge remote-tracking branch 'origin/master' into arcpatch-D9858
  • Merge remote-tracking branch 'origin/master' into arcpatch-D9858
  • fix lint issues.
Jul 14 2015, 10:20 PM · Doorkeeper
eMxyzptlk commandeered D9858: JIRA Integration: Link and/or Comment.

Thanks a lot @turadg. We are using this at Dailymotion and I promise I will keep it up to date (at least once a month). Please feel free to Commandeer it back if you'd like to make changes to it.

Jul 14 2015, 10:07 PM · Doorkeeper

Jul 7 2015

eMxyzptlk added a comment to D9858: JIRA Integration: Link and/or Comment.

@turadg can you please update this revision on top of master? I have already done so myself, I can Commandeer the revision and push my version if you'd like to.

Jul 7 2015, 5:48 PM · Doorkeeper

Jul 1 2015

eMxyzptlk added a comment to D9858: JIRA Integration: Link and/or Comment.

@epriestley can you please elaborate as to why this is classified as an unsupported patch as mentioned in T5422?

Jul 1 2015, 8:15 AM · Doorkeeper

May 8 2015

eMxyzptlk added a comment to T8069: Exception: Argument 1 passed to DifferentialChangesetHTMLRenderer::renderImageStage().

It just happened to me as well, here's the stack-trace:

May 8 2015, 7:18 PM · Differential

May 5 2015

eMxyzptlk added inline comments to D12120: Add GoVet Linter.
May 5 2015, 10:05 PM
eMxyzptlk added a comment to D12120: Add GoVet Linter.

PTAL

May 5 2015, 5:13 PM
eMxyzptlk updated the diff for D12120: Add GoVet Linter.
  • implement getVersion
May 5 2015, 5:12 PM
eMxyzptlk updated the diff for D12120: Add GoVet Linter.
May 5 2015, 5:07 PM

Apr 30 2015

eMxyzptlk added a comment to D12621: Add a Go unit test engine with support for Race and Godep..
Apr 30 2015, 5:49 PM
eMxyzptlk updated the diff for D12621: Add a Go unit test engine with support for Race and Godep..

Address @sectioneight 's comment.

Apr 30 2015, 5:49 PM
eMxyzptlk added a comment to D12621: Add a Go unit test engine with support for Race and Godep..

@sectioneight Let's add coverage support once this D gets merged.

Apr 30 2015, 10:43 AM
eMxyzptlk updated D12621: Add a Go unit test engine with support for Race and Godep..
Apr 30 2015, 10:41 AM
eMxyzptlk retitled D12621: Add a Go unit test engine with support for Race and Godep. from Add a Go unit test engine with support for Race, Coverage and Godep. to Add a Go unit test engine with support for Race and Godep..
Apr 30 2015, 10:40 AM
eMxyzptlk abandoned D12546: Add support for the race detector in the parser.

Closed in favor of D12621

Apr 30 2015, 10:39 AM
eMxyzptlk abandoned D12537: Add a Go unit test engine (through go and godep)..

Closed in favor of D12621

Apr 30 2015, 10:39 AM
eMxyzptlk abandoned D12598: Add a Go unit test engine with race detection (through go and godep)..

Closed in favor of D12621

Apr 30 2015, 10:38 AM
eMxyzptlk retitled D12621: Add a Go unit test engine with support for Race and Godep. from to Add a Go unit test engine with support for Race, Coverage and Godep..
Apr 30 2015, 10:37 AM
eMxyzptlk added a revision to T6867: Add linter and unit test engine for Go(lang): D12621: Add a Go unit test engine with support for Race and Godep..
Apr 30 2015, 10:37 AM · Lint
eMxyzptlk updated D12620: Add GoFmt linter.
Apr 30 2015, 5:54 AM
sectioneightinc awarded D12620: Add GoFmt linter a Like token.
Apr 30 2015, 5:49 AM
eMxyzptlk retitled D12620: Add GoFmt linter from to Add GoFmt linter.
Apr 30 2015, 5:43 AM
eMxyzptlk added a revision to T6867: Add linter and unit test engine for Go(lang): D12620: Add GoFmt linter.
Apr 30 2015, 5:43 AM · Lint
eMxyzptlk added a comment to D12537: Add a Go unit test engine (through go and godep)..

I have a version of this with coverage support if you're interested:

Apr 30 2015, 4:25 AM
eMxyzptlk added revisions to T6867: Add linter and unit test engine for Go(lang): D12537: Add a Go unit test engine (through go and godep)., D12546: Add support for the race detector in the parser, D12598: Add a Go unit test engine with race detection (through go and godep)..
Apr 30 2015, 1:41 AM · Lint
eMxyzptlk added a task to D12546: Add support for the race detector in the parser: T6867: Add linter and unit test engine for Go(lang).
Apr 30 2015, 1:41 AM
eMxyzptlk added a task to D12537: Add a Go unit test engine (through go and godep).: T6867: Add linter and unit test engine for Go(lang).
Apr 30 2015, 1:41 AM
eMxyzptlk added a task to D12598: Add a Go unit test engine with race detection (through go and godep).: T6867: Add linter and unit test engine for Go(lang).
Apr 30 2015, 1:41 AM

Apr 28 2015

eMxyzptlk updated the diff for D12598: Add a Go unit test engine with race detection (through go and godep)..
  • send the stderr before the stdout so we could parse the race condition
  • Merge branch 'go-unit-race-engine' into go-race-engine
Apr 28 2015, 8:33 PM
eMxyzptlk updated the diff for D12546: Add support for the race detector in the parser.
  • The race warning lives in STDERR so parse it assuming it comes first
Apr 28 2015, 8:30 PM
eMxyzptlk updated the diff for D12546: Add support for the race detector in the parser.
  • The race warning lives in STDERR so parse it assuming it comes first
Apr 28 2015, 8:28 PM
eMxyzptlk planned changes to D12598: Add a Go unit test engine with race detection (through go and godep)..

D12546 is broken and must be fixed and merged here.

Apr 28 2015, 7:48 PM
eMxyzptlk planned changes to D12546: Add support for the race detector in the parser.

Go test is sending the output of the racer to STDERR while sending the rest to STDOUT, so the format seen by exec_manual is not the same as seen on the terminal.

Apr 28 2015, 7:47 PM
eMxyzptlk retitled D12598: Add a Go unit test engine with race detection (through go and godep). from to Add a Go unit test engine with race detection (through go and godep)..
Apr 28 2015, 7:34 PM

Apr 25 2015

eMxyzptlk updated the diff for D12546: Add support for the race detector in the parser.
  • consider the race condition a failure by itself regardless of the actual testing
Apr 25 2015, 7:20 AM
eMxyzptlk retitled D12546: Add support for the race detector in the parser from to Add support for the race detector in the parser.
Apr 25 2015, 6:57 AM

Apr 24 2015

eMxyzptlk updated the diff for D12537: Add a Go unit test engine (through go and godep)..
  • Fix GodepGoTestEngine by requiring an sprintf format
Apr 24 2015, 11:47 PM
eMxyzptlk added a comment to D12120: Add GoVet Linter.

Thank you @sectioneight, it's done.

Apr 24 2015, 8:32 PM
eMxyzptlk updated the diff for D12120: Add GoVet Linter.
  • switch to using $config on a per-file basis
Apr 24 2015, 8:30 PM
eMxyzptlk updated the diff for D12537: Add a Go unit test engine (through go and godep)..
  • remove an accidently left 'echo'
Apr 24 2015, 8:28 AM
eMxyzptlk retitled D12537: Add a Go unit test engine (through go and godep). from to Add a Go unit test engine (through go and godep)..
Apr 24 2015, 8:24 AM
eMxyzptlk updated D12120: Add GoVet Linter.
Apr 24 2015, 6:48 AM
eMxyzptlk updated the diff for D12120: Add GoVet Linter.

Revert an accidental change

Apr 24 2015, 6:47 AM
eMxyzptlk updated the diff for D12120: Add GoVet Linter.

The class now correcly detects the absence of 'go tool vet' by running it and inspecting the exit status.
Reference (of exit status 3): https://github.com/golang/go/blob/5f8423844463b3b77588e46ea57f44d8b69a1564/src/cmd/go/tool.go#L56-L64

Apr 24 2015, 6:45 AM
eMxyzptlk updated the diff for D12120: Add GoVet Linter.

Removing the tab does not break the tests.

Apr 24 2015, 5:05 AM
eMxyzptlk updated the diff for D12120: Add GoVet Linter.
  • Lint the code following the automatic code review.
Apr 24 2015, 5:04 AM
eMxyzptlk updated the diff for D12120: Add GoVet Linter.
  • Add optional argument 'tempFileSuffix' to ArcanistLinterTestCase->executeTestsInDirectory(), this argument is sent as is to ArcanistLinterTestCase->lintFile.
  • Add optional argument 'tempFileSuffix' to ArcanistLinterTestCase->lintFile, if present, the temp file created for the test will be given the 'tempFileSuffix' as extension.
Apr 24 2015, 5:01 AM
eMxyzptlk commandeered D12120: Add GoVet Linter.
Apr 24 2015, 4:55 AM
eMxyzptlk added a comment to D12120: Add GoVet Linter.

Any updates about this change?

Apr 24 2015, 3:06 AM