• Merge branch 'master' into arcpatch-D9858

@ryansking it looks like this is going to have to wait Blessed Reviewers planning. In the meantime you can use this and all of my Go stuff from https://github.com/kalbasit/arcanist-go

• Merge remote-tracking branch 'origin/master' into arcpatch-D9858
• Merge remote-tracking branch 'origin/master' into arcpatch-D9858

Not sure where this is going but I believe it's still on hold. I've release https://github.com/kalbasit/arcanist-go that I'm using personally and also at work. @joshuaspence and @chad please let me know when the Phabricator team is ready to accept these patches and I'll update all of my differentials.

• Merge branch 'master' into arcpatch-D9858
• getGroup is an abstract function of PhabricatorApplicationConfigOptions that must be implemented
• render a locally hosted icon 16x16
• Merge remote-tracking branch 'origin/master' into arcpatch-D9858
• Merge remote-tracking branch 'origin/master' into arcpatch-D9858
• fix lint issues.

Thanks a lot @turadg. We are using this at Dailymotion and I promise I will keep it up to date (at least once a month). Please feel free to Commandeer it back if you'd like to make changes to it.

@turadg can you please update this revision on top of master? I have already done so myself, I can Commandeer the revision and push my version if you'd like to.

@epriestley can you please elaborate as to why this is classified as an unsupported patch as mentioned in T5422?

It just happened to me as well, here's the stack-trace:

PTAL

• implement getVersion

• address @joshuaspence 's comments

Address @sectioneight 's comment.

@sectioneight Let's add coverage support once this D gets merged.

Closed in favor of D12621

Closed in favor of D12621

Closed in favor of D12621

In D12537#127749, @sectioneight wrote:

I have a version of this with coverage support if you're interested:

• send the stderr before the stdout so we could parse the race condition
• Merge branch 'go-unit-race-engine' into go-race-engine

• The race warning lives in STDERR so parse it assuming it comes first

• The race warning lives in STDERR so parse it assuming it comes first

D12546 is broken and must be fixed and merged here.

Go test is sending the output of the racer to STDERR while sending the rest to STDOUT, so the format seen by exec_manual is not the same as seen on the terminal.

• consider the race condition a failure by itself regardless of the actual testing

• Fix GodepGoTestEngine by requiring an sprintf format

Thank you @sectioneight, it's done.

• switch to using $config on a per-file basis

• remove an accidently left 'echo'

Revert an accidental change

The class now correcly detects the absence of 'go tool vet' by running it and inspecting the exit status.
Reference (of exit status 3): https://github.com/golang/go/blob/5f8423844463b3b77588e46ea57f44d8b69a1564/src/cmd/go/tool.go#L56-L64

Removing the tab does not break the tests.

• Lint the code following the automatic code review.

• Add optional argument 'tempFileSuffix' to ArcanistLinterTestCase->executeTestsInDirectory(), this argument is sent as is to ArcanistLinterTestCase->lintFile.
• Add optional argument 'tempFileSuffix' to ArcanistLinterTestCase->lintFile, if present, the temp file created for the test will be given the 'tempFileSuffix' as extension.

Any updates about this change?