Page MenuHomePhabricator
Feed Advanced Search

Jun 17 2015

joshuaspence created T8595: Don't show CSRF exception in the error logs.
Jun 17 2015, 10:54 PM · Security
avivey awarded T8593: Allow files to have a description a Doubloon token.
Jun 17 2015, 10:43 PM · Restricted Project, Files
joshuaspence created T8593: Allow files to have a description.
Jun 17 2015, 10:31 PM · Restricted Project, Files
joshuaspence added a comment to T7483: Invalid argument supplied for foreach.

I'm still seeing this errors.

Jun 17 2015, 9:47 PM · Differential
joshuaspence created T8591: Undefined index in changeset parser.
Jun 17 2015, 9:47 PM · Differential
joshuaspence created T8590: Send outbound email when task is created via inbound email.
Jun 17 2015, 9:44 PM · Maniphest, Mail
joshuaspence edited P1809 sshd_config.
Jun 17 2015, 9:36 PM
joshuaspence created T8589: INI File Paste.
Jun 17 2015, 9:29 PM · Paste
joshuaspence edited P1808 config.json.
Jun 17 2015, 9:29 PM
joshuaspence edited P1807 phabricator-ssh-hook.
Jun 17 2015, 9:15 PM · Diffusion
joshuaspence edited projects for T8582: Can't create projects, added: Projects; removed Aphront.
Jun 17 2015, 8:51 PM · Projects
joshuaspence edited P1806 Masterwork From Distant Lands.
Jun 17 2015, 11:27 AM
joshuaspence added a project to T8444: Increase typeahead speed: Typeahead.
Jun 17 2015, 10:04 AM · Typeahead, PHUI, Restricted Project
joshuaspence added a project to T8552: Increase user control over document hierarchy in Phriction: Phriction.
Jun 17 2015, 10:00 AM · Phriction, Restricted Project
joshuaspence added a project to T8557: Pull of repo failed after deleting branch on GitHub + pushing commits: Diffusion.
Jun 17 2015, 10:00 AM · Diffusion
joshuaspence added a project to T8566: Specify branch in commit email: Diffusion.
Jun 17 2015, 9:59 AM · Diffusion, Restricted Project
joshuaspence added a project to T8570: Improve browsability of directories which change name frequently: Diffusion.
Jun 17 2015, 9:58 AM · Diffusion (v3), Restricted Project, Restricted Project
joshuaspence added a project to T8572: Prompt for incomplete/unsaved inline comments upon creating a new comment instead of doing nothing: Differential.
Jun 17 2015, 9:58 AM · Prioritized, Differential, Restricted Project
joshuaspence added a project to T8573: All reviewers should be allowed to mark a comment as done: Differential.
Jun 17 2015, 9:57 AM · Restricted Project, Differential, Restricted Project
joshuaspence created T8578: Provide a way to remove things from the search index.
Jun 17 2015, 7:41 AM · Search
joshuaspence added a comment to T8576: Indexing search documents uses a lot of memory.

I ran this same command on a separate host and stopped the phd daemons before running the command. Doing so allowed the command to complete successfully.

Jun 17 2015, 7:04 AM · Search
joshuaspence created T8576: Indexing search documents uses a lot of memory.
Jun 17 2015, 3:48 AM · Search
joshuaspence added a comment to T8549: Feedback on 2015 Redesign.

Yeah, I find the exclamation icons to be too harsh (especially for the "accepted" state).

Jun 17 2015, 2:18 AM · Design
joshuaspence awarded T8575: Reap easy performance improvements a Mountain of Wealth token.
Jun 17 2015, 1:19 AM · Performance

Jun 16 2015

joshuaspence updated subscribers of T8258: Allow comments in JSON.
Jun 16 2015, 9:06 PM · Restricted Project, libphutil, Arcanist
joshuaspence merged task T8569: Add "_comment" field to map for linter JSON files into T8258: Allow comments in JSON.
Jun 16 2015, 9:06 PM · Arcanist, Lint
joshuaspence added a revision to T4558: Make Diviner useful for third-parties: Unknown Object (Differential Revision).
Jun 16 2015, 12:41 PM · Diviner
joshuaspence updated subscribers of T1849: Show file history beyond moves and copies.
Jun 16 2015, 11:47 AM · Diffusion
joshuaspence claimed T2284: Make Diviner namespace aware.
Jun 16 2015, 11:45 AM · Documentation, Diviner
joshuaspence claimed T1621: In Git, clean up local tags that are no longer present in the remote.
Jun 16 2015, 11:43 AM · Restricted Project, Diffusion
joshuaspence added a revision to T4558: Make Diviner useful for third-parties: Unknown Object (Differential Revision).
Jun 16 2015, 10:20 AM · Diviner
joshuaspence added a project to T8560: arc shell-complete gives error when out of workspace: Arcanist.
Jun 16 2015, 8:38 AM · Arcanist
joshuaspence added a comment to T8562: Newlines are destroyed in outbound email.
> ./bin/mail show-outbound --id 1246623
PROPERTIES
ID: 1246623
Status: sent
Related PHID: PHID-TASK-iu4hmv65bpptyojtbjte
Message:
Jun 16 2015, 4:05 AM · Mail
joshuaspence created T8562: Newlines are destroyed in outbound email.
Jun 16 2015, 4:03 AM · Mail
joshuaspence created T8561: Code block not nicely formatted in task description.
Jun 16 2015, 3:53 AM · Mail
joshuaspence added a comment to T4558: Make Diviner useful for third-parties.

I'd have to defer to the Phacility guys on that, but I would like to see Diviner become a full-fledged tool which can be used separately to Phabricator itself. I don't know enough about sphinx to compare the two products.

Jun 16 2015, 2:42 AM · Diviner

Jun 15 2015

joshuaspence added a subtask for T4558: Make Diviner useful for third-parties: T8555: Fix static publishing for Diviner.
Jun 15 2015, 9:24 PM · Diviner
joshuaspence added a parent task for T8555: Fix static publishing for Diviner: T4558: Make Diviner useful for third-parties.
Jun 15 2015, 9:24 PM · Diviner
joshuaspence created T8555: Fix static publishing for Diviner.
Jun 15 2015, 9:24 PM · Diviner
joshuaspence awarded T8549: Feedback on 2015 Redesign a Baby Tequila token.
Jun 15 2015, 8:48 PM · Design
joshuaspence added a revision to T7458: Diviner should integrate with main search: Unknown Object (Differential Revision).
Jun 15 2015, 12:02 PM · Diviner
joshuaspence added a revision to T4558: Make Diviner useful for third-parties: Unknown Object (Differential Revision).
Jun 15 2015, 11:53 AM · Diviner
joshuaspence created T8543: Prevent write queries from executing on "r" connections in LiskDAO.
Jun 15 2015, 11:06 AM · Restricted Project, Infrastructure
joshuaspence closed T8539: arc diff - create return Undefined class constant 'TYPE_SPACE' as Resolved.

This should be resolved at HEAD.

Jun 15 2015, 9:45 AM
joshuaspence closed T8541: Domain Exception on trying to write to undefined property mailer as Resolved.

This should be resolved at HEAD.

Jun 15 2015, 9:44 AM · Mail
joshuaspence added a revision to T8538: Phd daemon won't run : Unknown Object (Differential Revision).
Jun 15 2015, 8:58 AM · Daemons
joshuaspence added a revision to T8539: arc diff - create return Undefined class constant 'TYPE_SPACE': Unknown Object (Differential Revision).
Jun 15 2015, 8:58 AM
joshuaspence added a comment to T8538: Phd daemon won't run .

This should be fixed at HEAD.

Jun 15 2015, 8:38 AM · Daemons
joshuaspence closed T8538: Phd daemon won't run as Resolved by committing Restricted Diffusion Commit.
Jun 15 2015, 8:38 AM · Daemons
joshuaspence edited projects for T8538: Phd daemon won't run , added: Daemons; removed Diffusion.
Jun 15 2015, 8:38 AM · Daemons
joshuaspence updated subscribers of T8538: Phd daemon won't run .
Jun 15 2015, 8:36 AM · Daemons
joshuaspence merged task T8540: Phabricator daemons do not start after upgrade into T8538: Phd daemon won't run .
Jun 15 2015, 8:36 AM · Arcanist, libphutil
joshuaspence closed T8537: Too few arguments at [/path/to/libphutil/src/internationalization/PhutilTranslator.php:95 as Resolved.
Jun 15 2015, 8:07 AM
joshuaspence added a comment to T8537: Too few arguments at [/path/to/libphutil/src/internationalization/PhutilTranslator.php:95.

I think this is solved by D13292.

Jun 15 2015, 7:14 AM

Jun 14 2015

joshuaspence added a comment to T8536: Merge symbols and Diviner.

Actually I fnd the "pipe CTAGS" use case odd. I think it would be more useful if you could just run diviner generate inside a directory and we automatically generate symbols and documentation (unless you disable one or the other perhaps). In particular, this could maybe let us generate documentation stubs for languages we don't know about.

Jun 14 2015, 10:10 PM · Symbols, Diviner
joshuaspence added a comment to T6367: Send email with recipient's language and access levels, not sender's.

Ah thanks

Jun 14 2015, 9:25 PM · Wikimedia, Security, Localization, Mail
joshuaspence added a comment to T6367: Send email with recipient's language and access levels, not sender's.

Is it expected that I still receive "Unknown Object" emails? I thought that this task would've solved this issue. Specifically, I received the following email from this install:

Jun 14 2015, 9:22 PM · Wikimedia, Security, Localization, Mail
joshuaspence awarded T8236: `arc weld` should do something a Pterodactyl token.
Jun 14 2015, 10:50 AM · Contributor Onboarding, Arcanist
joshuaspence added a comment to T8534: Need a way to retrieve fully qualified class name.

I considered putting a getClassName() method on the XHPASTNode class, but I'm not entirely convinced that this is a good idea.

Jun 14 2015, 10:45 AM · XHPAST
joshuaspence added a subtask for T8533: Allow Diviner to fall back to (or link directly to) the Symbol index: T8536: Merge symbols and Diviner.
Jun 14 2015, 10:43 AM · Restricted Project, Symbols, Diviner
joshuaspence added a parent task for T8536: Merge symbols and Diviner: T8533: Allow Diviner to fall back to (or link directly to) the Symbol index.
Jun 14 2015, 10:43 AM · Symbols, Diviner
joshuaspence added a subtask for T4558: Make Diviner useful for third-parties: T8536: Merge symbols and Diviner.
Jun 14 2015, 10:20 AM · Diviner
joshuaspence added a parent task for T8536: Merge symbols and Diviner: T4558: Make Diviner useful for third-parties.
Jun 14 2015, 10:20 AM · Symbols, Diviner
joshuaspence created T8536: Merge symbols and Diviner.
Jun 14 2015, 10:18 AM · Symbols, Diviner
joshuaspence created T8534: Need a way to retrieve fully qualified class name.
Jun 14 2015, 6:50 AM · XHPAST
joshuaspence created T8533: Allow Diviner to fall back to (or link directly to) the Symbol index.
Jun 14 2015, 6:37 AM · Restricted Project, Symbols, Diviner
joshuaspence created T8532: Filesystem class need some test coverage.
Jun 14 2015, 5:50 AM · libphutil

Jun 13 2015

joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jun 13 2015, 4:55 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jun 13 2015, 12:44 AM · libphutil, Arcanist

Jun 12 2015

joshuaspence awarded T6860: Allow creation of parameterized application policies a Manufacturing Defect? token.
Jun 12 2015, 11:38 AM · Policy
joshuaspence awarded T5681: Allow applications to provide custom policy rules a Manufacturing Defect? token.
Jun 12 2015, 11:38 AM · FreeBSD, Policy
joshuaspence created T8523: Allow query for Maniphest tasks closed within a certain date range.
Jun 12 2015, 7:29 AM · Maniphest

Jun 11 2015

joshuaspence added a revision to T4558: Make Diviner useful for third-parties: Unknown Object (Differential Revision).
Jun 11 2015, 10:54 PM · Diviner
joshuaspence added a revision to T4558: Make Diviner useful for third-parties: Unknown Object (Differential Revision).
Jun 11 2015, 10:16 PM · Diviner
joshuaspence added a comment to T8476: Rename `phabricator_repository` database.

So far, I have come up with two different approaches to this. One of the major issues with this change is that we don't have a way to just connect to an arbitrary database with Lisk. Migrations which expect to change the phabricator_pastebin database, for example, cannot use PhabricatorPaste (which tries to connect to the phabricator_paste database, which doesn't yet exist). Furthermore, theses migrations cannot use LiskRawMigrationIterator either, because there is currently no easy way to construct an AphrontDatabaseConnection which connects to an arbitrary database.

Jun 11 2015, 9:54 PM · Restricted Project, Database, Diffusion
jayvdb awarded T8232: Automatically claim a task when a differential is submitted a Like token.
Jun 11 2015, 3:18 AM · Differential, Maniphest
joshuaspence created T8506: LESS Linter does not use path in linter message.
Jun 11 2015, 1:45 AM · Lint

Jun 10 2015

joshuaspence created T8505: Extending testing functionality.
Jun 10 2015, 9:36 PM · libphutil, Infrastructure
joshuaspence closed T8473: Garbage collect old notifications as Resolved by committing Restricted Diffusion Commit.
Jun 10 2015, 8:55 PM · Notifications
joshuaspence added a revision to T8473: Garbage collect old notifications: Unknown Object (Differential Revision).
Jun 10 2015, 12:16 PM · Notifications
joshuaspence merged T8494: Autoloader throws if class does not exist into T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.
Jun 10 2015, 11:15 AM · libphutil
joshuaspence merged task T8494: Autoloader throws if class does not exist into T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.
Jun 10 2015, 11:15 AM · libphutil
joshuaspence added a comment to T8454: User approval not working.

No, I'm not using auth.email-domains.

Jun 10 2015, 11:02 AM · People
joshuaspence claimed T8495: Write a linter wrapper for PHPDCD.
Jun 10 2015, 11:00 AM · Lint
joshuaspence claimed T8475: Clean up remnants of old Differential hunk storage.
Jun 10 2015, 11:00 AM · Infrastructure, Restricted Project, Differential
joshuaspence claimed T8476: Rename `phabricator_repository` database.
Jun 10 2015, 11:00 AM · Restricted Project, Database, Diffusion
joshuaspence claimed T8473: Garbage collect old notifications.
Jun 10 2015, 11:00 AM · Notifications
joshuaspence created T8495: Write a linter wrapper for PHPDCD.
Jun 10 2015, 8:22 AM · Lint
joshuaspence created T8494: Autoloader throws if class does not exist.
Jun 10 2015, 8:21 AM · libphutil
SalmonKiller awarded T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null a Like token.
Jun 10 2015, 1:56 AM · Paste, Infrastructure

Jun 9 2015

joshuaspence created T8492: Add a lint wrapper for PHPMD.
Jun 9 2015, 9:34 PM · Lint
joshuaspence created T8490: Batch editing work board returns a 502.
Jun 9 2015, 8:45 PM · Workboards
joshuaspence created T8483: Odd text in inline comment transaction.
Jun 9 2015, 1:08 PM · Restricted Project, Transactions, Differential
joshuaspence added a revision to T8476: Rename `phabricator_repository` database: Unknown Object (Differential Revision).
Jun 9 2015, 12:07 PM · Restricted Project, Database, Diffusion
joshuaspence added a comment to T8476: Rename `phabricator_repository` database.

I got bored and went ahead with this.

Jun 9 2015, 11:37 AM · Restricted Project, Database, Diffusion
joshuaspence added a revision to T8476: Rename `phabricator_repository` database: Unknown Object (Differential Revision).
Jun 9 2015, 10:03 AM · Restricted Project, Database, Diffusion
joshuaspence added a revision to T8475: Clean up remnants of old Differential hunk storage: Unknown Object (Differential Revision).
Jun 9 2015, 8:30 AM · Infrastructure, Restricted Project, Differential
joshuaspence added a comment to T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.

OK, after creating a user I made some progress... but now I hit this:

Jun 9 2015, 8:20 AM · Paste, Infrastructure
joshuaspence added a comment to T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.

Ah actually, this seems to only be an issue when there are no issues in the database.

Jun 9 2015, 8:19 AM · Paste, Infrastructure
joshuaspence created T8482: PhabricatorPasteTestDataGenerator: Call to a member function getPHID() on null.
Jun 9 2015, 8:18 AM · Paste, Infrastructure