Page MenuHomePhabricator
Create Task
Maniphest T8483

Odd text in inline comment transaction
Closed, ResolvedPublic
Actions

Description

See D13200#139793:

joshuaspence marked 0 inline comments as not done.

This seems really odd.

Revisions and Commits

rP Phabricator
D13226rP9c82881cac2e Fix "unmarked 0 inline comments as not undone" transactions

Related Objects

Event Timeline

joshuaspence created this task.Jun 9 2015, 1:08 PM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added projects: Differential, Transactions.
joshuaspence added a subscriber: joshuaspence.
epriestley added a subscriber: epriestley.Jun 9 2015, 1:16 PM

It's technically accurate!

epriestley assigned this task to lpriestley.Jun 9 2015, 6:55 PM

You've hit this too, do you want to try to figure it out?

epriestley claimed this task.Jun 9 2015, 8:19 PM
epriestley added subscribers: csilvers, lpriestley.

This has been implicated in other crimes by @csilvers.

Herald added a subscriber: sophiebits. · View Herald TranscriptJun 9 2015, 8:19 PM
epriestley added a revision: D13226: Fix "unmarked 0 inline comments as not undone" transactions.Jun 9 2015, 8:28 PM
epriestley closed this task as Resolved by committing rP9c82881cac2e: Fix "unmarked 0 inline comments as not undone" transactions.Jun 9 2015, 8:30 PM
epriestley added a commit: rP9c82881cac2e: Fix "unmarked 0 inline comments as not undone" transactions.
epriestley mentioned this in T8515: Differential comments show incorrect state.Jun 11 2015, 6:00 PM
jhurwitz added a project: Restricted Project.Jun 12 2015, 5:14 AM
jhurwitz moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.
jhurwitz added a subscriber: jhurwitz.
jhurwitz added a comment.Jun 12 2015, 5:21 AM

In addition to the text being wrong (it always says "marked 0 inline comments as not done."), I'm observing that state is not being saved -- I mark a bunch of things as done and submit/save, only to see that many have become un-marked as done.

Was that problem also resolved as part of this task, or is it separate?

epriestley added a comment.Jun 12 2015, 12:05 PM

Both the UI and function of these transactions should be fixed at HEAD.

angie added a subscriber: angie.Oct 14 2015, 6:41 PM

@jhurwitz can you confirm this has been resolved?

jhurwitz moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 19 2015, 8:52 AM
Phabricator · Built by Phacility