Page MenuHomePhabricator

Prompt for incomplete/unsaved inline comments upon creating a new comment instead of doing nothing
Closed, ResolvedPublic

Description

If you have an inline comment in-progress somewhere on a diff and try to double click a line to start another, nothing will happen. It’s so frustrating. I've finally trained myself to realize that it means I have a comment open somewhere else and scroll to find it. I have lost a few long unfinished comments in the past because I didn't know what was wrong so I refreshed and then my unfinished comment was gone. A prompt would be nice here.

Revisions and Commits

Restricted Differential Revision

Event Timeline

angie raised the priority of this task from to Needs Triage.
angie updated the task description. (Show Details)
angie added a project: Restricted Project.
angie added subscribers: jhurwitz, angie, aj.

We've never seen other reports of this, but it's <1 hour to fix. We can weave it in somewhere if approved.

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Sep 10 2015, 5:04 PM
epriestley added a revision: Restricted Differential Revision.Sep 10 2015, 6:19 PM
epriestley triaged this task as Normal priority.
epriestley added a project: Prioritized.
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Sep 10 2015, 6:36 PM
epriestley added a commit: Restricted Diffusion Commit.
angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Sep 10 2015, 6:38 PM

@aj can you confirm this has been resolved?

angie moved this task from Restricted Project Column to Restricted Project Column on the Restricted Project board.Oct 22 2015, 5:51 PM