Page MenuHomePhabricator

Reap easy performance improvements
Closed, ResolvedPublic

Description

This server has felt a bit slow recently and I caught some real silly stuff in profiles, so I'm going to see how much I can clean up.

Event Timeline

epriestley claimed this task.
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Performance.
epriestley added a subscriber: epriestley.
joshuaspence added a subscriber: joshuaspence.

Feed is doing some pretty silly stuff where it loads transactions, then loads their objects, then loads their handles (which loads their objects again), then loads the objects, then loads handles, which loads the objects again. In some cases, this loads objects about 6x more often than necessary. However, I think this is mostly specific to Feed, and it's not trivial to disentangle. I may take another look tomorrow.

I'm a reviewer of so many revisions on this install that Differential looks at doing a 13K row table scan of revision or a 15K row join from edge and picks the scan. If there was a key on with status as the first component, it could examine 408 rows instead. This is probably not common in the wild, but maybe worth adding.

fabe added a subscriber: fabe.Jun 17 2015, 2:51 PM

Maybe take a look @ D10600: Implement a git blame cache

Enabling blame on a file like:
https://secure.phabricator.com/diffusion/P/browse/master/src/__phutil_library_map__.php
is quite a good benchmack ;)

My diff might be a bit outdated though and i think it's biggest performance gain was by using PHID's to render the blamed commits in the Controller instead of the identifiers.

epriestley closed this task as Resolved.Jun 17 2015, 6:35 PM

I think I got all the incredibly dumb, incredibly easy stuff. Plenty of room left, but this install is feeling responsive to me again.

I'm probably going to move this host to newer hardware at some point soon-ish, too (this VM is almost 2.5 years old) but I want to wait for more of a lull in the development cycle.