Page MenuHomePhabricator
Feed Advanced Search

May 19 2015

btrahan claimed T8264: Oddness adding people to the Dropbox project.

Probably my bad

May 19 2015, 10:15 PM · Projects
btrahan added a comment to T8251: Conversation with myself doesn't list myself.

(I did break things and ended up fixing things with cowboy commit rPf05a7ed7b56ab2b37b5e483794c1d199581134d6)

May 19 2015, 9:30 PM · Conpherence
btrahan committed rP596db64ee62c: Conpherence - make solo conversations be titled with viewer's name (authored by btrahan).
Conpherence - make solo conversations be titled with viewer's name
May 19 2015, 9:28 PM
btrahan committed rPf05a7ed7b56a: Transactions - fix inverse edge transaction writes (authored by btrahan).
Transactions - fix inverse edge transaction writes
May 19 2015, 9:27 PM
btrahan closed D12939: Transactions - fix inverse edge transaction writes by committing rPf05a7ed7b56a: Transactions - fix inverse edge transaction writes.
May 19 2015, 9:27 PM
btrahan added a task to D12939: Transactions - fix inverse edge transaction writes: T6403: Make application customization of builtin transaction types optional.
May 19 2015, 9:26 PM
btrahan added a revision to T6403: Make application customization of builtin transaction types optional: D12939: Transactions - fix inverse edge transaction writes.
May 19 2015, 9:26 PM · Transactions
btrahan added a revision to T6403: Make application customization of builtin transaction types optional: Unknown Object (Differential Revision).
May 19 2015, 9:26 PM · Transactions
btrahan added a comment to T6403: Make application customization of builtin transaction types optional.

I seem to have broken some things with the EDGE stuff at least. Looking at it now...

May 19 2015, 9:18 PM · Transactions
btrahan awarded T8227: Why not just add an option/setting/preference? a Like token.
May 19 2015, 9:02 PM · Guides
btrahan added a task to D12937: Transactions - finish making built-in transaction types implementation optional: T6403: Make application customization of builtin transaction types optional.
May 19 2015, 8:44 PM
btrahan added a revision to T6403: Make application customization of builtin transaction types optional: D12937: Transactions - finish making built-in transaction types implementation optional.
May 19 2015, 8:44 PM · Transactions
btrahan updated subscribers of T8251: Conversation with myself doesn't list myself.

Hmmm, this didn't get auto-closed for some reason when I committed.

May 19 2015, 8:37 PM · Conpherence
chad awarded T8251: Conversation with myself doesn't list myself a Haypence token.
May 19 2015, 8:30 PM · Conpherence
btrahan closed T8251: Conversation with myself doesn't list myself as Resolved.

Hmmm, this didn't get auto-closed for some reason when I committed.

May 19 2015, 8:30 PM · Conpherence
btrahan created T8262: Differential comment preview area should be pretty like Pholio.
May 19 2015, 8:29 PM · Differential
btrahan added a task to D12936: Maniphest + Differential - don't show transaction preview until user interacts with the form.: T4846: "(user) added a comment." appended before the user adds any comment.
May 19 2015, 8:29 PM
btrahan added a revision to T4846: "(user) added a comment." appended before the user adds any comment: D12936: Maniphest + Differential - don't show transaction preview until user interacts with the form..
May 19 2015, 8:29 PM · Transactions
btrahan claimed T4846: "(user) added a comment." appended before the user adds any comment.
May 19 2015, 8:24 PM · Transactions
btrahan closed D12935: Conpherence - make solo conversations be titled with viewer's name by committing rP596db64ee62c: Conpherence - make solo conversations be titled with viewer's name.
May 19 2015, 8:19 PM
btrahan committed rP81a475d5a6b4: Transactions - make implementing TYPE_XXXX_POLICY transactions optional (authored by btrahan).
Transactions - make implementing TYPE_XXXX_POLICY transactions optional
May 19 2015, 7:58 PM
btrahan closed D12933: Transactions - make implementing TYPE_XXXX_POLICY transactions optional by committing rP81a475d5a6b4: Transactions - make implementing TYPE_XXXX_POLICY transactions optional.
May 19 2015, 7:58 PM
btrahan added a task to D12935: Conpherence - make solo conversations be titled with viewer's name: T8251: Conversation with myself doesn't list myself.
May 19 2015, 7:57 PM
btrahan added a revision to T8251: Conversation with myself doesn't list myself: D12935: Conpherence - make solo conversations be titled with viewer's name.
May 19 2015, 7:57 PM · Conpherence
btrahan added a revision to T6403: Make application customization of builtin transaction types optional: D12933: Transactions - make implementing TYPE_XXXX_POLICY transactions optional.
May 19 2015, 7:47 PM · Transactions
btrahan added a task to D12933: Transactions - make implementing TYPE_XXXX_POLICY transactions optional: T6403: Make application customization of builtin transaction types optional.
May 19 2015, 7:47 PM
btrahan committed rP01a8ba5a9798: Transactions - make TYPE_COMMENT implementation optional (authored by btrahan).
Transactions - make TYPE_COMMENT implementation optional
May 19 2015, 7:33 PM
btrahan closed D12932: Transactions - make TYPE_COMMENT implementation optional by committing rP01a8ba5a9798: Transactions - make TYPE_COMMENT implementation optional.
May 19 2015, 7:33 PM
btrahan updated the diff for D12932: Transactions - make TYPE_COMMENT implementation optional.

go with break; rather than return; so the parent can be fancy maybe some day

May 19 2015, 7:33 PM
epriestley awarded D12932: Transactions - make TYPE_COMMENT implementation optional a Haypence token.
May 19 2015, 7:32 PM
btrahan added a task to D12932: Transactions - make TYPE_COMMENT implementation optional: T6403: Make application customization of builtin transaction types optional.
May 19 2015, 7:31 PM
btrahan added a revision to T6403: Make application customization of builtin transaction types optional: D12932: Transactions - make TYPE_COMMENT implementation optional.
May 19 2015, 7:31 PM · Transactions
btrahan accepted D12931: Give Phriction a real dropdown.
May 19 2015, 7:13 PM
btrahan committed rP18e0ee079132: Transactions - move TYPE_SUBSCRIBERS to require optional implementation (authored by btrahan).
Transactions - move TYPE_SUBSCRIBERS to require optional implementation
May 19 2015, 6:47 PM
btrahan closed D12930: Transactions - move TYPE_SUBSCRIBERS to require optional implementation by committing rP18e0ee079132: Transactions - move TYPE_SUBSCRIBERS to require optional implementation.
May 19 2015, 6:47 PM
btrahan added a comment to D12930: Transactions - move TYPE_SUBSCRIBERS to require optional implementation.

Imma take all your hay pennies! :D

May 19 2015, 6:47 PM
epriestley awarded D12930: Transactions - move TYPE_SUBSCRIBERS to require optional implementation a Haypence token.
May 19 2015, 6:45 PM
btrahan added a task to D12930: Transactions - move TYPE_SUBSCRIBERS to require optional implementation: T6403: Make application customization of builtin transaction types optional.
May 19 2015, 6:40 PM
btrahan added a revision to T6403: Make application customization of builtin transaction types optional: D12930: Transactions - move TYPE_SUBSCRIBERS to require optional implementation.
May 19 2015, 6:40 PM · Transactions
btrahan committed rP16c8d44c37c9: Transactions - make customization of TYPE_EDGE optional (authored by btrahan).
Transactions - make customization of TYPE_EDGE optional
May 19 2015, 6:26 PM
btrahan closed D12929: Transactions - make customization of TYPE_EDGE optional by committing rP16c8d44c37c9: Transactions - make customization of TYPE_EDGE optional.
May 19 2015, 6:26 PM
btrahan added a comment to T8216: Make mailKey-related errors more obvious when testing new mail code.

Looking through my test instance from when I was building the offending diff that broke projects saves, looks like I was able to re-name projects and add members / watchers without getting mail key errors. I haven't really done any configuration to mail on this test instance and it generally doesn't actually send mail. Anyway, I think I can just remember next time I add mail functionality, and otherwise thanks for fixing projects!

May 19 2015, 6:25 PM · Projects
epriestley awarded D12929: Transactions - make customization of TYPE_EDGE optional a Haypence token.
May 19 2015, 6:20 PM
btrahan added a comment to T6403: Make application customization of builtin transaction types optional.

If its "built in" then its one of the PhabricatorTransactions constants and otherwise its not built in?

May 19 2015, 6:16 PM · Transactions
btrahan added a task to D12929: Transactions - make customization of TYPE_EDGE optional: T6403: Make application customization of builtin transaction types optional.
May 19 2015, 6:15 PM
btrahan added a revision to T6403: Make application customization of builtin transaction types optional: D12929: Transactions - make customization of TYPE_EDGE optional.
May 19 2015, 6:15 PM · Transactions
btrahan accepted rPHUbd087f55be93: Don't fail on undisposed write guards.
May 19 2015, 5:55 PM
btrahan accepted rP72a896f772b7: Add missing mail keys to Projects.
May 19 2015, 5:54 PM
btrahan awarded T8216: Make mailKey-related errors more obvious when testing new mail code a Doubloon token.
May 19 2015, 5:54 PM · Projects
btrahan accepted rP1f6b53be0e0d: Populate mail keys for new projects.
May 19 2015, 5:54 PM
btrahan triaged T8251: Conversation with myself doesn't list myself as Normal priority.
May 19 2015, 5:50 PM · Conpherence
btrahan claimed T8251: Conversation with myself doesn't list myself.
May 19 2015, 5:50 PM · Conpherence
btrahan committed rP1e128a24b84c: Conpherence - override some device specific styles so menu dropdown always… (authored by btrahan).
Conpherence - override some device specific styles so menu dropdown always…
May 19 2015, 5:48 PM
btrahan closed T7684: Durable Column menu should always be visible on open column as Resolved by committing rP1e128a24b84c: Conpherence - override some device specific styles so menu dropdown always….
May 19 2015, 5:48 PM · Conpherence
btrahan closed D12914: Conpherence - override some device specific styles so menu dropdown always present by committing rP1e128a24b84c: Conpherence - override some device specific styles so menu dropdown always….
May 19 2015, 5:48 PM
btrahan accepted D12927: Fix "size=full" issue for images in Firefox.
May 19 2015, 5:48 PM
btrahan added a comment to T8252: Maniphest number parsing in blog generates a core:edge exception.

This should be resolved in HEAD. Thanks for the report!

May 19 2015, 5:47 PM · Phame
btrahan claimed T6403: Make application customization of builtin transaction types optional.
May 19 2015, 5:46 PM · Transactions
btrahan committed rP8ff7222d0e01: Phame - add edge transaction implementations. (authored by btrahan).
Phame - add edge transaction implementations.
May 19 2015, 5:46 PM
btrahan closed T8252: Maniphest number parsing in blog generates a core:edge exception as Resolved by committing rP8ff7222d0e01: Phame - add edge transaction implementations..
May 19 2015, 5:46 PM · Phame
btrahan closed D12926: Phame - add edge transaction implementations. by committing rP8ff7222d0e01: Phame - add edge transaction implementations..
May 19 2015, 5:46 PM
btrahan added a revision to T8252: Maniphest number parsing in blog generates a core:edge exception: D12926: Phame - add edge transaction implementations..
May 19 2015, 5:43 PM · Phame
btrahan added a task to D12926: Phame - add edge transaction implementations.: T8252: Maniphest number parsing in blog generates a core:edge exception.
May 19 2015, 5:43 PM
btrahan claimed T8252: Maniphest number parsing in blog generates a core:edge exception.
May 19 2015, 5:38 PM · Phame

May 18 2015

btrahan updated D12914: Conpherence - override some device specific styles so menu dropdown always present.
May 18 2015, 10:43 PM
btrahan updated the diff for D12914: Conpherence - override some device specific styles so menu dropdown always present.

have hover styles behave consistently

May 18 2015, 10:42 PM
btrahan committed rP189c55d1d332: People - fix hovercards for people (authored by btrahan).
People - fix hovercards for people
May 18 2015, 10:39 PM
btrahan closed T8242: People Hovercards Missing Titles as Resolved by committing rP189c55d1d332: People - fix hovercards for people.
May 18 2015, 10:39 PM · People
btrahan closed D12915: People - fix hovercards for people by committing rP189c55d1d332: People - fix hovercards for people.
May 18 2015, 10:39 PM
btrahan updated D12915: People - fix hovercards for people.
May 18 2015, 10:39 PM
btrahan updated the diff for D12915: People - fix hovercards for people.

losing the flavortext

May 18 2015, 10:38 PM
btrahan added a task to D12915: People - fix hovercards for people: T8242: People Hovercards Missing Titles.
May 18 2015, 9:59 PM
btrahan added a revision to T8242: People Hovercards Missing Titles: D12915: People - fix hovercards for people.
May 18 2015, 9:59 PM · People
btrahan triaged T8242: People Hovercards Missing Titles as Normal priority.
May 18 2015, 9:57 PM · People
btrahan claimed T8242: People Hovercards Missing Titles.
May 18 2015, 9:57 PM · People
btrahan added a task to D12914: Conpherence - override some device specific styles so menu dropdown always present: T7684: Durable Column menu should always be visible on open column.
May 18 2015, 9:39 PM
btrahan added a revision to T7684: Durable Column menu should always be visible on open column: D12914: Conpherence - override some device specific styles so menu dropdown always present.
May 18 2015, 9:39 PM · Conpherence
btrahan triaged T8121: JS errors when browsing commits in Diffusion as Low priority.
May 18 2015, 9:11 PM · Diffusion, Quicksand
btrahan lowered the priority of T7558: Conpherence doesn't scroll to bottom in Durable Column regularly from High to Low.
May 18 2015, 9:10 PM · Conpherence (v4)
btrahan committed rPda4617aabd3f: Conpherence - fix widget updates from main view (authored by btrahan).
Conpherence - fix widget updates from main view
May 18 2015, 9:10 PM
btrahan closed T8217: Adding a participant in Conpherence causes weird layout as Resolved by committing rPda4617aabd3f: Conpherence - fix widget updates from main view.
May 18 2015, 9:10 PM · Conpherence
btrahan closed D12912: Conpherence - fix widget updates from main view by committing rPda4617aabd3f: Conpherence - fix widget updates from main view.
May 18 2015, 9:10 PM
btrahan triaged T8154: Conpherence threads don't specify the day they are created as Normal priority.
May 18 2015, 9:08 PM · Conpherence
btrahan added a task to D12912: Conpherence - fix widget updates from main view: T8217: Adding a participant in Conpherence causes weird layout.
May 18 2015, 9:08 PM
btrahan added a revision to T8217: Adding a participant in Conpherence causes weird layout: D12912: Conpherence - fix widget updates from main view.
May 18 2015, 9:08 PM · Conpherence
btrahan accepted D12909: Filter pastes at the query level if we're unable to load their content.
May 18 2015, 8:07 PM
btrahan committed rP78dddf39ba72: Maniphest - prevent uneditable tasks from being able to be closed as duplicates (authored by btrahan).
Maniphest - prevent uneditable tasks from being able to be closed as duplicates
May 18 2015, 8:07 PM
btrahan closed T7923: Un-editable task was able to be closed as duplicate as Resolved by committing rP78dddf39ba72: Maniphest - prevent uneditable tasks from being able to be closed as duplicates.
May 18 2015, 8:06 PM · Maniphest, Policy
btrahan closed D12872: Maniphest - prevent uneditable tasks from being able to be closed as duplicates by committing rP78dddf39ba72: Maniphest - prevent uneditable tasks from being able to be closed as duplicates.
May 18 2015, 8:06 PM
btrahan updated D12872: Maniphest - prevent uneditable tasks from being able to be closed as duplicates.
May 18 2015, 8:05 PM
btrahan updated the diff for D12872: Maniphest - prevent uneditable tasks from being able to be closed as duplicates.

now you can't find a task you can't merge (since you can't edit it). this should be the ideal solution methinks

May 18 2015, 8:04 PM
btrahan accepted D12907: Destroy notifications properly from `bin/remove destroy`.
May 18 2015, 7:29 PM
btrahan claimed T8154: Conpherence threads don't specify the day they are created.

I'll add / modify some first transaction with the full date and play around with tooltips, etc.

May 18 2015, 5:56 PM · Conpherence
btrahan claimed T7923: Un-editable task was able to be closed as duplicate.
May 18 2015, 5:43 PM · Maniphest, Policy
btrahan claimed T7684: Durable Column menu should always be visible on open column.

Cool, thanks!

May 18 2015, 5:41 PM · Conpherence
avivey awarded T8240: Error when updating from 20150504.symbolsproject.1.php a The World Burns token.
May 18 2015, 5:35 PM
btrahan updated subscribers of T8220: The "Persistent Chat" element doesn't remember which room you had selected across page refreshes.

@chad, @epriestley - just want to verify this is the behavior you guys want? (the back button / page history should have no interaction with the durable chat column basically)

May 18 2015, 5:31 PM · Conpherence (v4)
btrahan triaged T8217: Adding a participant in Conpherence causes weird layout as Normal priority.
May 18 2015, 5:30 PM · Conpherence
btrahan claimed T8217: Adding a participant in Conpherence causes weird layout.

I haven't repro'd this yet, but instead I am seeing the UI not update... Yay. :D

May 18 2015, 5:30 PM · Conpherence
btrahan added a comment to T7684: Durable Column menu should always be visible on open column.

@chad - do you want me to tackle this? Trying to finish off the V2 conpherence stuff.

May 18 2015, 5:28 PM · Conpherence