Conpherence - override some device specific styles so menu dropdown always present
ClosedPublic
Actions

Authored by btrahan on May 18 2015, 9:39 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7684: Durable Column menu should always be visible on open column

Commits

Restricted Diffusion Commit
rP1e128a24b84c: Conpherence - override some device specific styles so menu dropdown always…

Summary

Fixes T7684. I am not sure if this is simple or not in CSS terms but I just blasted a bunch of css classes to make sure they have the proper "device-desktop" values for the conpherence durable column.

One small visual oddity is the main menu dropdowns (for conpherence and the actual page) should have a hover state css, but we add device-tablet too early relative to the actual page width. This is no big deal probably.

Test Plan

made the screen table sized. used the dropdown menu with great success!

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 31068.May 18 2015, 9:39 PM

btrahan added a task: T7684: Durable Column menu should always be visible on open column.

btrahan retitled this revision from to Conpherence - override some device specific styles so menu dropdown always present.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 18 2015, 9:39 PM

Touch devices don't do hover states so we restrict them to device-desktop. Imperfect though since we relate screen size to device when that might not be true in the durable column case.