Page MenuHomePhabricator
Differential D12932

Transactions - make TYPE_COMMENT implementation optional
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 7:31 PM.
Tags
None
Referenced Files
F14356405: D12932.id31130.diff
Thu, Dec 19, 9:05 PM
Unknown Object (File)
Sat, Dec 14, 7:40 PM
Unknown Object (File)
Tue, Dec 10, 3:58 PM
Unknown Object (File)
Wed, Dec 4, 6:42 PM
Unknown Object (File)
Wed, Dec 4, 3:05 AM
Unknown Object (File)
Wed, Dec 4, 3:05 AM
Unknown Object (File)
Wed, Dec 4, 3:05 AM
Unknown Object (File)
Wed, Dec 4, 3:04 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Haypence" token, awarded by epriestley.

Details

Reviewers
epriestley
Maniphest Tasks
T6403: Make application customization of builtin transaction types optional
Commits
Restricted Diffusion Commit
rP01a8ba5a9798: Transactions - make TYPE_COMMENT implementation optional
Summary

Ref T6403. Conpherence keeps track of comments for message counts so we needed some special attention there. Otherwise, straight-forward.

Test Plan

left a comment on a diff with inline comments. sent messages in conpherence successfully. verified unread count incremented correctly for sent messages for users.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 31128.May 19 2015, 7:31 PM
btrahan added a task: T6403: Make application customization of builtin transaction types optional.
btrahan retitled this revision from to Transactions - make TYPE_COMMENT implementation optional.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 7:31 PM
epriestley accepted this revision.May 19 2015, 7:32 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/conpherence/editor/ConpherenceEditor.php
303

Maybe just break; in case the parent ever does anything.

This revision is now accepted and ready to land.May 19 2015, 7:32 PM
epriestley awarded a token.May 19 2015, 7:32 PM
btrahan updated this revision to Diff 31129.May 19 2015, 7:33 PM
btrahan edited edge metadata.

go with break; rather than return; so the parent can be fancy maybe some day

Closed by commit rP01a8ba5a9798: Transactions - make TYPE_COMMENT implementation optional (authored by btrahan, committed by btrahan). · Explain WhyMay 19 2015, 7:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
audit/
editor/
2 lines
calendar/
editor/
2 lines
conpherence/
editor/
16 lines
differential/
editor/
2 lines
paste/
editor/
3 lines
transactions/
editor/
2 lines

Diff 31130

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/paste/editor/PhabricatorPasteEditor.php

Loading...
View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...
Phabricator · Built by Phacility