People - fix hovercards for people
ClosedPublic
Actions

Authored by btrahan on May 18 2015, 9:59 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T8242: People Hovercards Missing Titles

Commits

Restricted Diffusion Commit
rP189c55d1d332: People - fix hovercards for people

Summary

Fixes T8242. D12833 removed the title as well as the blurb from people hovercards. When re-adding the title don't bother throwing things through pht since that seems like not something you translate exactly and also lose the flavor text which most users end up having since title is rarely set (at least on this install).

Test Plan

viewed hovercards and saw title and blurb again as appropos relative to the data being set

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 31069.May 18 2015, 9:59 PM

btrahan added a task: T8242: People Hovercards Missing Titles.

btrahan retitled this revision from to People - fix hovercards for people.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 18 2015, 9:59 PM

I removed this mostly-on-purpose because almost no one sets their title so hovercards are dominated by the ridiculously long default flavor text, from what I've seen. Maybe drop that? I don't really feel strongly here.

This revision is now accepted and ready to land.May 18 2015, 10:01 PM