Destroy notifications properly from `bin/remove destroy`
ClosedPublic
Actions

Authored by epriestley on May 18 2015, 7:28 PM.

Details

Reviewers

Maniphest Tasks

T8237: Destroying (with ./bin/remove destroy CLI) an object (here a project not tested for other object) raise an error.

Commits

Restricted Diffusion Commit
rP4250719d1008: Destroy notifications properly from `bin/remove destroy`

Summary

Fixes T8237. This table is unusual and doesn't have an id column, so delete() doesn't actually know how to delete records and fails.

Test Plan

Used bin/remove destroy to destroy an object with notifications, as per T8237.
Applied patch.
Used bin/remove destroy to get a clean delete.
Verified related notifications vanished from notification menu.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31045.May 18 2015, 7:28 PM

epriestley retitled this revision from to Destroy notifications properly from `bin/remove destroy`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8237: Destroying (with ./bin/remove destroy CLI) an object (here a project not tested for other object) raise an error..

Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2015, 7:28 PM

btrahan accepted this revision.May 18 2015, 7:29 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 18 2015, 7:29 PM

Closed by commit rP4250719d1008: Destroy notifications properly from `bin/remove destroy` (authored by epriestley, committed by epriestley). · Explain WhyMay 18 2015, 7:29 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

system/

engine/

PhabricatorDestructionEngine.php

13 lines

Diff 31046

View Options

src/applications/system/engine/PhabricatorDestructionEngine.php

Destroy notifications properly from `bin/remove destroy`ClosedPublicActions