Transactions - finish making built-in transaction types implementation optional
ClosedPublic
Actions

Authored by btrahan on May 19 2015, 8:44 PM.

Details

Reviewers

Maniphest Tasks

T6403: Make application customization of builtin transaction types optional

Commits

Restricted Diffusion Commit
rP4787069e96fb: Transactions - finish making built-in transaction types implementation optional

Summary

Fixes T6403. Remaining built-ins were already built-in effectively so this is a small re-factor plus some docs. I probably wouldn't have written anything if not for the TODO so please feel free to tell me to write something else or what have you.

Test Plan

NA since this didn't actually change anything.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 31140.May 19 2015, 8:44 PM

btrahan added a task: T6403: Make application customization of builtin transaction types optional.

btrahan retitled this revision from to Transactions - finish making built-in transaction types implementation optional.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 19 2015, 8:44 PM

epriestley accepted this revision.May 19 2015, 11:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 11:06 PM

Closed by commit rP4787069e96fb: Transactions - finish making built-in transaction types implementation optional (authored by btrahan, committed by btrahan). · Explain WhyMay 20 2015, 8:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

29 lines

Diff 31200

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Transactions - finish making built-in transaction types implementation optionalClosedPublicActions