Page MenuHomePhabricator

Give Phriction a real dropdown
ClosedPublic

Authored by epriestley on May 19 2015, 7:05 PM.
Tags
None
Referenced Files
F14019655: D12931.id31125.diff
Tue, Nov 5, 11:11 PM
F13997350: D12931.diff
Thu, Oct 24, 3:53 AM
F13994180: D12931.id31125.diff
Wed, Oct 23, 4:26 AM
F13978107: D12931.id.diff
Fri, Oct 18, 9:34 PM
F13968606: D12931.id31127.diff
Wed, Oct 16, 10:15 PM
Unknown Object (File)
Oct 3 2024, 5:04 AM
Unknown Object (File)
Sep 13 2024, 7:34 PM
Unknown Object (File)
Aug 25 2024, 6:20 AM
Subscribers

Details

Summary

Fixes T8150. Small generalization:

  • Timeline has a dropdown with no special logic; make that generic.
  • Use it in Phriction.
Test Plan
  • Used Phriction dropdown on desktop and mobile.
  • Used timeline dropdown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Phriction a real dropdown.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Remove extra copy of the behavior.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 7:13 PM
This revision was automatically updated to reflect the committed changes.