Page MenuHomePhabricator

Give Phriction a real dropdown
ClosedPublic

Authored by epriestley on May 19 2015, 7:05 PM.
Tags
None
Referenced Files
F15524138: D12931.id31126.diff
Mon, Apr 21, 6:11 AM
F15522176: D12931.diff
Sun, Apr 20, 6:27 PM
F15508178: D12931.id.diff
Wed, Apr 16, 2:47 AM
F15386711: D12931.id31125.diff
Mar 15 2025, 1:09 AM
F15379691: D12931.diff
Mar 13 2025, 10:46 PM
Unknown Object (File)
Mar 1 2025, 4:25 AM
Unknown Object (File)
Feb 9 2025, 6:36 PM
Unknown Object (File)
Jan 30 2025, 11:22 PM
Subscribers

Details

Summary

Fixes T8150. Small generalization:

  • Timeline has a dropdown with no special logic; make that generic.
  • Use it in Phriction.
Test Plan
  • Used Phriction dropdown on desktop and mobile.
  • Used timeline dropdown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give Phriction a real dropdown.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Remove extra copy of the behavior.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 7:13 PM
This revision was automatically updated to reflect the committed changes.