Page MenuHomePhabricator
Differential D12931

Give Phriction a real dropdown
ClosedPublic
Actions

Authored by epriestley on May 19 2015, 7:05 PM.
Tags
None
Referenced Files
F19726120: D12931.id31127.diff
Fri, Feb 13, 5:19 PM
F19670279: D12931.id31127.diff
Sat, Feb 7, 10:44 PM
F19661387: D12931.id.diff
Sat, Feb 7, 6:41 AM
F19634384: D12931.id31127.diff
Thu, Feb 5, 8:20 AM
F19614525: D12931.id31125.diff
Tue, Feb 3, 10:06 PM
F19610819: D12931.diff
Tue, Feb 3, 5:07 PM
F19559638: D12931.diff
Sat, Jan 31, 2:36 AM
F19522483: D12931.diff
Sat, Jan 17, 7:45 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8150: Phriction document actions should be a real dropdown
Commits
Restricted Diffusion Commit
rP462299388566: Give Phriction a real dropdown
Summary

Fixes T8150. Small generalization:

  • Timeline has a dropdown with no special logic; make that generic.
  • Use it in Phriction.
Test Plan
  • Used Phriction dropdown on desktop and mobile.
  • Used timeline dropdown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 31125.May 19 2015, 7:05 PM
epriestley retitled this revision from to Give Phriction a real dropdown.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8150: Phriction document actions should be a real dropdown.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 19 2015, 7:05 PM
epriestley updated this revision to Diff 31126.May 19 2015, 7:06 PM
  • Remove extra copy of the behavior.
btrahan accepted this revision.May 19 2015, 7:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 19 2015, 7:13 PM
Closed by commit rP462299388566: Give Phriction a real dropdown (authored by epriestley, committed by epriestley). · Explain WhyMay 19 2015, 7:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
28 lines
2 lines
src/
applications/
phriction/
controller/
15 lines
view/
phui/
12 lines
28 lines
4 lines
webroot/
rsrc/
js/
phui/
behavior-phui-dropdown-menu.js
behavior-phui-timeline-dropdown-menu.js
10 lines

Diff 31127

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

src/view/phui/PHUIButtonView.php

Loading...
View Options

src/view/phui/PHUIDocumentView.php

Loading...
View Options

src/view/phui/PHUITimelineEventView.php

Loading...
View Options

webroot/rsrc/js/phui/behavior-phui-dropdown-menu.js

Loading...
View Options

webroot/rsrc/js/phui/behavior-phui-timeline-dropdown-menu.js

Loading...
Phabricator · Built by Phacility