Page MenuHomePhabricator
Differential D12872

Maniphest - prevent uneditable tasks from being able to be closed as duplicates
ClosedPublic
Actions

Authored by btrahan on May 16 2015, 12:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 5:36 PM
Unknown Object (File)
Thu, Apr 11, 9:10 AM
Unknown Object (File)
Tue, Apr 2, 5:10 PM
Unknown Object (File)
Thu, Mar 28, 9:05 AM
Unknown Object (File)
Sat, Mar 23, 5:17 AM
Unknown Object (File)
Sat, Mar 23, 5:17 AM
Unknown Object (File)
Feb 7 2024, 4:22 PM
Unknown Object (File)
Feb 4 2024, 7:12 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7923: Un-editable task was able to be closed as duplicate
Commits
Restricted Diffusion Commit
rP78dddf39ba72: Maniphest - prevent uneditable tasks from being able to be closed as duplicates
Summary

Fixes T7923.

Prevent the user from finding tasks that they can't edit in merge workflows. Also ensure that we query properly on final merge action just in case.

Test Plan

Tried to find a task I couldn't edit in various searches under the "merge" dialogue and couldn't find the task. Removed this big of code and tried to merge in a task and after hitting "merge" observed the page reloaded with no task merged in.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 30959.May 16 2015, 12:20 AM
btrahan added a task: T7923: Un-editable task was able to be closed as duplicate.
btrahan retitled this revision from to Maniphest - prevent uneditable tasks from being able to be closed as duplicates.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 16 2015, 12:20 AM
epriestley accepted this revision.May 17 2015, 12:56 PM
epriestley edited edge metadata.

Probably a slightly better state of affairs until we do more work here.

This revision is now accepted and ready to land.May 17 2015, 12:56 PM
btrahan updated this revision to Diff 31051.May 18 2015, 8:04 PM
btrahan edited edge metadata.

updates.

now you can't find a task you can't merge (since you can't edit it). this should be the ideal solution methinks

btrahan updated this object.May 18 2015, 8:05 PM
btrahan edited the test plan for this revision. (Show Details)
Closed by commit rP78dddf39ba72: Maniphest - prevent uneditable tasks from being able to be closed as duplicates (authored by btrahan, committed by btrahan). · Explain WhyMay 18 2015, 8:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31052

View Options

src/applications/phid/query/PhabricatorHandleQuery.php

Loading...
View Options

src/applications/search/application/PhabricatorSearchApplication.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchAttachController.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchBaseController.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchSelectController.php

Loading...
View Options

src/applications/search/query/PhabricatorSearchDocumentQuery.php

Loading...
Phabricator · Built by Phacility