Page MenuHomePhabricator
Feed Advanced Search

Dec 30 2014

joshuaspence added a revision to T6829: The `Futures()` function violates naming conventions: Unknown Object (Differential Revision).
Dec 30 2014, 12:05 PM · Lint, libphutil
joshuaspence added a comment to T6829: The `Futures()` function violates naming conventions.

+1

Dec 30 2014, 11:45 AM · Lint, libphutil
joshuaspence created T6830: Improve lint handling of declare() special statement blocks.
Dec 30 2014, 7:29 AM · Lint
joshuaspence renamed T6829: The `Futures()` function violates naming conventions from The `Futures()` function violates naming conventions` to The `Futures()` function violates naming conventions.
Dec 30 2014, 7:27 AM · Lint, libphutil
joshuaspence created T6829: The `Futures()` function violates naming conventions.
Dec 30 2014, 7:26 AM · Lint, libphutil
joshuaspence closed T6825: Return a 403 instead of a 404 when unable to view an object as Invalid.

Nevermind, on trying to replicate this I think I mistyped the URL. Although I'm not sure that I agree with a 200.

Dec 30 2014, 1:34 AM · Policy
joshuaspence created T6825: Return a 403 instead of a 404 when unable to view an object.
Dec 30 2014, 12:31 AM · Policy

Dec 29 2014

joshuaspence created T6824: Unable to select "both" for notification preferences.
Dec 29 2014, 10:02 PM · Notifications

Dec 24 2014

joshuaspence closed T6456: Daemon worker queue not working as Resolved.

Seems to see fixed.

Dec 24 2014, 7:27 AM · Daemons

Dec 8 2014

joshuaspence added a comment to T6688: "'authorPHID' cannot be null" exception parsing commit message.

I'm actually not seeing this issue any more after updating.

Dec 8 2014, 12:09 PM · Support Impact, Phabricator

Dec 4 2014

joshuaspence added a comment to T6693: Unable to view 'older changes'..

We are also seeing this issue.

Dec 4 2014, 9:41 PM · Differential
joshuaspence created T6688: "'authorPHID' cannot be null" exception parsing commit message.
Dec 4 2014, 11:44 AM · Support Impact, Phabricator

Nov 13 2014

joshuaspence created T6549: Backup codes for multi-factor authentication.
Nov 13 2014, 8:16 PM · Restricted Project, Auth

Nov 9 2014

joshuaspence added a comment to T6505: Set non-zero "arc conduit-call" exit code in case of error.

I agree with this (haven't verified that this is actually the case). I had similar thoughts about the ./scripts/phutil_symbols.php script.

Nov 9 2014, 10:02 AM · Arcanist
joshuaspence updated the task description for T6508: Exception thrown when using `./bin/config migrate`.
Nov 9 2014, 9:17 AM · Phabricator
joshuaspence created T6508: Exception thrown when using `./bin/config migrate`.
Nov 9 2014, 9:17 AM · Phabricator

Nov 7 2014

joshuaspence added a comment to T1191: Comments are truncated at first non-base-plane character.

Great work @epriestley

Nov 7 2014, 11:40 PM · Wikimedia, Support Impact, High Support Impact, Differential
joshuaspence awarded T1191: Comments are truncated at first non-base-plane character a Mountain of Wealth token.
Nov 7 2014, 11:37 PM · Wikimedia, Support Impact, High Support Impact, Differential

Nov 3 2014

joshuaspence created T6459: Removing stale commits.
Nov 3 2014, 1:34 PM · Phabricator
joshuaspence added a comment to T6453: MySQL warnings after storage adjustment.

(Admittedly these may have been happening before storage adjustment as well)

Nov 3 2014, 1:31 PM · Database
joshuaspence added a comment to T6456: Daemon worker queue not working.

Hmm, I don't think this is a race condition because none of the tasks are being executed. The queue stayed at ~200k tasks for a few hours.

Nov 3 2014, 1:14 PM · Daemons
joshuaspence added a comment to T5694: AphrontWriteGuard was not properly disposed of.

@chad, yes it is.

Nov 3 2014, 8:02 AM · Aphront
joshuaspence created T6456: Daemon worker queue not working.
Nov 3 2014, 8:00 AM · Daemons
joshuaspence created T6453: MySQL warnings after storage adjustment.
Nov 3 2014, 12:22 AM · Database

Nov 1 2014

joshuaspence added a comment to T1191: Comments are truncated at first non-base-plane character.

I'm getting the following error when trying to apply storage adjustments:

Nov 1 2014, 11:37 PM · Wikimedia, Support Impact, High Support Impact, Differential

Oct 21 2014

joshuaspence added a comment to T6303: Missing lint warnings where line number is unknown.

The title caught my eye, I subscribe as a reminder to come back to this

Oct 21 2014, 8:39 PM · Arcanist

Oct 12 2014

joshuaspence added a comment to T6293: Unable to mention differential revisions from commits.

Ref is for maniphest tasks... or does it work with differential revisions as well?

Oct 12 2014, 10:07 PM · Transactions, Diffusion, Differential
joshuaspence added a comment to T6293: Unable to mention differential revisions from commits.

Hmm... maybe not a mention, but I feel that there should be some sort of relationship.

Oct 12 2014, 10:01 PM · Transactions, Diffusion, Differential
joshuaspence renamed T6293: Unable to mention differential revisions from commits from Unable to mention differentials from commits to Unable to mention differential revisions from commits.
Oct 12 2014, 9:47 PM · Transactions, Diffusion, Differential
joshuaspence created T6293: Unable to mention differential revisions from commits.
Oct 12 2014, 9:43 PM · Transactions, Diffusion, Differential
joshuaspence triaged T5732: Aphlict client crashes when server is stopped as Normal priority.
Oct 12 2014, 9:41 PM · Aphlict
joshuaspence closed T5696: number_format() expects parameter 1 to be double, string given as Invalid.

I don't think I am seeing this any more.

Oct 12 2014, 9:39 PM · Phabricator, Differential
joshuaspence claimed T5732: Aphlict client crashes when server is stopped.
Oct 12 2014, 9:39 PM · Aphlict
joshuaspence closed T5736: Invalid multibyte sequence in argument as Invalid.

I don't think I am seeing this any more.

Oct 12 2014, 9:39 PM · libphutil
joshuaspence claimed T5344: Multiplex AJAX calls from Aphlict clients through the JX.Leader.
Oct 12 2014, 9:32 PM · Aphlict
joshuaspence claimed T5365: Aphlict client should reconnect after a failure.
Oct 12 2014, 9:32 PM · Aphlict
joshuaspence triaged T5644: Add controls to prevent `pygmentize` from saturating system resources as High priority.
Oct 12 2014, 9:31 PM · Differential, Diffusion
joshuaspence created T6292: Invalid argument supplied for foreach().
Oct 12 2014, 8:46 PM · Differential, Conduit
joshuaspence placed T3554: Implement a `bin/worker kill <criteria>` for batch-flushing tasks from the queue up for grabs.
Oct 12 2014, 8:19 PM · Restricted Project, Daemons
joshuaspence updated the task description for T5196: Enforce that phd is run as the phd.user daemon user.
Oct 12 2014, 8:15 PM · Support Impact, Daemons
joshuaspence placed T5574: Add a "dry run" mode for Arcanist up for grabs.
Oct 12 2014, 8:13 PM · Arcanist
joshuaspence raised the priority of T5615: Add class name support to `PhutilTypeSpec` from Wishlist to Low.
Oct 12 2014, 8:12 PM · libphutil
joshuaspence triaged T5615: Add class name support to `PhutilTypeSpec` as Wishlist priority.
Oct 12 2014, 8:11 PM · libphutil
joshuaspence triaged T5639: Detect the use of undefined magic constants as Wishlist priority.
Oct 12 2014, 8:11 PM · Arcanist
joshuaspence triaged T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories as High priority.
Oct 12 2014, 8:10 PM · Arcanist
joshuaspence triaged T6061: `arc linters` should do basic environment checking as High priority.
Oct 12 2014, 8:10 PM · Lint, Arcanist
joshuaspence placed T5658: Change "Pending Differential Revisions" into "Recent Pending Differential Revisions" up for grabs.
Oct 12 2014, 8:10 PM · Differential
joshuaspence triaged T5616: Add tuple support to `PhutilTypeSpec` as Wishlist priority.
Oct 12 2014, 8:09 PM · libphutil
joshuaspence triaged T6154: XHPAST fails to recognise some syntax errors as Normal priority.
Oct 12 2014, 8:08 PM · XHPAST

Oct 9 2014

noisy awarded T5792: Allow Diviner documentation to be generated with Harbormaster + Drydock a Like token.
Oct 9 2014, 9:08 PM · Harbormaster, Diviner

Sep 26 2014

joshuaspence added a comment to T6195: Replace XHPAST with a pure PHP implementation.

Here's a very basic test I did for profiling XHPAST against PHP-Parser:

Sep 26 2014, 8:37 AM · XHPAST
joshuaspence created T6195: Replace XHPAST with a pure PHP implementation.
Sep 26 2014, 8:35 AM · XHPAST

Sep 25 2014

joshuaspence updated the task description for T6184: Incorrect date shown on hover.
Sep 25 2014, 12:42 PM
joshuaspence created T6184: Incorrect date shown on hover.
Sep 25 2014, 12:41 PM

Sep 22 2014

joshuaspence closed T5374: Write an acceptance test for detecting when the Celerity map file is out-of-date as Resolved.

Closed by commit rP212b0d29c54f.

Sep 22 2014, 9:00 AM · Celerity

Sep 21 2014

joshuaspence added a revision to T5616: Add tuple support to `PhutilTypeSpec`: Unknown Object (Differential Revision).
Sep 21 2014, 1:25 PM · libphutil
joshuaspence added a revision to T5155: Evaluate support for AWS IAM Roles in S3 Client: Unknown Object (Differential Revision).
Sep 21 2014, 9:44 AM · Files
joshuaspence added a revision to T5155: Evaluate support for AWS IAM Roles in S3 Client: Unknown Object (Differential Revision).
Sep 21 2014, 9:43 AM · Files
joshuaspence renamed T5155: Evaluate support for AWS IAM Roles in S3 Client from Update S3 library to support IAM Roles to Write a native S3 client.
Sep 21 2014, 9:23 AM · Files
joshuaspence claimed T6154: XHPAST fails to recognise some syntax errors.

I don't mind working on this, but I'm not sure what the correct fix is.

Sep 21 2014, 9:16 AM · XHPAST
joshuaspence updated subscribers of T6154: XHPAST fails to recognise some syntax errors.
Sep 21 2014, 9:16 AM · XHPAST
joshuaspence created T6154: XHPAST fails to recognise some syntax errors.
Sep 21 2014, 9:15 AM · XHPAST

Sep 14 2014

joshuaspence added a comment to T6084: Hide Harbormaster / Drydock more, or warn users more about using them.

IMO, most of the beta applications are somewhat useable and probably not a significant drain on support resources.

Sep 14 2014, 9:26 PM · Documentation
joshuaspence updated the task description for T6088: Maniphest Task with a large number of transactions causes 502.
Sep 14 2014, 4:03 AM · Transactions, Maniphest
joshuaspence added a comment to T6088: Maniphest Task with a large number of transactions causes 502.

Possibly related to T5573?

Sep 14 2014, 3:54 AM · Transactions, Maniphest
joshuaspence created T6088: Maniphest Task with a large number of transactions causes 502.
Sep 14 2014, 3:52 AM · Transactions, Maniphest

Sep 13 2014

joshuaspence added a comment to T5658: Change "Pending Differential Revisions" into "Recent Pending Differential Revisions".

I would be happy with that

Sep 13 2014, 4:35 AM · Differential

Sep 10 2014

joshuaspence closed T5299: `ArcanistXHPASTLinter` should allow classes/functions from a later version if they are used conditionally as Resolved.

Closed by commit rARC3f79ae258f34.

Sep 10 2014, 2:27 PM · Arcanist
joshuaspence added a revision to T6060: Arcanist should skip linters that have missing dependencies: Unknown Object (Differential Revision).
Sep 10 2014, 1:52 PM · Restricted Project, Arcanist

Sep 9 2014

joshuaspence created T6061: `arc linters` should do basic environment checking.
Sep 9 2014, 11:24 PM · Lint, Arcanist
joshuaspence created T6060: Arcanist should skip linters that have missing dependencies.
Sep 9 2014, 11:23 PM · Restricted Project, Arcanist

Sep 8 2014

joshuaspence added a comment to T5136: Allow default severity to be set in `.arclint`.

Yeah, I think this would probably solve it (albeit being a little less user friendly). Feel free to close this ticket.

Sep 8 2014, 10:29 PM · Arcanist
joshuaspence edited P1257 `./bin/remove destroy` error.
Sep 8 2014, 1:11 PM

Sep 5 2014

avivey awarded T5196: Enforce that phd is run as the phd.user daemon user a Like token.
Sep 5 2014, 6:58 PM · Support Impact, Daemons

Aug 27 2014

joshuaspence added a comment to T5968: "Phabricator Daemons Need Restarting" is too difficult to understand/debug.

Could there be some sort of watchdog daemon which does nothing except for signalling the daemons to restart when the config changes?

Aug 27 2014, 9:41 PM · Daemons
PhoneixS awarded T5282: Provide documentation on setting up ElasticSearch a Like token.
Aug 27 2014, 11:17 AM · Elasticsearch, Documentation

Aug 11 2014

joshuaspence created T5844: Internal Server Error if custom "Host" header is set.
Aug 11 2014, 3:15 AM · Phabricator

Aug 5 2014

joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Aug 5 2014, 11:02 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Aug 5 2014, 10:17 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Aug 5 2014, 10:08 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Aug 5 2014, 10:02 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Aug 5 2014, 1:30 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Aug 5 2014, 1:27 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Aug 5 2014, 1:08 PM · libphutil, Arcanist
joshuaspence closed T5648: Add a linter rule for parentheses being used with PHP language constructs as Resolved.

Closed by commit rARCf6e26a71335e.

Aug 5 2014, 12:35 PM · Arcanist
joshuaspence renamed T5792: Allow Diviner documentation to be generated with Harbormaster + Drydock from Automatically generate Diviner documentation to Allow Diviner documentation to be generated with Harbourmaster + Drydock.
Aug 5 2014, 8:17 AM · Harbormaster, Diviner
joshuaspence added a comment to T5792: Allow Diviner documentation to be generated with Harbormaster + Drydock.

Yeah OK... I'll repurpose this

Aug 5 2014, 8:14 AM · Harbormaster, Diviner

Aug 4 2014

joshuaspence created T5792: Allow Diviner documentation to be generated with Harbormaster + Drydock.
Aug 4 2014, 10:42 PM · Harbormaster, Diviner
joshuaspence created T5790: Move Diviner code to arcanist.
Aug 4 2014, 10:38 PM · Arcanist, Diviner

Aug 3 2014

joshuaspence added a revision to T5299: `ArcanistXHPASTLinter` should allow classes/functions from a later version if they are used conditionally: Unknown Object (Differential Revision).
Aug 3 2014, 12:08 PM · Arcanist

Aug 2 2014

joshuaspence added a comment to T5770: Errors for `bin/storage upgrade` before `bin/config set mysql.*` are perplexing.

Can you run the upgrade script with --trace? That should give some more information.

Aug 2 2014, 11:53 PM
joshuaspence added a revision to T5648: Add a linter rule for parentheses being used with PHP language constructs: Unknown Object (Differential Revision).
Aug 2 2014, 9:54 AM · Arcanist
joshuaspence closed T5772: Add a linter rule for detecting redeclared functions as Invalid.

Actually, arc liberate can detect this already.

Aug 2 2014, 7:53 AM · Arcanist
joshuaspence added a comment to T5772: Add a linter rule for detecting redeclared functions.

function foo() {}
function foo() {}

Aug 2 2014, 7:52 AM · Arcanist
joshuaspence triaged T5772: Add a linter rule for detecting redeclared functions as Low priority.
Aug 2 2014, 7:51 AM · Arcanist
joshuaspence created T5772: Add a linter rule for detecting redeclared functions.
Aug 2 2014, 7:51 AM · Arcanist
joshuaspence closed T5737: Allow searching for Accepted revisions as Resolved.

This was fixed in rPbf10b7602bece9604fd0e41511e319ee4c6be6f5.

Aug 2 2014, 7:41 AM · Differential

Jul 30 2014

joshuaspence added a comment to T5748: php_compat_info.json missing ZipArchive class.

Hmm. I'm pretty sure I just did this (the installation) all through composer...

Jul 30 2014, 9:11 PM · libphutil

Jul 29 2014

joshuaspence created T5737: Allow searching for Accepted revisions.
Jul 29 2014, 5:50 AM · Differential
joshuaspence created T5736: Invalid multibyte sequence in argument.
Jul 29 2014, 5:46 AM · libphutil