Right now, there is very little error handling and recovery that is done by the Aphlict client/master. T5281 is related and probably achieves most of what we need here (being able to detect connection problems), but it would be great to also provide a reasonable level of automated error recovery where possible (i.e. when we detect a connection failure/degradation, try to reconnect).
Description
Description
Revisions and Commits
Revisions and Commits
rP Phabricator | |||
D9706 | rP79366795e7ad React to Aphlict disconnects in the UI |
Status | Assigned | Task | ||
---|---|---|---|---|
Resolved | joshuaspence | T5365 Aphlict client should reconnect after a failure | ||
Resolved | epriestley | T5281 Aphlict master doesn't handle connection failures |
Event Timeline
Comment Actions
This doesn't seem to occur any more after T6559: Change notification system implementation not to require Flash.
Comment Actions
I implemented (very simple) reconnects in JX.WebSocket and they seem to work pretty well.
They probably don't handle some more extreme cases like closing your laptop for an hour, but we can tweak that when we get there.