Page MenuHomePhabricator

Aphlict client should reconnect after a failure
Closed, ResolvedPublic

Description

Right now, there is very little error handling and recovery that is done by the Aphlict client/master. T5281 is related and probably achieves most of what we need here (being able to detect connection problems), but it would be great to also provide a reasonable level of automated error recovery where possible (i.e. when we detect a connection failure/degradation, try to reconnect).

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Aphlict.
joshuaspence added a subscriber: joshuaspence.
mabulgu removed a subscriber: mabulgu.
mabulgu added a subscriber: mabulgu.
mabulgu removed a subscriber: mabulgu.

I implemented (very simple) reconnects in JX.WebSocket and they seem to work pretty well.

They probably don't handle some more extreme cases like closing your laptop for an hour, but we can tweak that when we get there.