Page MenuHomePhabricator

Unable to mention differential revisions from commits
Closed, ResolvedPublic

Description

It seems that a commit cannot "mention" a differential, whereas other objects (such as differentials) can mention differentials.

If I push a commit with a message such as "Adding some diagnostic information for D123" then I would expect this to create a normal "mentions" relationship, but it does not.

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a subscriber: joshuaspence.
joshuaspence renamed this task from Unable to mention differentials from commits to Unable to mention differential revisions from commits.Oct 12 2014, 9:47 PM

Oh, maybe I am misunderstanding your description. I do not expect an object in a message to count as a "Mention", only a person actually mentioning it via a comment box.

Hmm... maybe not a mention, but I feel that there should be some sort of relationship.

Ref currently does that job, I'm just wondering if we should make Ref action the default anytime an object is referenced anywhere (instead of via a comment mention).

Ref is for maniphest tasks... or does it work with differential revisions as well?

We added mentions recently. The merge was correct. See next transaction for an example.

Specifically, the commit message summary is never processed as a transaction, so user/object/file mentions don't activate. This also means @user doesn't CC, and {Fxxx} doesn't adjust permissions.