Differential D14184

Simplify value decoding for PHID custom fields
ClosedPublic
Actions

Authored by epriestley on Sep 29 2015, 1:03 AM.

Details

Reviewers

chad

Maniphest Tasks

T9123: Build Phabricator in Harbormaster (v2)

Commits

Restricted Diffusion Commit
rPefaa8170c353: Simplify value decoding for PHID custom fields

Summary

Ref T9123. The handling in D14183 didn't deal with new field values properly.

Make all this handling more consistent.

Test Plan

Created a new WorkignCopy build plan with some repos.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 34264.Sep 29 2015, 1:03 AM

epriestley retitled this revision from to Simplify value decoding for PHID custom fields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9123: Build Phabricator in Harbormaster (v2).

chad accepted this revision.Sep 29 2015, 1:44 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Sep 29 2015, 1:44 AM

Closed by commit rPefaa8170c353: Simplify value decoding for PHID custom fields (authored by epriestley, committed by epriestley). · Explain WhySep 29 2015, 1:44 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

customfield/

standard/

PhabricatorStandardCustomFieldPHIDs.php

35 lines

Diff 34265

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldPHIDs.php

Simplify value decoding for PHID custom fieldsClosedPublicActions