It seems to be for either for a new revision or when a revision has been updated with a new diff. The text of the email and the history item both have the same text "Harbormaster failed to build B32135: Diff 76187!" (rest of email body is typical for any PFR event; history item only additionally has a timestamp and a red icon).
A couple more annoying questions from the semi-newb phabricator admin:
What is the difference in terms of email body content for a git diff vs unified diff?
Is it possible to show line numbers in the email body content for a diff? (currently we have an ugly script that parses .patch file and edits the email body, but it's way uglier than the default)
I think the line numbers more for ease of local reference in file for folks who don't like using the website to get more context. I use it sometimes when I cannot VPN in to use the website. I experimentally set metamta.differential.inline-patches to 999999 lines to see what it would look like.
@avivey It was like pulling teeth to get them to go from a git alias (i think git senddiff?) to arc diff. :-/ I do know a couple people on the team that uses the web UI that use arc patch as part of their review process (usually for reviewing UI changes to the app). I wish it was easier to automate creating and sending along screenshots of the app as part of a diff when it's UI related...
Anyone know what might cause two different "username closed D## REDACTED by committing rA#### REDACTED" to just keep showing up in the Feed over and over and over? Every few minutes these two just show up again. Other *real* events are occurring and showing in the Feed between them when they happen.
wish it was easier to automate creating and sending along screenshots of the app as part of a diff when it's UI
These things are mostly hard to automate because "Find the UI stuff that changed" is a very hard problem. But my flow for this is to use arc diff --browse and then print-screen and paste screenshots into a comment or into the Edit Task window.
If you can somehow solve the "Find UI stuff" (Maybe have a name for each screen, and put those names in the commit message?), it shouldn't be too hard to have harbormaster/bot make a build, load the right screens, and put on the right screenshots.
I seem to be having an issue with a herald rule that has "Commit is on auto-close branch" (the commit in question is on "master") and "master" is the first line of "Autoclose Only" for the repo in Diffusion, but herald transcript reads: "Failed Commit is on autoclose branch". Any ideas? :-/
- click "configure form" on the "create task" form,
- then click "Edit form configuration", I'm presented with a preview of the "create task form" great!
- Click edit form configuration: All I get is a form that displays: Name, preamble, visible to. So how does modifying a form work? is this a bug?
Hey @chad - recently the badges were removed from user hovercards, but in our setting those had a bit of info within those + some people got attached to seeing those (me included). I'd love to see them back on hovercards in one way or another... Would you like to see some of our ideas regarding badges place on hovercards? Or you see badges on hovercards as being problematic in design-wise sense and no point in having to deal with them 😉 ?
I have a small question about the Audit tool. We are an open-source, volunteer project so we use Audits not only to perform peer-review after a commit, but also (ideally) in order to remind ourselves that we need to fix things we committed.
Unfortunately, a commit author cannot "Raise a concern" over their own commit...