Page MenuHomePhabricator

benjamin.cohen-solal (Benjamin CohenSolal)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Jul 11 2013, 9:37 AM (319 w, 2 d)
Availability
Available

Recent Activity

Sep 19 2016

benjamin.cohen-solal added a project to T11660: Diff creation fails when submitting too long file paths: Differential.
Sep 19 2016, 2:52 PM · Differential, Bug Report
benjamin.cohen-solal created T11660: Diff creation fails when submitting too long file paths.
Sep 19 2016, 2:52 PM · Differential, Bug Report

Apr 8 2016

benjumanji awarded T10749: Add the Herald rule condition "when the revision has been closed" a Like token.
Apr 8 2016, 11:07 AM · Restricted Project, Herald, Harbormaster, Feature Request
benjamin.cohen-solal updated the task description for T10749: Add the Herald rule condition "when the revision has been closed".
Apr 8 2016, 10:03 AM · Restricted Project, Herald, Harbormaster, Feature Request
benjamin.cohen-solal created T10749: Add the Herald rule condition "when the revision has been closed".
Apr 8 2016, 10:02 AM · Restricted Project, Herald, Harbormaster, Feature Request

Feb 18 2016

benjamin.cohen-solal added a comment to T9069: arc patch can't handle binary file correctly.

I just removed a binary file (a .jpg file) and the command arc patch failed as following :

Feb 18 2016, 9:38 AM · Customer Impact, Differential, Restricted Project, Arcanist

Jan 15 2016

benjamin.cohen-solal added a comment to T10156: Add an ACL permission to authorize only few people to accept revisions.

You need or we need? Phabricator should only require one individual from the Blocking Reviewer project to satisfy the accept condition.

Jan 15 2016, 4:28 PM · Feature Request
benjamin.cohen-solal added a comment to T10156: Add an ACL permission to authorize only few people to accept revisions.

OK Chad, but if I add a specific blocking reviewer, another reviewer will be able to accept the revision but this one will stay in status "need review".
And if I add all the members of the code review committee as blocking reviewer, I gonna need all the blocking reviewer to accept the revision.
I'm sorry if my original message was not enough clear.

Jan 15 2016, 4:20 PM · Feature Request
benjamin.cohen-solal added a comment to T10156: Add an ACL permission to authorize only few people to accept revisions.

Yes I'm already subscribed to T4887 but I don't want to add a "blocking reviewer" as any member of the code review committee can accept the revision. And the task T731 is great but is complementary to what I'm asking. The case I describe is not covered by T731.

Jan 15 2016, 3:31 PM · Feature Request
benjamin.cohen-solal updated the task description for T10156: Add an ACL permission to authorize only few people to accept revisions.
Jan 15 2016, 3:13 PM · Feature Request
benjamin.cohen-solal renamed T10156: Add an ACL permission to authorize only few people to accept revisions from Let few people only the permission to accept revisions (ACL) to Add an ACL permission to authorize only few people to accept revisions.
Jan 15 2016, 9:33 AM · Feature Request
benjamin.cohen-solal created T10156: Add an ACL permission to authorize only few people to accept revisions.
Jan 15 2016, 9:26 AM · Feature Request

Oct 7 2015

benjamin.cohen-solal added a comment to T9069: arc patch can't handle binary file correctly.

It's a real problem when for example we store .mo files (binary translation files) or images, pdf, ...

Oct 7 2015, 8:40 AM · Customer Impact, Differential, Restricted Project, Arcanist

Sep 10 2015

benjamin.cohen-solal added a comment to T9145: Exception on arc diff with PHPCS linter.

In waiting for an official fix from Phabricator teams, if someone knows how to quickly fix this issue, it should be great to share it.

Sep 10 2015, 8:50 AM · Differential, Arcanist

Sep 8 2015

benjamin.cohen-solal awarded T9145: Exception on arc diff with PHPCS linter a Like token.
Sep 8 2015, 9:23 AM · Differential, Arcanist
benjamin.cohen-solal added a comment to T9145: Exception on arc diff with PHPCS linter.

I confirm having the same problem with phpcs linter. Each time phpcs raises warnings or errors, arcanist throws that exception and in my code review the Arcanist Lint Result remains into "Waiting for Message" status. You should fix it quickly as phpcs is not usable anymore :(

Sep 8 2015, 9:23 AM · Differential, Arcanist

Sep 2 2015

benjamin.cohen-solal updated the task description for T9320: Make possible to reference a phragment file into a phriction document.
Sep 2 2015, 1:30 PM · Phriction, Phragment
benjamin.cohen-solal created T9320: Make possible to reference a phragment file into a phriction document.
Sep 2 2015, 1:30 PM · Phriction, Phragment

Sep 1 2015

benjamin.cohen-solal added a comment to D9493: Fixing so that on windows local paths to binaries can be used.
Sep 1 2015, 7:43 AM

Oct 22 2014

benjamin.cohen-solal awarded T655: Integrate CustomField into Herald a Like token.
Oct 22 2014, 7:53 AM · Custom Fields, Herald

Oct 17 2014

benjamin.cohen-solal created T6341: Integrate CustomField into Herald rules.
Oct 17 2014, 3:43 PM · Herald
benjamin.cohen-solal created T6340: Criticity metric on differentials.
Oct 17 2014, 2:06 PM · Differential

May 13 2014

benjamin.cohen-solal added a comment to T5036: The variable buildable.commit doesn't seem to work in HTTP request.

ok thanks so this feature is not for me ;)
you can close the ticket

May 13 2014, 2:38 PM · Harbormaster
benjamin.cohen-solal added a comment to T5036: The variable buildable.commit doesn't seem to work in HTTP request.

So when is it expected ?

May 13 2014, 2:35 PM · Harbormaster
benjamin.cohen-solal created T5036: The variable buildable.commit doesn't seem to work in HTTP request.
May 13 2014, 12:45 PM · Harbormaster

Apr 22 2014

benjamin.cohen-solal added a comment to T4817: Create the event listener "before landing".

I actually followed this tutorial (very good tutorial) and it worked perfectly.
But the problem has never been to make work Jenkins and phabricator together but to avoid developers to land their branch while Jenkins is run

Apr 22 2014, 7:55 AM · Arcanist

Apr 17 2014

benjamin.cohen-solal added a comment to T4817: Create the event listener "before landing".

We use to run jenkins build (in waiting for harbormaster :)) after each diff creation (we implemented the event TYPE_DIFF_WASCREATED).
When jenkins finishes its build it will add a comment on the revision or reject it if a problem occured.

Apr 17 2014, 2:06 PM · Arcanist
benjamin.cohen-solal created T4817: Create the event listener "before landing".
Apr 17 2014, 12:36 PM · Arcanist
benjamin.cohen-solal added a comment to T4809: Make "arc land" complain if builds are still executing or have failed.

it should be nice to create an event listener "before landing"

Apr 17 2014, 12:29 PM · Harbormaster

Apr 10 2014

benjamin.cohen-solal created T4785: Interface to handle options of "select" custom fields.
Apr 10 2014, 1:32 PM · Custom Fields, Maniphest

Mar 6 2014

benjamin.cohen-solal updated the task description for T4565: Give the parameter diff_ID to TYPE_LAND_WILLPUSHREVISION event.
Mar 6 2014, 4:37 PM · Arcanist
benjamin.cohen-solal added a project to T4565: Give the parameter diff_ID to TYPE_LAND_WILLPUSHREVISION event: Arcanist.
Mar 6 2014, 4:37 PM · Arcanist

Mar 5 2014

benjamin.cohen-solal closed T4348: Provide a workflow for "auditing a codebase" via Nuance or some new tool as a duplicate.

✘ Merged into T4555.

Mar 5 2014, 10:55 AM · Diffusion
benjamin.cohen-solal updated subscribers of T4555: Audit source code instead of audit a commit.

◀ Merged tasks: T4348.

Mar 5 2014, 10:55 AM · Audit
benjamin.cohen-solal updated the task description for T4555: Audit source code instead of audit a commit.
Mar 5 2014, 9:11 AM · Audit
benjamin.cohen-solal raised the priority of T4555: Audit source code instead of audit a commit from to Wishlist.
Mar 5 2014, 9:09 AM · Audit