(stable) Promote 2020 Week 17
Audit Requiredefab6b9ae33c
Actions

Description

(stable) Promote 2020 Week 17

Details

Group Auditors

Provenance

epriestley	Authored on May 1 2020, 7:57 PM
epriestley	Pushed on May 1 2020, 7:58 PM

Parents

rPb89e6c0fa91a: Add "idea://" to the upstream editor whitelist
rP4a7a66975613: (stable) Stabilize fatals when a build has a build plan the viewer can't see…

Branches

Unknown

Tags

Unknown

Build Status

Buildable 24318
Build 33500: Run Core Tests

Event Timeline

epriestley committed rPefab6b9ae33c: (stable) Promote 2020 Week 17 (authored by epriestley).May 1 2020, 7:57 PM

Herald added an auditor: Cowboy Commits. · View Herald TranscriptMay 1 2020, 7:58 PM

This commit now requires audit.May 1 2020, 7:58 PM

Harbormaster completed building B24318: rPefab6b9ae33c: (stable) Promote 2020 Week 17.May 1 2020, 7:59 PM

Merged Changes

b89e6c0fa91a Add "idea://" to the upstream editor whitelist
Author
epriestley
Revisions
D21206: Add "idea://" to the upstream editor whitelist
Browse Repository
Passed
No Audits
120507068700 Use underlines instead of background color to show file moves/renames
Author
epriestley
Revisions
D21205: Use underlines instead of background color to show file moves/renames
Browse Repository
Passed
No Audits
eab561bb8790 Add "uri" to the API results for File objects
Author
epriestley
Revisions
D21204: Add "uri" to the API results for File objects
Browse Repository
Passed
No Audits
fbbd2e35cb46 Make content more prominent in Files and move some details to the curtain
Author
epriestley
Revisions
D21201: Make content more prominent in Files and move some details to the curtain
Browse Repository
Passed
No Audits
1edca1ee2a8a Put application curtain panels above extension curtain panels
Author
epriestley
Revisions
D21200: Put application curtain panels above extension curtain panels
Browse Repository
Passed
No Audits
d6928a3c2679 When creating a File storage object for a Paste, try to give it the same name…
Author
epriestley
Revisions
D21197: When creating a File storage object for a Paste, try to give it the same name as the Paste
Browse Repository
Passed
No Audits
3c1f393c812f When a Paste has a useful alternative rendering in Files, provide a hint
Author
epriestley
Revisions
D21196: When a Paste has a useful alternative rendering in Files, provide a hint
Browse Repository
Passed
No Audits
65a2b5e21934 Route hard-coded "/favicon.ico" requests to a favicon resource
Author
epriestley
Revisions
D21195: Route hard-coded "/favicon.ico" requests to a favicon resource
Browse Repository
Passed
No Audits
304467feb2ae Stabilize fatals when a build has a build plan the viewer can't see because of…
Author
epriestley
Revisions
D21194: Stabilize fatals when a build has a build plan the viewer can't see because of policy restrictions
Browse Repository
Passed
No Audits
186a12ef7f2a Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
Author
epriestley
Revisions
D21189: Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
Browse Repository
Passed
No Audits
b648a8584111 Fix an issue where the Maniphest burnup chart was trying to render a non-View…
Author
epriestley
Revisions
D21185: Fix an issue where the Maniphest burnup chart was trying to render a non-View object
Browse Repository
Passed
No Audits
f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Revisions
D21183: Update the diff table of contents to use hierarchical views and edit distance renames
Browse Repository
Passed
No Audits
a7b2327c34ac Fix an issue with "Auditors:" where an edge edit was used as a PHID list
Author
epriestley
Revisions
D21181: Fix an issue with "Auditors:" where an edge edit was used as a PHID list
Browse Repository
Passed
No Audits
befeb17f6ff1 Improve the construction of synthetic "comparison/intradiff" changesets
Author
epriestley
Revisions
D21180: Improve the construction of synthetic "comparison/intradiff" changesets
Browse Repository
Passed
No Audits
5eaa0f24e7b7 Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()"
Author
epriestley
Revisions
D21179: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()"
Browse Repository
Passed
No Audits
aa20faeaa5d1 Fix an invalid index access for synthetic lint inline comments from Harbormaster
Author
epriestley
Revisions
D21178: Fix an invalid index access for synthetic lint inline comments from Harbormaster
Browse Repository
Passed
No Audits
661700536579 Make Conduit "www-form-urlencoded" parsing of "true" and "false" case…
Author
epriestley
Revisions
D21177: Make Conduit "www-form-urlencoded" parsing of "true" and "false" case-insensitive
Browse Repository
Passed
No Audits
b5bed7b0fa87 Make omitting "value" from a transaction description an explicit error
Author
epriestley
Revisions
D21176: Make omitting "value" from a transaction description an explicit error
Browse Repository
Passed
No Audits
604811bfc554 Fix a Diffusion issue where commits that do not show changesets would…
Author
epriestley
Revisions
D21175: Fix a Diffusion issue where commits that do not show changesets would incorrectly try to render changesets
Browse Repository
Passed
No Audits
c12db282519d For changesets that affect binaries, use the new binary file content hash as an…
Author
epriestley
Revisions
D21174: For changesets that affect binaries, use the new binary file content hash as an effect hash
Browse Repository
Passed
No Audits
b0c295e54509 Fix some PHP 7.4 array index access issues
Author
epriestley
Revisions
D21172: Fix some PHP 7.4 array index access issues
Browse Repository
Passed
No Audits
7355bb7f2956 Skip "null" lines when constructing raw documents for DocumentEngine rendering
Author
epriestley
Revisions
D21171: Skip "null" lines when constructing raw documents for DocumentEngine rendering
Browse Repository
Passed
No Audits
a226d7413383 Use "rest/api/3/myself" to retrieve JIRA profile details, not…
Author
epriestley
Revisions
D21170: Use "rest/api/3/myself" to retrieve JIRA profile details, not "rest/auth/1/session"
Browse Repository
Passed
No Audits
40d2346f2965 Add a missing "null" check when rebuilding old/new diff content
Author
epriestley
Revisions
D21169: Add a missing "null" check when rebuilding old/new diff content
Browse Repository
Passed
No Audits
454ecb56e3ac When proxying HTTP repository responses from repository nodes, discard content…
Author
epriestley
Revisions
D21167: When proxying HTTP repository responses from repository nodes, discard content description headers
Browse Repository
Passed
No Audits
6f7147376f87 Parse "multipart/form-data" bodies even if "enable_post_data_reading" is on
Author
epriestley
Revisions
D21165: Parse "multipart/form-data" bodies even if "enable_post_data_reading" is on
Browse Repository
Passed
No Audits
5a460e4ea57d Stick the page footer in the right place on Formation View pages
Author
epriestley
Revisions
D21166: Stick the page footer in the right place on Formation View pages
Browse Repository
Passed
No Audits

Changes (27)

Path

Size

resources/

celerity/

map.php

src/

__phutil_library_map__.php

applications/

config/

option/

PhabricatorSecurityConfigOptions.php

console/

core/

DarkConsoleCore.php

differential/

constants/

DifferentialChangeType.php

controller/

DifferentialChangesetViewController.php

engine/

DifferentialChangesetEngine.php

management/

PhabricatorDifferentialRebuildChangesetsWorkflow.php

parser/

DifferentialChangesetParser.php

render/

DifferentialChangesetRenderer.php

storage/

DifferentialChangeset.php

DifferentialDiff.php

files/

controller/

PhabricatorFileViewController.php

document/

PhabricatorDocumentEngine.php

PhabricatorJupyterDocumentEngine.php

render/

PhabricatorDocumentRenderingEngine.php

storage/

PhabricatorFile.php

paste/

controller/

PhabricatorPasteViewController.php

editor/

PhabricatorPasteEditor.php

xaction/

PhabricatorPasteContentTransaction.php

settings/

panel/

PhabricatorExternalEditorSettingsPanel.php

system/

application/

PhabricatorSystemApplication.php

controller/

PhabricatorFaviconController.php

infrastructure/

diff/

view/

PHUIDiffTableOfContentsItemView.php

PHUIDiffTableOfContentsListView.php

view/

layout/

PHUICurtainView.php

webroot/

rsrc/

css/

application/

differential/

table-of-contents.css

rPefab6b9ae33c

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/config/option/PhabricatorSecurityConfigOptions.php

View Options

src/applications/console/core/DarkConsoleCore.php

View Options

src/applications/differential/constants/DifferentialChangeType.php

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

View Options

src/applications/differential/engine/DifferentialChangesetEngine.php

View Options

src/applications/differential/management/PhabricatorDifferentialRebuildChangesetsWorkflow.php

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

View Options

src/applications/differential/storage/DifferentialChangeset.php

View Options

src/applications/differential/storage/DifferentialDiff.php

View Options

src/applications/files/controller/PhabricatorFileViewController.php

View Options

src/applications/files/document/PhabricatorDocumentEngine.php

View Options

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

View Options

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

View Options

src/applications/files/storage/PhabricatorFile.php

View Options

src/applications/paste/controller/PhabricatorPasteViewController.php

View Options

src/applications/paste/editor/PhabricatorPasteEditor.php

View Options

src/applications/paste/xaction/PhabricatorPasteContentTransaction.php

View Options

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

View Options

src/applications/system/application/PhabricatorSystemApplication.php

View Options

src/applications/system/controller/PhabricatorFaviconController.php

View Options

src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php

View Options

src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php

View Options

src/view/layout/PHUICurtainView.php

View Options

webroot/rsrc/css/application/differential/table-of-contents.css

(stable) Promote 2020 Week 17Audit Requiredefab6b9ae33cActions

Description

Details

Event Timeline

Merged Changes

Changes (27)

rPefab6b9ae33c

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/config/option/PhabricatorSecurityConfigOptions.php

src/applications/console/core/DarkConsoleCore.php

src/applications/differential/constants/DifferentialChangeType.php

src/applications/differential/controller/DifferentialChangesetViewController.php

src/applications/differential/engine/DifferentialChangesetEngine.php

src/applications/differential/management/PhabricatorDifferentialRebuildChangesetsWorkflow.php

src/applications/differential/parser/DifferentialChangesetParser.php

src/applications/differential/render/DifferentialChangesetRenderer.php

src/applications/differential/storage/DifferentialChangeset.php

src/applications/differential/storage/DifferentialDiff.php

src/applications/files/controller/PhabricatorFileViewController.php

src/applications/files/document/PhabricatorDocumentEngine.php

src/applications/files/document/PhabricatorJupyterDocumentEngine.php

src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php

src/applications/files/storage/PhabricatorFile.php

src/applications/paste/controller/PhabricatorPasteViewController.php

src/applications/paste/editor/PhabricatorPasteEditor.php

src/applications/paste/xaction/PhabricatorPasteContentTransaction.php

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

src/applications/system/application/PhabricatorSystemApplication.php

src/applications/system/controller/PhabricatorFaviconController.php

src/infrastructure/diff/view/PHUIDiffTableOfContentsItemView.php

src/infrastructure/diff/view/PHUIDiffTableOfContentsListView.php

src/view/layout/PHUICurtainView.php

webroot/rsrc/css/application/differential/table-of-contents.css

(stable) Promote 2020 Week 17
Audit Requiredefab6b9ae33c
Actions