Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()"
ClosedPublic
Actions

Authored by epriestley on Apr 28 2020, 10:56 AM.

Details

Reviewers: None
Maniphest Tasks: T13525: "apcu_store()" may raise "GC cache entry ..." errors
Commits: rPa338b1f43308: (stable) Use "@" to silence "GC list" warnings from "apc_store()" and…
rP5eaa0f24e7b7: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()"

Summary

Fixes T13525. Since D21044, the intermittent GC list warnings are treated more severely and can become user-visible errors.

Silence them, since this seems to be the only realistic response in most versions of APC/APCu.

Test Plan

Will deploy.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 28 2020, 10:56 AM

Harbormaster completed remote builds in B24254: Diff 50435.Apr 28 2020, 10:57 AM

epriestley requested review of this revision.Apr 28 2020, 10:57 AM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 28 2020, 11:13 AM

This revision was landed with ongoing or failed builds.

Closed by commit rP5eaa0f24e7b7: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5eaa0f24e7b7: Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()".

epriestley added a commit: rPa338b1f43308: (stable) Use "@" to silence "GC list" warnings from "apc_store()" and….

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

cache/

PhutilAPCKeyValueCache.php

7 lines

support/

startup/

PhabricatorClientLimit.php

12 lines

Diff 50436

View Options

src/infrastructure/cache/PhutilAPCKeyValueCache.php